Re: 4.15.14 crash with iscsi target and dvd

2018-04-14 Thread Wakko Warner
Ming Lei wrote: > On Thu, Apr 12, 2018 at 09:43:02PM -0400, Wakko Warner wrote: > > Ming Lei wrote: > > > On Tue, Apr 10, 2018 at 08:45:25PM -0400, Wakko Warner wrote: > > > > Sorry for the delay. I reverted my change, added this one. I didn't > > > > reboot, I just unloaded and loaded this one.

Re: 4.15.14 crash with iscsi target and dvd

2018-04-12 Thread Ming Lei
On Thu, Apr 12, 2018 at 09:43:02PM -0400, Wakko Warner wrote: > Ming Lei wrote: > > On Tue, Apr 10, 2018 at 08:45:25PM -0400, Wakko Warner wrote: > > > Sorry for the delay. I reverted my change, added this one. I didn't > > > reboot, I just unloaded and loaded this one. > > > Note: /dev/sr1 as

Re: 4.15.14 crash with iscsi target and dvd

2018-04-12 Thread Wakko Warner
Ming Lei wrote: > On Tue, Apr 10, 2018 at 08:45:25PM -0400, Wakko Warner wrote: > > Sorry for the delay. I reverted my change, added this one. I didn't > > reboot, I just unloaded and loaded this one. > > Note: /dev/sr1 as seen from the initiator is /dev/sr0 (physical disc) on the > > target. >

Re: 4.15.14 crash with iscsi target and dvd

2018-04-12 Thread Ming Lei
On Tue, Apr 10, 2018 at 08:45:25PM -0400, Wakko Warner wrote: > Ming Lei wrote: > > Sure, thanks for your sharing. > > > > Wakko, could you test the following patch and see if there is any > > difference? > > > > -- > > diff --git a/drivers/target/target_core_pscsi.c > >

Re: 4.15.14 crash with iscsi target and dvd

2018-04-11 Thread Wakko Warner
Wakko Warner wrote: > Ming Lei wrote: > > Sure, thanks for your sharing. > > > > Wakko, could you test the following patch and see if there is any > > difference? > > > > -- > > diff --git a/drivers/target/target_core_pscsi.c > > b/drivers/target/target_core_pscsi.c > > index

Re: 4.15.14 crash with iscsi target and dvd

2018-04-10 Thread Wakko Warner
Ming Lei wrote: > Sure, thanks for your sharing. > > Wakko, could you test the following patch and see if there is any > difference? > > -- > diff --git a/drivers/target/target_core_pscsi.c > b/drivers/target/target_core_pscsi.c > index 0d99b242e82e..6147178f1f37 100644 > ---

Re: 4.15.14 crash with iscsi target and dvd

2018-04-09 Thread Ming Lei
On Mon, Apr 09, 2018 at 07:43:01PM -0400, Wakko Warner wrote: > Ming Lei wrote: > > On Mon, Apr 09, 2018 at 09:30:11PM +, Bart Van Assche wrote: > > > Hello Ming, > > > > > > Can you have a look at this? The start of this e-mail thread is available > > > at > > >

Re: 4.15.14 crash with iscsi target and dvd

2018-04-09 Thread Wakko Warner
Ming Lei wrote: > On Mon, Apr 09, 2018 at 09:30:11PM +, Bart Van Assche wrote: > > Hello Ming, > > > > Can you have a look at this? The start of this e-mail thread is available at > > https://www.mail-archive.com/linux-scsi@vger.kernel.org/msg72574.html. > > Sure, thanks for your sharing. >

Re: 4.15.14 crash with iscsi target and dvd

2018-04-09 Thread Ming Lei
On Mon, Apr 09, 2018 at 09:30:11PM +, Bart Van Assche wrote: > On Sun, 2018-04-08 at 12:02 -0400, Wakko Warner wrote: > > I finished with git bisect. Here's the output: > > 84c8590646d5b35804bac60eb58b145839b5893e is the first bad commit > > commit 84c8590646d5b35804bac60eb58b145839b5893e > >

Re: 4.15.14 crash with iscsi target and dvd

2018-04-09 Thread Bart Van Assche
On Sun, 2018-04-08 at 12:02 -0400, Wakko Warner wrote: > I finished with git bisect. Here's the output: > 84c8590646d5b35804bac60eb58b145839b5893e is the first bad commit > commit 84c8590646d5b35804bac60eb58b145839b5893e > Author: Ming Lei > Date: Fri Nov 11 20:05:32

Re: 4.15.14 crash with iscsi target and dvd

2018-04-08 Thread Wakko Warner
Wakko Warner wrote: > Bart Van Assche wrote: > > Have you tried to modify the kernel Makefile as indicated in the following > > e-mail? This should make the kernel build: > > > > https://lists.ubuntu.com/archives/kernel-team/2016-May/077178.html > > Thanks. That helped. > > I finished with git

Re: 4.15.14 crash with iscsi target and dvd

2018-04-08 Thread Wakko Warner
Bart Van Assche wrote: > On Sat, 2018-04-07 at 12:53 -0400, Wakko Warner wrote: > > Bart Van Assche wrote: > > > On Thu, 2018-04-05 at 22:06 -0400, Wakko Warner wrote: > > > > I know now why scsi_print_command isn't doing anything. cmd->cmnd is > > > > null. > > > > I added a dev_printk in

Re: 4.15.14 crash with iscsi target and dvd

2018-04-07 Thread Wakko Warner
Wakko Warner wrote: > Bart Van Assche wrote: > > On Thu, 2018-04-05 at 22:06 -0400, Wakko Warner wrote: > > > I know now why scsi_print_command isn't doing anything. cmd->cmnd is > > > null. > > > I added a dev_printk in scsi_print_command where the 2 if statements > > > return. > > > Logs: > >

Re: 4.15.14 crash with iscsi target and dvd

2018-04-07 Thread Wakko Warner
Bart Van Assche wrote: > On Thu, 2018-04-05 at 22:06 -0400, Wakko Warner wrote: > > I know now why scsi_print_command isn't doing anything. cmd->cmnd is null. > > I added a dev_printk in scsi_print_command where the 2 if statements return. > > Logs: > > [ 29.866415] sr 3:0:0:0: cmd->cmnd is NULL

Re: 4.15.14 crash with iscsi target and dvd

2018-04-06 Thread Bart Van Assche
On Fri, 2018-04-06 at 21:03 -0400, Wakko Warner wrote: > Bart Van Assche wrote: > > On Thu, 2018-04-05 at 22:06 -0400, Wakko Warner wrote: > > > I know now why scsi_print_command isn't doing anything. cmd->cmnd is > > > null. > > > I added a dev_printk in scsi_print_command where the 2 if

Re: 4.15.14 crash with iscsi target and dvd

2018-04-06 Thread Wakko Warner
Bart Van Assche wrote: > On Thu, 2018-04-05 at 22:06 -0400, Wakko Warner wrote: > > I know now why scsi_print_command isn't doing anything. cmd->cmnd is null. > > I added a dev_printk in scsi_print_command where the 2 if statements return. > > Logs: > > [ 29.866415] sr 3:0:0:0: cmd->cmnd is NULL

Re: 4.15.14 crash with iscsi target and dvd

2018-04-06 Thread Wakko Warner
Bart Van Assche wrote: > On Thu, 2018-04-05 at 22:06 -0400, Wakko Warner wrote: > > I know now why scsi_print_command isn't doing anything. cmd->cmnd is null. > > I added a dev_printk in scsi_print_command where the 2 if statements return. > > Logs: > > [ 29.866415] sr 3:0:0:0: cmd->cmnd is NULL

Re: 4.15.14 crash with iscsi target and dvd

2018-04-05 Thread Bart Van Assche
On Thu, 2018-04-05 at 22:06 -0400, Wakko Warner wrote: > I know now why scsi_print_command isn't doing anything. cmd->cmnd is null. > I added a dev_printk in scsi_print_command where the 2 if statements return. > Logs: > [ 29.866415] sr 3:0:0:0: cmd->cmnd is NULL That's something that should

Re: 4.15.14 crash with iscsi target and dvd

2018-04-05 Thread Wakko Warner
Wakko Warner wrote: > Bart Van Assche wrote: > > On Sun, 2018-04-01 at 14:27 -0400, Wakko Warner wrote: > > > Wakko Warner wrote: > > > > Wakko Warner wrote: > > > > > I tested 4.14.32 last night with the same oops. 4.9.91 works fine. > > > > > From the initiator, if I do cat /dev/sr1 > /dev/null

Re: 4.15.14 crash with iscsi target and dvd

2018-04-05 Thread Wakko Warner
Bart Van Assche wrote: > On Sun, 2018-04-01 at 14:27 -0400, Wakko Warner wrote: > > Wakko Warner wrote: > > > Wakko Warner wrote: > > > > I tested 4.14.32 last night with the same oops. 4.9.91 works fine. > > > > From the initiator, if I do cat /dev/sr1 > /dev/null it works. If I > > > > mount

Re: 4.15.14 crash with iscsi target and dvd

2018-04-04 Thread Wakko Warner
Bart Van Assche wrote: > On Sun, 2018-04-01 at 14:27 -0400, Wakko Warner wrote: > > Wakko Warner wrote: > > > Wakko Warner wrote: > > > > I tested 4.14.32 last night with the same oops. 4.9.91 works fine. > > > > From the initiator, if I do cat /dev/sr1 > /dev/null it works. If I > > > > mount

Re: 4.15.14 crash with iscsi target and dvd

2018-04-03 Thread Bart Van Assche
On Sun, 2018-04-01 at 14:27 -0400, Wakko Warner wrote: > Wakko Warner wrote: > > Wakko Warner wrote: > > > I tested 4.14.32 last night with the same oops. 4.9.91 works fine. > > > From the initiator, if I do cat /dev/sr1 > /dev/null it works. If I mount > > > /dev/sr1 and then do find -type f |

Re: 4.15.14 crash with iscsi target and dvd

2018-04-01 Thread Wakko Warner
Wakko Warner wrote: > Wakko Warner wrote: > > Bart Van Assche wrote: > > > On Sat, 2018-03-31 at 18:12 -0400, Wakko Warner wrote: > > > > Richard Weinberger wrote: > > > > > On Sat, Mar 31, 2018 at 3:59 AM, Wakko Warner > > > > > wrote: > > > > > > I reported this before but

Re: 4.15.14 crash with iscsi target and dvd

2018-04-01 Thread Bart Van Assche
On Sun, 2018-04-01 at 12:24 -0400, Wakko Warner wrote: > What do you enable in the kernel to get those locking messages? Hello Wakko, I have attached the script to this e-mail that I use to enable a bunch of kernel debugging options. Please note that enabling these options, especially lockdep

Re: 4.15.14 crash with iscsi target and dvd

2018-04-01 Thread Wakko Warner
Bart Van Assche wrote: > On Sun, 2018-04-01 at 07:37 -0400, Wakko Warner wrote: > > Bart Van Assche wrote: > > > On Sat, 2018-03-31 at 18:12 -0400, Wakko Warner wrote: > > > > Richard Weinberger wrote: > > > > > On Sat, Mar 31, 2018 at 3:59 AM, Wakko Warner > > > > > wrote: >

Re: 4.15.14 crash with iscsi target and dvd

2018-04-01 Thread Bart Van Assche
On Sun, 2018-04-01 at 07:37 -0400, Wakko Warner wrote: > Bart Van Assche wrote: > > On Sat, 2018-03-31 at 18:12 -0400, Wakko Warner wrote: > > > Richard Weinberger wrote: > > > > On Sat, Mar 31, 2018 at 3:59 AM, Wakko Warner > > > > wrote: > > > > > I reported this before but

Re: 4.15.14 crash with iscsi target and dvd

2018-04-01 Thread Wakko Warner
Bart Van Assche wrote: > On Sat, 2018-03-31 at 18:12 -0400, Wakko Warner wrote: > > Richard Weinberger wrote: > > > On Sat, Mar 31, 2018 at 3:59 AM, Wakko Warner wrote: > > > > I reported this before but noone responded. > > > > > > Because you're sending only to LKML. > > >

Re: 4.15.14 crash with iscsi target and dvd

2018-03-31 Thread Bart Van Assche
On Sat, 2018-03-31 at 18:12 -0400, Wakko Warner wrote: > Richard Weinberger wrote: > > On Sat, Mar 31, 2018 at 3:59 AM, Wakko Warner wrote: > > > I reported this before but noone responded. > > > > Because you're sending only to LKML. > > CC'ing storage folks. > > Thank you.

Re: 4.15.14 crash with iscsi target and dvd

2018-03-31 Thread Wakko Warner
Richard Weinberger wrote: > On Sat, Mar 31, 2018 at 3:59 AM, Wakko Warner wrote: > > I reported this before but noone responded. > > Because you're sending only to LKML. > CC'ing storage folks. Thank you. I wasn't sure who I needed to send it to.

Re: 4.15.14 crash with iscsi target and dvd

2018-03-31 Thread Richard Weinberger
On Sat, Mar 31, 2018 at 3:59 AM, Wakko Warner wrote: > I reported this before but noone responded. Because you're sending only to LKML. CC'ing storage folks. > I have an iscsi target setup with /dev/sr[012] using pscsi. On the > initiator, I mount only 1 disc. Then I issue