Re: scsi: sg: assorted memory corruptions

2018-02-10 Thread Eric Biggers
On Sun, Feb 04, 2018 at 12:10:58PM +0100, Dmitry Vyukov wrote: > > > > To get memory corruption it's actually sufficient just to submit "1-byte" > > reads; > > there's no need for the SG_NEXT_CMD_LEN ioctl or anything: > > > > #include > > #include > > > > int main() > >

Re: scsi: sg: assorted memory corruptions

2018-02-04 Thread Dmitry Vyukov
On Sun, Feb 4, 2018 at 10:07 AM, Eric Biggers wrote: > On Thu, Feb 01, 2018 at 05:21:12PM +0100, 'Dmitry Vyukov' via syzkaller wrote: >> On Thu, Feb 1, 2018 at 5:17 PM, Ben Hutchings >> wrote: >> > On Thu, 2018-02-01 at 08:04 +0100, Dmitry

Re: scsi: sg: assorted memory corruptions

2018-02-04 Thread Eric Biggers
On Thu, Feb 01, 2018 at 05:21:12PM +0100, 'Dmitry Vyukov' via syzkaller wrote: > On Thu, Feb 1, 2018 at 5:17 PM, Ben Hutchings > wrote: > > On Thu, 2018-02-01 at 08:04 +0100, Dmitry Vyukov wrote: > >> On Thu, Feb 1, 2018 at 7:03 AM, Douglas Gilbert

Re: scsi: sg: assorted memory corruptions

2018-02-01 Thread Dmitry Vyukov
On Thu, Feb 1, 2018 at 5:17 PM, Ben Hutchings wrote: > On Thu, 2018-02-01 at 08:04 +0100, Dmitry Vyukov wrote: >> On Thu, Feb 1, 2018 at 7:03 AM, Douglas Gilbert >> wrote: >> > On 2018-01-30 07:22 AM, Dmitry Vyukov wrote: > [...] >> > >

Re: scsi: sg: assorted memory corruptions

2018-02-01 Thread Ben Hutchings
On Thu, 2018-02-01 at 08:04 +0100, Dmitry Vyukov wrote: > On Thu, Feb 1, 2018 at 7:03 AM, Douglas Gilbert wrote: > > On 2018-01-30 07:22 AM, Dmitry Vyukov wrote: [...] > > > [1:0:0:0]cd/dvd  QEMU QEMU DVD-ROM 2.0.  /dev/sr0   /dev/sg1 > > > > > > # readlink

Re: scsi: sg: assorted memory corruptions

2018-01-31 Thread Dmitry Vyukov
On Thu, Feb 1, 2018 at 7:03 AM, Douglas Gilbert wrote: > On 2018-01-30 07:22 AM, Dmitry Vyukov wrote: >> >> Uh, I've answered this a week ago, but did not notice that Doug >> dropped everybody from CC. Reporting to all. >> >> On Mon, Jan 22, 2018 at 8:16 PM, Douglas Gilbert

Re: scsi: sg: assorted memory corruptions

2018-01-31 Thread Douglas Gilbert
On 2018-01-30 07:22 AM, Dmitry Vyukov wrote: Uh, I've answered this a week ago, but did not notice that Doug dropped everybody from CC. Reporting to all. On Mon, Jan 22, 2018 at 8:16 PM, Douglas Gilbert wrote: On 2018-01-22 02:06 PM, Dmitry Vyukov wrote: On Mon, Jan

Re: scsi: sg: assorted memory corruptions

2018-01-22 Thread Bart Van Assche
On Mon, 2018-01-22 at 20:06 +0100, Dmitry Vyukov wrote: > On Mon, Jan 22, 2018 at 7:57 PM, Douglas Gilbert > wrote: > > As far as I remember, Dmitry has not indicated in multiple reports > > over several years what /dev/sg0 is. > > That's because I know nothing about sg.

Re: scsi: sg: assorted memory corruptions

2018-01-22 Thread Dmitry Vyukov
On Mon, Jan 22, 2018 at 7:57 PM, Douglas Gilbert wrote: > On 2018-01-22 11:30 AM, Bart Van Assche wrote: >> >> On Mon, 2018-01-22 at 12:06 +0100, Dmitry Vyukov wrote: >>> >>> general protection fault: [#1] SMP KASAN >> >> >> How about the untested patch below? >> >>

Re: scsi: sg: assorted memory corruptions

2018-01-22 Thread Douglas Gilbert
On 2018-01-22 11:30 AM, Bart Van Assche wrote: On Mon, 2018-01-22 at 12:06 +0100, Dmitry Vyukov wrote: general protection fault: [#1] SMP KASAN How about the untested patch below? Thanks, Bart. diff --git a/drivers/scsi/sg.c b/drivers/scsi/sg.c index cd9b6ebd7257..04a644b39d79 100644

Re: scsi: sg: assorted memory corruptions

2018-01-22 Thread Bart Van Assche
On Mon, 2018-01-22 at 12:06 +0100, Dmitry Vyukov wrote: > general protection fault: [#1] SMP KASAN How about the untested patch below? Thanks, Bart. diff --git a/drivers/scsi/sg.c b/drivers/scsi/sg.c index cd9b6ebd7257..04a644b39d79 100644 --- a/drivers/scsi/sg.c +++ b/drivers/scsi/sg.c