[PATCH v2 1/3] coredump: Replace opencoded set_mask_bits()

2019-01-23 Thread Vineet Gupta
Cc: Alexander Viro Cc: Peter Zijlstra (Intel) Cc: linux-fsde...@vger.kernel.org Cc: linux-ker...@vger.kernel.org Link: http://lkml.kernel.org/g/20150807115710.ga16...@redhat.com Reviewed-by: Anthony Yznaga Acked-by: Oleg Nesterov Signed-off-by: Vineet Gupta --- fs/exec.c | 7 +-- 1 file

[PATCH v2 2/3] fs: inode_set_flags() replace opencoded set_mask_bits()

2019-01-23 Thread Vineet Gupta
It seems that 5f16f3225b0624 and 00a1a053ebe5, both with same commitlog ("ext4: atomically set inode->i_flags in ext4_set_inode_flags()") introduced the set_mask_bits API, but somehow missed not using it in ext4 in the end Also, set_mask_bits is used in fs quite a bit and we can possibly come up

[PATCH v2 0/3] Replace opencoded set_mask_bits

2019-01-23 Thread Vineet Gupta
Hi, Repost of [1] rebased on 5.0-rc3 + accumulated Acked-by/Reviewed-by. No code changes since v1. Please consider applying. [1] http://lists.infradead.org/pipermail/linux-snps-arc/2019-January/005201.html Thx, -Vineet Vineet Gupta (3): coredump: Replace opencoded set_mask_bits() fs:

[PATCH v2 3/3] bitops.h: set_mask_bits() to return old value

2019-01-23 Thread Vineet Gupta
| > Also, set_mask_bits is used in fs quite a bit and we can possibly come up | > with a generic llsc based implementation (w/o the cmpxchg loop) | | May I also suggest changing the return value of set_mask_bits() to old. | | You can compute the new value given old, but you cannot compute the old

Semantics of symbol address in perf report -v

2019-01-23 Thread Vineet Gupta
Hi, I noticed a small anomaly in perf report -v output on ARC and x86 as well. A simple program which sits in tight loop, compiled for x86_64 void main() { while(1) {} } $ gcc -g tight.c $ ./a.out & $ perf record -e cycles -p 26703 $ perf report -n -v --stdio | egrep "(main|Symbol)" |#

Re: misc/check-installed-headers-c failing due to upstream kernel change

2019-01-23 Thread Carlos O'Donell
On 1/23/19 12:13 PM, Vineet Gupta wrote: > On 1/23/19 8:51 AM, Carlos O'Donell wrote: >> On 1/23/19 10:57 AM, Ben Hutchings wrote: >>> On Mon, 2019-01-21 at 14:56 -0800, Vineet Gupta wrote: Hi, It seems a recent upstream kernel change (went in 5.0-rcX) 81c9d43f9487

Re: misc/check-installed-headers-c failing due to upstream kernel change

2019-01-23 Thread Vineet Gupta
On 1/23/19 8:51 AM, Carlos O'Donell wrote: > On 1/23/19 10:57 AM, Ben Hutchings wrote: >> On Mon, 2019-01-21 at 14:56 -0800, Vineet Gupta wrote: >>> Hi, >>> >>> It seems a recent upstream kernel change (went in 5.0-rcX) 81c9d43f9487 >>> ("kernel/sysctl: add panic_print into sysctl") trips one of