Re: __syscall_error (was Re: [PATCH v4 13/15] ARC: Build Infrastructure)

2020-04-02 Thread Vineet Gupta
On 4/2/20 1:50 AM, Florian Weimer via Libc-alpha wrote: >> What if you move it to GLIBC_PRIVATE? My concern isn't that it's exported >> from the shared library, it's that it's exported at a public version. > > I think it's preferable to duplicate __syscall_error in each shared > object that

[PATCH] ARC: Fix ICCM & DCCM runtime size checks

2020-04-02 Thread Eugeniy Paltsev
As of today the ICCM and DCCM size checks are incorrectly using mismatched units (KiB checked against bytes). The CONFIG_ARC_DCCM_SZ and CONFIG_ARC_ICCM_SZ are in KiB, but the size calculated in runtime and stored in cpu->dccm.sz and cpu->iccm.sz is in bytes. Fix that. Reported-by: Paul Greco

Re: [RFC] ARC: initial ftrace support

2020-04-02 Thread Steven Rostedt
On Thu, 2 Apr 2020 01:17:01 + Vineet Gupta wrote: > +CC Claudiu > > On 3/27/20 10:10 AM, Steven Rostedt wrote: > > On Fri, 27 Mar 2020 18:53:55 +0300 > > Eugeniy Paltsev wrote: > > Maybe add a comment that gcc does the heavy lifting: I have following in glibc > > +/* this is very

RE: [RFC] ARC: initial ftrace support

2020-04-02 Thread Alexey Brodkin
Hi Claus, > -Original Message- > From: linux-snps-arc On Behalf > Of Claudiu Zissulescu > Ianculescu > Sent: Thursday, April 2, 2020 11:10 AM > To: Vineet Gupta > Cc: Alexey Brodkin ; linux-ker...@vger.kernel.org; > Steven Rostedt > ; Ingo Molnar ; >

Re: __syscall_error (was Re: [PATCH v4 13/15] ARC: Build Infrastructure)

2020-04-02 Thread Florian Weimer
* Joseph Myers: > What if you move it to GLIBC_PRIVATE? My concern isn't that it's exported > from the shared library, it's that it's exported at a public version. I think it's preferable to duplicate __syscall_error in each shared object that needs it. It avoids potential strange loops if

Re: [RFC] ARC: initial ftrace support

2020-04-02 Thread Claudiu Zissulescu Ianculescu
Hi, ARC-gcc has two modes to call the mcount routines. When using elf32 configuration, the toolchain is set to use newlib mcount. When configured for linux, gcc toolchain is using a library call to _mcall (single underscore) having blink as input argument. So, using the proper linux toolchain,