Re: [PATCH 20/20] arch: dts: Fix DWC USB3 DT nodes name

2020-10-14 Thread Serge Semin
On Wed, Oct 14, 2020 at 10:04:32PM +0200, Krzysztof Kozlowski wrote: > On Wed, 14 Oct 2020 at 19:16, Serge Semin > wrote: > > > > On Wed, Oct 14, 2020 at 12:33:25PM +0200, Krzysztof Kozlowski wrote: > > > On Wed, 14 Oct 2020 at 12:23, Serge Semin > > > wrote: > > > > > > > > In accordance with

Re: [PATCH 11/20] dt-bindings: usb: dwc3: Add synopsys,dwc3 compatible string

2020-10-14 Thread Serge Semin
On Wed, Oct 14, 2020 at 10:18:18PM +0200, Krzysztof Kozlowski wrote: > On Wed, Oct 14, 2020 at 01:13:53PM +0300, Serge Semin wrote: > > The DWC USB3 driver and some DTS files like Exynos 5250, Keystone k2e, etc > > expects the DWC USB3 DT node to have the compatible string with the > > "synopsys"

Re: [PATCH 20/20] arch: dts: Fix DWC USB3 DT nodes name

2020-10-14 Thread Serge Semin
On Wed, Oct 14, 2020 at 01:35:16PM -0500, Rob Herring wrote: > On Wed, Oct 14, 2020 at 9:37 AM Serge Semin > wrote: > > > > On Wed, Oct 14, 2020 at 05:09:37PM +0300, Felipe Balbi wrote: > > > > > > Hi Serge, > > > > > > Serge Semin writes: > > > > In accordance with the DWC USB3 bindings the

Re: [PATCH 18/20] arch: dts: Fix EHCI/OHCI DT nodes name

2020-10-14 Thread Serge Semin
On Wed, Oct 14, 2020 at 11:41:17AM -0700, Florian Fainelli wrote: > On 10/14/20 11:11 AM, Serge Semin wrote: > > On Wed, Oct 14, 2020 at 11:00:45AM -0700, Florian Fainelli wrote: > >> On 10/14/20 3:14 AM, Serge Semin wrote: > >>> In accordance with the Generic EHCI/OHCI bindings the corresponding

Re: [PATCH 11/20] dt-bindings: usb: dwc3: Add synopsys,dwc3 compatible string

2020-10-14 Thread Krzysztof Kozlowski
On Wed, Oct 14, 2020 at 01:13:53PM +0300, Serge Semin wrote: > The DWC USB3 driver and some DTS files like Exynos 5250, Keystone k2e, etc > expects the DWC USB3 DT node to have the compatible string with the > "synopsys" vendor prefix. Let's add the corresponding compatible string to > the

Re: [PATCH 20/20] arch: dts: Fix DWC USB3 DT nodes name

2020-10-14 Thread Krzysztof Kozlowski
On Wed, 14 Oct 2020 at 19:16, Serge Semin wrote: > > On Wed, Oct 14, 2020 at 12:33:25PM +0200, Krzysztof Kozlowski wrote: > > On Wed, 14 Oct 2020 at 12:23, Serge Semin > > wrote: > > > > > > In accordance with the DWC USB3 bindings the corresponding node name is > > > suppose to comply with

Re: [PATCH 18/20] arch: dts: Fix EHCI/OHCI DT nodes name

2020-10-14 Thread Alexey Brodkin
Hi Sergey, > arch/arc/boot/dts/axs10x_mb.dtsi | 4 ++-- > arch/arc/boot/dts/hsdk.dts | 4 ++-- > arch/arc/boot/dts/vdk_axs10x_mb.dtsi | 2 +- For ARC boards Acked-by: Alexey Brodkin ___ linux-snps-arc

Re: [PATCH 18/20] arch: dts: Fix EHCI/OHCI DT nodes name

2020-10-14 Thread Paul Cercueil
Le mer. 14 oct. 2020 à 13:14, Serge Semin a écrit : In accordance with the Generic EHCI/OHCI bindings the corresponding node name is suppose to comply with the Generic USB HCD DT schema, which requires the USB nodes to have the name acceptable by the regexp: "^usb(@.*)?" . Let's fix the

Re: [PATCH 18/20] arch: dts: Fix EHCI/OHCI DT nodes name

2020-10-14 Thread Florian Fainelli
On 10/14/20 11:11 AM, Serge Semin wrote: > On Wed, Oct 14, 2020 at 11:00:45AM -0700, Florian Fainelli wrote: >> On 10/14/20 3:14 AM, Serge Semin wrote: >>> In accordance with the Generic EHCI/OHCI bindings the corresponding node >>> name is suppose to comply with the Generic USB HCD DT schema,

Re: [PATCH 20/20] arch: dts: Fix DWC USB3 DT nodes name

2020-10-14 Thread Rob Herring
On Wed, Oct 14, 2020 at 9:37 AM Serge Semin wrote: > > On Wed, Oct 14, 2020 at 05:09:37PM +0300, Felipe Balbi wrote: > > > > Hi Serge, > > > > Serge Semin writes: > > > In accordance with the DWC USB3 bindings the corresponding node name is > > > suppose to comply with Generic USB HCD DT schema,

Re: [PATCH 18/20] arch: dts: Fix EHCI/OHCI DT nodes name

2020-10-14 Thread Serge Semin
On Wed, Oct 14, 2020 at 11:00:45AM -0700, Florian Fainelli wrote: > On 10/14/20 3:14 AM, Serge Semin wrote: > > In accordance with the Generic EHCI/OHCI bindings the corresponding node > > name is suppose to comply with the Generic USB HCD DT schema, which > > requires the USB nodes to have the

Re: [PATCH 18/20] arch: dts: Fix EHCI/OHCI DT nodes name

2020-10-14 Thread Florian Fainelli
On 10/14/20 3:14 AM, Serge Semin wrote: > In accordance with the Generic EHCI/OHCI bindings the corresponding node > name is suppose to comply with the Generic USB HCD DT schema, which > requires the USB nodes to have the name acceptable by the regexp: > "^usb(@.*)?" . Let's fix the DTS files,

Re: [PATCH 00/20] dt-bindings: usb: Add generic USB HCD, xHCI, DWC USB3 DT schema

2020-10-14 Thread Serge Semin
Ah, forgot to mark the series as v2. Sorry about that. The next one will be v3 then... -Sergey On Wed, Oct 14, 2020 at 01:13:42PM +0300, Serge Semin wrote: > We've performed some work on the Generic USB HCD, xHCI and DWC USB3 DT > bindings in the framework of the Baikal-T1 SoC support

Re: [PATCH 09/20] dt-bindings: usb: Convert DWC USB3 bindings to DT schema

2020-10-14 Thread Serge Semin
On Wed, Oct 14, 2020 at 08:32:19AM -0500, Rob Herring wrote: > On Wed, 14 Oct 2020 13:13:51 +0300, Serge Semin wrote: > > DWC USB3 DT node is supposed to be compliant with the Generic xHCI > > Controller schema, but with additional vendor-specific properties, the > > controller-specific reference

Re: [PATCH 04/20] dt-bindings: usb: usb-hcd: Add "tpl-support" property

2020-10-14 Thread Serge Semin
On Wed, Oct 14, 2020 at 08:27:56AM -0500, Rob Herring wrote: > On Wed, 14 Oct 2020 13:13:46 +0300, Serge Semin wrote: > > The host controller device might be designed to work for the particular > > products or applications. In that case its DT node is supposed to be > > equipped with the

Re: [PATCH 20/20] arch: dts: Fix DWC USB3 DT nodes name

2020-10-14 Thread Serge Semin
On Wed, Oct 14, 2020 at 12:33:25PM +0200, Krzysztof Kozlowski wrote: > On Wed, 14 Oct 2020 at 12:23, Serge Semin > wrote: > > > > In accordance with the DWC USB3 bindings the corresponding node name is > > suppose to comply with Generic USB HCD DT schema, which requires the USB > > nodes to have

Re: [PATCH 20/20] arch: dts: Fix DWC USB3 DT nodes name

2020-10-14 Thread Serge Semin
On Wed, Oct 14, 2020 at 05:09:37PM +0300, Felipe Balbi wrote: > > Hi Serge, > > Serge Semin writes: > > In accordance with the DWC USB3 bindings the corresponding node name is > > suppose to comply with Generic USB HCD DT schema, which requires the USB > > DWC3 is not a simple HDC, though.

Re: [PATCH 20/20] arch: dts: Fix DWC USB3 DT nodes name

2020-10-14 Thread Felipe Balbi
Hi Serge, Serge Semin writes: > In accordance with the DWC USB3 bindings the corresponding node name is > suppose to comply with Generic USB HCD DT schema, which requires the USB DWC3 is not a simple HDC, though. > nodes to have the name acceptable by the regexp: "^usb(@.*)?" . But a lot > of

Re: [PATCH 09/20] dt-bindings: usb: Convert DWC USB3 bindings to DT schema

2020-10-14 Thread Rob Herring
On Wed, 14 Oct 2020 13:13:51 +0300, Serge Semin wrote: > DWC USB3 DT node is supposed to be compliant with the Generic xHCI > Controller schema, but with additional vendor-specific properties, the > controller-specific reference clocks and PHYs. So let's convert the > currently available legacy

Re: [PATCH 04/20] dt-bindings: usb: usb-hcd: Add "tpl-support" property

2020-10-14 Thread Rob Herring
On Wed, 14 Oct 2020 13:13:46 +0300, Serge Semin wrote: > The host controller device might be designed to work for the particular > products or applications. In that case its DT node is supposed to be > equipped with the tpl-support property. > > Signed-off-by: Serge Semin > > --- > > Changelog

Re: [PATCH 20/20] arch: dts: Fix DWC USB3 DT nodes name

2020-10-14 Thread Krzysztof Kozlowski
On Wed, 14 Oct 2020 at 12:23, Serge Semin wrote: > > In accordance with the DWC USB3 bindings the corresponding node name is > suppose to comply with Generic USB HCD DT schema, which requires the USB > nodes to have the name acceptable by the regexp: "^usb(@.*)?" . But a lot > of the DWC

[PATCH 18/20] arch: dts: Fix EHCI/OHCI DT nodes name

2020-10-14 Thread Serge Semin
In accordance with the Generic EHCI/OHCI bindings the corresponding node name is suppose to comply with the Generic USB HCD DT schema, which requires the USB nodes to have the name acceptable by the regexp: "^usb(@.*)?" . Let's fix the DTS files, which have the nodes defined with incompatible

[PATCH 15/20] dt-bindings: usb: meson-g12a-usb: Validate DWC2/DWC3 sub-nodes

2020-10-14 Thread Serge Semin
Amlogic G12A USB DT sub-nodes are supposed to be compatible with the generic DWC USB2 and USB3 devices. Since now we've got DT schemas for both of the later IP cores let's make sure that the Amlogic G12A USB DT nodes are fully evaluated including the DWC sub-nodes. Signed-off-by: Serge Semin

[PATCH 14/20] dt-bindings: usb: meson-g12a-usb: Fix FL-adj property value

2020-10-14 Thread Serge Semin
An empty snps,quirk-frame-length-adjustment won't cause any change performed by the driver. Moreover the DT schema validation will fail, since it expects the property being assigned with some value. So set fix the example by setting a valid FL-adj value in accordance with Neil Armstrong comment.

[PATCH 20/20] arch: dts: Fix DWC USB3 DT nodes name

2020-10-14 Thread Serge Semin
In accordance with the DWC USB3 bindings the corresponding node name is suppose to comply with Generic USB HCD DT schema, which requires the USB nodes to have the name acceptable by the regexp: "^usb(@.*)?" . But a lot of the DWC USB3-compatible nodes defined in the ARM/ARM64 DTS files have name

[PATCH 19/20] arch: dts: Fix xHCI DT nodes name

2020-10-14 Thread Serge Semin
In accordance with the Generic xHCI bindings the corresponding node name is suppose to comply with the Generic USB HCD DT schema, which requires the USB nodes to have the name acceptable by the regexp: "^usb(@.*)?" . Let's fix the DTS files, which have the xHCI-nodes defined with incompatible

[PATCH 09/20] dt-bindings: usb: Convert DWC USB3 bindings to DT schema

2020-10-14 Thread Serge Semin
DWC USB3 DT node is supposed to be compliant with the Generic xHCI Controller schema, but with additional vendor-specific properties, the controller-specific reference clocks and PHYs. So let's convert the currently available legacy text-based DWC USB3 bindings to the DT schema and make sure the

[PATCH 16/20] dt-bindings: usb: keystone-dwc3: Validate DWC3 sub-node

2020-10-14 Thread Serge Semin
TI Keystone DWC3 compatible DT node is supposed to have a DWC USB3 compatible sub-node to describe a fully functioning USB interface. Since DWC USB3 has now got a DT schema describing its DT node, let's make sure the TI Keystone DWC3 sub-node passes validation against it. Signed-off-by: Serge

[PATCH 17/20] dt-bindings: usb: qcom,dwc3: Validate DWC3 sub-node

2020-10-14 Thread Serge Semin
Qualcomm msm8996/sc7180/sdm845 DWC3 compatible DT nodes are supposed to have a DWC USB3 compatible sub-node to describe a fully functioning USB interface. Let's use the available DWC USB3 DT schema to validate the Qualcomm DWC3 sub-nodes. Note since the generic DWC USB3 DT node is supposed to be

[PATCH 13/20] dt-bindings: usb: dwc3: Add Frame Length Adj restrictions

2020-10-14 Thread Serge Semin
In accordance with the IP core databook the snps,quirk-frame-length-adjustment property can be set within [0, 0x3F]. Let's make sure the DT schema applies a correct restriction on the property. Signed-off-by: Serge Semin --- Documentation/devicetree/bindings/usb/snps,dwc3.yaml | 2 ++ 1 file

[PATCH 06/20] dt-bindings: usb: Convert xHCI bindings to DT schema

2020-10-14 Thread Serge Semin
Currently the DT bindings of Generic xHCI Controllers are described by means of the legacy text file. Since such format is deprecated in favor of the DT schema, let's convert the Generic xHCI Controllers bindings file to the corresponding yaml files. There will be two of them: a DT schema for the

[PATCH 11/20] dt-bindings: usb: dwc3: Add synopsys, dwc3 compatible string

2020-10-14 Thread Serge Semin
The DWC USB3 driver and some DTS files like Exynos 5250, Keystone k2e, etc expects the DWC USB3 DT node to have the compatible string with the "synopsys" vendor prefix. Let's add the corresponding compatible string to the controller DT schema, but mark it as deprecated seeing the Synopsys, Inc. is

[PATCH 12/20] dt-bindings: usb: dwc3: Add Tx De-emphasis restrictions

2020-10-14 Thread Serge Semin
In accordance with the driver comments the PIPE3 de-emphasis can be tuned to be either -6dB, -2.5dB or disabled. Let's add the de-emphasis property restriction so the DT schema would make sure the controller DT node is equipped with correct value. Signed-off-by: Serge Semin --- Changelog v2: -

[PATCH 10/20] dt-bindings: usb: dwc3: Add interrupt-names property support

2020-10-14 Thread Serge Semin
The controller driver supports two types of DWC USB3 devices: with a common interrupt lane and with individual interrupts for each mode. Add support for both these cases to the DWC USB3 DT schema. Signed-off-by: Serge Semin --- Changelog v2: - Grammar fix: "s/both of these cases

[PATCH 08/20] dt-bindings: usb: renesas-xhci: Refer to the usb-xhci.yaml file

2020-10-14 Thread Serge Semin
With minor peculiarities (like uploading some vendor-specific firmware) these are just Generic xHCI controllers fully compatible with its properties. Make sure the Renesas USB xHCI DT nodes are also validated against the Generic xHCI DT schema. Signed-off-by: Serge Semin ---

[PATCH 05/20] dt-bindings: usb: usb-hcd: Add generic "usb-phy" property

2020-10-14 Thread Serge Semin
Even though the Generic PHY framework is the more preferable way of setting the USB PHY up, there are still many dts-files and DT bindings which rely on having the legacy "usb-phy" specified to attach particular USB PHYs to USB cores. Let's have the "usb-phy" property described in the generic USB

[PATCH 00/20] dt-bindings: usb: Add generic USB HCD, xHCI, DWC USB3 DT schema

2020-10-14 Thread Serge Semin
We've performed some work on the Generic USB HCD, xHCI and DWC USB3 DT bindings in the framework of the Baikal-T1 SoC support integration into the kernel. This patchset is a result of that work. First of all we moved the generic USB properties from the legacy text bindings into the USB HCD DT

[PATCH 01/20] dt-bindings: usb: usb-hcd: Convert generic USB properties to DT schema

2020-10-14 Thread Serge Semin
The generic USB HCD properties have been described in the legacy bindings text file: Documentation/devicetree/bindings/usb/generic.txt . Let's convert it' content into the USB HCD DT schema properties so all USB DT nodes would be validated to have them properly utilized. Signed-off-by: Serge

[PATCH 07/20] dt-bindings: usb: xhci: Add Broadcom STB v2 compatible device

2020-10-14 Thread Serge Semin
For some reason the "brcm,xhci-brcm-v2" compatible string has been missing in the original bindings file. Add it to the Generic xHCI Controllers DT schema since the controller driver expects it to be supported. Signed-off-by: Serge Semin ---

[PATCH 02/20] dt-bindings: usb: usb-hcd: Add "otg-rev" property restriction

2020-10-14 Thread Serge Semin
There are only four OTG revisions are currently supported by the kernel: 0x0100, 0x0120, 0x0130, 0x0200. Any another value is considered as invalid. Signed-off-by: Serge Semin --- Documentation/devicetree/bindings/usb/usb-hcd.yaml | 1 + 1 file changed, 1 insertion(+) diff --git

[PATCH 04/20] dt-bindings: usb: usb-hcd: Add "tpl-support" property

2020-10-14 Thread Serge Semin
The host controller device might be designed to work for the particular products or applications. In that case its DT node is supposed to be equipped with the tpl-support property. Signed-off-by: Serge Semin --- Changelog v2: - Grammar fix: "s/it'/its" - Discard '|' from the property

[PATCH 03/20] dt-bindings: usb: usb-hcd: Add "ulpi/serial/hsic" PHY types

2020-10-14 Thread Serge Semin
Aside from the UTMI+ there are also ULPI, Serial and HSIC PHY types that can be specified in the phy_type HCD property. Add them to the enumeration of the acceptable values. Signed-off-by: Serge Semin --- Changelog v2: - Grammar fix: "s/PHY types can be/PHY types that can be" - Drop quotes