Re: [PATCH 15/20] dt-bindings: usb: meson-g12a-usb: Validate DWC2/DWC3 sub-nodes

2020-10-16 Thread Martin Blumenstingl
On Wed, Oct 14, 2020 at 12:14 PM Serge Semin wrote: > > Amlogic G12A USB DT sub-nodes are supposed to be compatible with the > generic DWC USB2 and USB3 devices. Since now we've got DT schemas for > both of the later IP cores let's make sure that the Amlogic G12A USB > DT nodes are fully

Re: [PATCH 14/20] dt-bindings: usb: meson-g12a-usb: Fix FL-adj property value

2020-10-16 Thread Martin Blumenstingl
On Wed, Oct 14, 2020 at 12:14 PM Serge Semin wrote: > > An empty snps,quirk-frame-length-adjustment won't cause any change > performed by the driver. Moreover the DT schema validation will fail, > since it expects the property being assigned with some value. So set > fix the example by setting a

Re: [PATCH 15/20] dt-bindings: usb: meson-g12a-usb: Validate DWC2/DWC3 sub-nodes

2020-10-16 Thread Rob Herring
On Wed, 14 Oct 2020 13:13:57 +0300, Serge Semin wrote: > Amlogic G12A USB DT sub-nodes are supposed to be compatible with the > generic DWC USB2 and USB3 devices. Since now we've got DT schemas for > both of the later IP cores let's make sure that the Amlogic G12A USB > DT nodes are fully

Re: [PATCH 17/20] dt-bindings: usb: qcom, dwc3: Validate DWC3 sub-node

2020-10-16 Thread Rob Herring
On Wed, 14 Oct 2020 13:13:59 +0300, Serge Semin wrote: > Qualcomm msm8996/sc7180/sdm845 DWC3 compatible DT nodes are supposed to > have a DWC USB3 compatible sub-node to describe a fully functioning USB > interface. Let's use the available DWC USB3 DT schema to validate the > Qualcomm DWC3

Re: [PATCH 16/20] dt-bindings: usb: keystone-dwc3: Validate DWC3 sub-node

2020-10-16 Thread Rob Herring
On Wed, 14 Oct 2020 13:13:58 +0300, Serge Semin wrote: > TI Keystone DWC3 compatible DT node is supposed to have a DWC USB3 > compatible sub-node to describe a fully functioning USB interface. > Since DWC USB3 has now got a DT schema describing its DT node, let's make > sure the TI Keystone DWC3

Re: [PATCH 14/20] dt-bindings: usb: meson-g12a-usb: Fix FL-adj property value

2020-10-16 Thread Rob Herring
On Wed, 14 Oct 2020 13:13:56 +0300, Serge Semin wrote: > An empty snps,quirk-frame-length-adjustment won't cause any change > performed by the driver. Moreover the DT schema validation will fail, > since it expects the property being assigned with some value. So set > fix the example by setting a

Re: [PATCH 13/20] dt-bindings: usb: dwc3: Add Frame Length Adj restrictions

2020-10-16 Thread Rob Herring
On Wed, 14 Oct 2020 13:13:55 +0300, Serge Semin wrote: > In accordance with the IP core databook the > snps,quirk-frame-length-adjustment property can be set within [0, 0x3F]. > Let's make sure the DT schema applies a correct restriction on the > property. > > Signed-off-by: Serge Semin > --- >

Re: [PATCH 12/20] dt-bindings: usb: dwc3: Add Tx De-emphasis restrictions

2020-10-16 Thread Rob Herring
On Wed, 14 Oct 2020 13:13:54 +0300, Serge Semin wrote: > In accordance with the driver comments the PIPE3 de-emphasis can be tuned > to be either -6dB, -2.5dB or disabled. Let's add the de-emphasis > property restriction so the DT schema would make sure the controller DT > node is equipped with

Re: [PATCH 11/20] dt-bindings: usb: dwc3: Add synopsys,dwc3 compatible string

2020-10-16 Thread Rob Herring
On Thu, Oct 15, 2020 at 12:35:54AM +0300, Serge Semin wrote: > On Wed, Oct 14, 2020 at 10:18:18PM +0200, Krzysztof Kozlowski wrote: > > On Wed, Oct 14, 2020 at 01:13:53PM +0300, Serge Semin wrote: > > > The DWC USB3 driver and some DTS files like Exynos 5250, Keystone k2e, etc > > > expects the

Re: [PATCH 10/20] dt-bindings: usb: dwc3: Add interrupt-names property support

2020-10-16 Thread Rob Herring
On Wed, 14 Oct 2020 13:13:52 +0300, Serge Semin wrote: > The controller driver supports two types of DWC USB3 devices: with a > common interrupt lane and with individual interrupts for each mode. Add > support for both these cases to the DWC USB3 DT schema. > > Signed-off-by: Serge Semin > >

Re: [PATCH 08/20] dt-bindings: usb: renesas-xhci: Refer to the usb-xhci.yaml file

2020-10-16 Thread Rob Herring
On Wed, 14 Oct 2020 13:13:50 +0300, Serge Semin wrote: > With minor peculiarities (like uploading some vendor-specific firmware) > these are just Generic xHCI controllers fully compatible with its > properties. Make sure the Renesas USB xHCI DT nodes are also validated > against the Generic xHCI

Re: [PATCH 06/20] dt-bindings: usb: Convert xHCI bindings to DT schema

2020-10-16 Thread Rob Herring
On Wed, 14 Oct 2020 13:13:48 +0300, Serge Semin wrote: > Currently the DT bindings of Generic xHCI Controllers are described by means > of the legacy text file. Since such format is deprecated in favor of the > DT schema, let's convert the Generic xHCI Controllers bindings file to the >

Re: [PATCH 07/20] dt-bindings: usb: xhci: Add Broadcom STB v2 compatible device

2020-10-16 Thread Rob Herring
On Wed, 14 Oct 2020 13:13:49 +0300, Serge Semin wrote: > For some reason the "brcm,xhci-brcm-v2" compatible string has been missing > in the original bindings file. Add it to the Generic xHCI Controllers DT > schema since the controller driver expects it to be supported. > > Signed-off-by: Serge

Re: [PATCH 04/20] dt-bindings: usb: usb-hcd: Add "tpl-support" property

2020-10-16 Thread Rob Herring
On Wed, 14 Oct 2020 13:13:46 +0300, Serge Semin wrote: > The host controller device might be designed to work for the particular > products or applications. In that case its DT node is supposed to be > equipped with the tpl-support property. > > Signed-off-by: Serge Semin > > --- > > Changelog

Re: [PATCH 05/20] dt-bindings: usb: usb-hcd: Add generic "usb-phy" property

2020-10-16 Thread Rob Herring
On Wed, 14 Oct 2020 13:13:47 +0300, Serge Semin wrote: > Even though the Generic PHY framework is the more preferable way of > setting the USB PHY up, there are still many dts-files and DT bindings > which rely on having the legacy "usb-phy" specified to attach particular > USB PHYs to USB cores.

Re: [PATCH 03/20] dt-bindings: usb: usb-hcd: Add "ulpi/serial/hsic" PHY types

2020-10-16 Thread Rob Herring
On Wed, 14 Oct 2020 13:13:45 +0300, Serge Semin wrote: > Aside from the UTMI+ there are also ULPI, Serial and HSIC PHY types > that can be specified in the phy_type HCD property. Add them to the > enumeration of the acceptable values. > > Signed-off-by: Serge Semin > > --- > > Changelog v2: >

Re: [PATCH 02/20] dt-bindings: usb: usb-hcd: Add "otg-rev" property restriction

2020-10-16 Thread Rob Herring
On Wed, 14 Oct 2020 13:13:44 +0300, Serge Semin wrote: > There are only four OTG revisions are currently supported by the kernel: > 0x0100, 0x0120, 0x0130, 0x0200. Any another value is considered as > invalid. > > Signed-off-by: Serge Semin > --- >

Re: [PATCH 01/20] dt-bindings: usb: usb-hcd: Convert generic USB properties to DT schema

2020-10-16 Thread Rob Herring
On Wed, 14 Oct 2020 13:13:43 +0300, Serge Semin wrote: > The generic USB HCD properties have been described in the legacy bindings > text file: Documentation/devicetree/bindings/usb/generic.txt . Let's > convert it' content into the USB HCD DT schema properties so all USB DT > nodes would be

Re: [PATCH 04/20] dt-bindings: usb: usb-hcd: Add "tpl-support" property

2020-10-16 Thread Rob Herring
On Wed, Oct 14, 2020 at 08:27:10PM +0300, Serge Semin wrote: > On Wed, Oct 14, 2020 at 08:27:56AM -0500, Rob Herring wrote: > > On Wed, 14 Oct 2020 13:13:46 +0300, Serge Semin wrote: > > > The host controller device might be designed to work for the particular > > > products or applications. In

Re: [PATCH 18/20] arch: dts: Fix EHCI/OHCI DT nodes name

2020-10-16 Thread Serge Semin
Hello Alexandre, On Fri, Oct 16, 2020 at 09:08:23AM +0200, Alexandre Torgue wrote: > Hi Serge, > > On 10/14/20 12:14 PM, Serge Semin wrote: > > In accordance with the Generic EHCI/OHCI bindings the corresponding node > > name is suppose to comply with the Generic USB HCD DT schema, which > >

Re: [PATCH 18/20] arch: dts: Fix EHCI/OHCI DT nodes name

2020-10-16 Thread Alexandre Torgue
Hi Serge, On 10/14/20 12:14 PM, Serge Semin wrote: In accordance with the Generic EHCI/OHCI bindings the corresponding node name is suppose to comply with the Generic USB HCD DT schema, which requires the USB nodes to have the name acceptable by the regexp: "^usb(@.*)?" . Let's fix the DTS