Re: [PATCH v3 1/2] scripts: Add "|" operator support to glibcpp's parsing

2022-11-27 Thread Florian Weimer
https://sourceware.org/pipermail/libc-alpha/2022-November/143503.html > > [2] > tst-glibcelf, tst-relro-ldso, and tst-relro-libc > > Signed-off-by: Shahab Vahedi This okay and can go in separately, thanks. Reviewed-by: Florian Weimer Florian ___

Re: [PATCH] support: user more portable atomic wrappers

2020-09-10 Thread Florian Weimer
* Vineet Gupta: > I agree that gcc atomics should be baseline. I would still propose to > carry this patch as it makes code less verbose if nothing else and the > wrappers are part of glibc already. The advantage of the GCC built-ins is that they have easy-to-find documentation. Our wrapper macr

Re: [PATCH] support: user more portable atomic wrappers

2020-09-09 Thread Florian Weimer
* Vineet Gupta via Libc-alpha: > This came up in a nascent arc64 port, lacking gcc atomics for now Can you please change the GCC port to provide atomics instead? It does not make sense to maintain those atomics in many projects separately. Thanks, Florian -- Red Hat GmbH, https://de.redhat.com

Re: [PATCH v2] elf: Change TLS static surplus default back to 1664

2020-07-20 Thread Florian Weimer
* Vineet Gupta via Libc-alpha: > Hi Florian, > > On 7/17/20 4:41 AM, Florian Weimer via Libc-alpha wrote: >> Make the computation in elf/dl-tls.c more transparent, and add >> an explicit test for the historic value. >> >> --- >> elf/Makefile |

Re: [PATCH] Fix tst-libc_dlvsym{, -static} on ARC: don't check _sys_{err, sig}list

2020-07-20 Thread Florian Weimer
* Vineet Gupta via Libc-alpha: > diff --git a/elf/tst-libc_dlvsym.h b/elf/tst-libc_dlvsym.h > index 6b132dd7c3e4..7eda47207824 100644 > --- a/elf/tst-libc_dlvsym.h > +++ b/elf/tst-libc_dlvsym.h > @@ -117,8 +117,6 @@ compare_vsyms (void) > obtain an explicit handle for libc.so. */ >void

Re: ARC testsuite regressions (was Re: [PATCH v7.2 07/13] ARC: Linux Syscall Interface)

2020-07-10 Thread Florian Weimer
* Vineet Gupta: > On 7/10/20 10:02 AM, Florian Weimer via Libc-alpha wrote: >> * Vineet Gupta via Libc-alpha: >> >>> From scratch meaning glibc alone or the whole toolchain. I used >>> buildroot and glibc-dirclean to nuke entire glibc but gcc was not >>&

Re: ARC testsuite regressions (was Re: [PATCH v7.2 07/13] ARC: Linux Syscall Interface)

2020-07-10 Thread Florian Weimer
* Alistair Francis: > On Fri, Jul 10, 2020 at 8:55 AM Vineet Gupta via Libc-alpha > wrote: >> >> On 7/10/20 2:28 AM, Florian Weimer via Libc-alpha wrote: >> > * Alistair Francis via Libc-alpha: >> > >> >> On Thu, Jul 9, 2020 at 2:36 PM Vineet Gupta

Re: ARC testsuite regressions (was Re: [PATCH v7.2 07/13] ARC: Linux Syscall Interface)

2020-07-10 Thread Florian Weimer
* Vineet Gupta via Libc-alpha: > From scratch meaning glibc alone or the whole toolchain. I used > buildroot and glibc-dirclean to nuke entire glibc but gcc was not > rebuilt. I can try that too. No, rebuilding glibc from scratch should be fine. > Some of the failed tests have prints about stati

Re: ARC testsuite regressions (was Re: [PATCH v7.2 07/13] ARC: Linux Syscall Interface)

2020-07-10 Thread Florian Weimer
* Alistair Francis via Libc-alpha: > On Thu, Jul 9, 2020 at 2:36 PM Vineet Gupta via Libc-alpha > wrote: >> >> On 7/9/20 2:13 PM, Vineet Gupta via Libc-alpha wrote: >> >> Rebased ARC port on master and fired a build-many-glibcs now >> >> (expect some >> >> abilist updates). Will do a full tests

Re: [PATCH 3/5] iee754: prvoide gcc builtins based generic fma functions

2020-06-01 Thread Florian Weimer
The commit subject contains a typo (“prvoide”). ___ linux-snps-arc mailing list linux-snps-arc@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-snps-arc

Re: [PATCH 2/5] iee754: prvoide gcc builtins based generic sqrt functions

2020-06-01 Thread Florian Weimer
There's a typo in commit subject: “prvoide”. ___ linux-snps-arc mailing list linux-snps-arc@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-snps-arc

Re: [PATCH v3] Make any 32-bit time based syscalls unavailable for TIMESIZE==64

2020-04-18 Thread Florian Weimer
* Vineet Gupta via Libc-alpha: > On 4/13/20 2:12 PM, Vineet Gupta via Libc-alpha wrote: >> On 4/6/20 11:54 AM, Vineet Gupta wrote: >>> On 3/31/20 2:47 PM, Vineet Gupta via Libc-alpha wrote: From: Vineet Gupta via Libc-alpha An older asm-generic syscall ABI may have kernel provide 3

Re: [PATCH v5 11/14] ARC: Update syscall-names.list for ARC specific syscalls

2020-04-18 Thread Florian Weimer
* Vineet Gupta via Libc-alpha: > On 4/17/20 4:05 PM, Joseph Myers wrote: >> This patch is OK. > > So when the rest of port is ready, this will be part of main commit ? I think this can go in today. ___ linux-snps-arc mailing list linux-snps-arc@lists.i

Re: __syscall_error (was Re: [PATCH v4 13/15] ARC: Build Infrastructure)

2020-04-02 Thread Florian Weimer
* Joseph Myers: > What if you move it to GLIBC_PRIVATE? My concern isn't that it's exported > from the shared library, it's that it's exported at a public version. I think it's preferable to duplicate __syscall_error in each shared object that needs it. It avoids potential strange loops if the

Re: [PATCH] provide y2038 safe socket constants

2020-03-31 Thread Florian Weimer
* Vineet Gupta: > On 3/31/20 12:34 PM, Florian Weimer wrote: >> What about the parallel changes to the sysdeps overrides? I would> expect >> changes for hppa, mips, powerpc. (Not sure about the alpha >> situation.) > > This patch fixes the existing/future asm-ge

Re: [PATCH] provide y2038 safe socket constants

2020-03-31 Thread Florian Weimer
* Vineet Gupta via Libc-alpha: > These will be used by upcoming RV32 and ARC ports and any future ports > > Signed-off-by: Vineet Gupta > --- > sysdeps/unix/sysv/linux/bits/socket-constants.h | 14 -- > 1 file changed, 12 insertions(+), 2 deletions(-) > > diff --git a/sysdeps/unix/sy

Re: [PATCH v3 12/17] ARC: ABI lists

2020-03-09 Thread Florian Weimer
* Vineet Gupta: > On 3/7/20 7:20 AM, Florian Weimer wrote: >> * Vineet Gupta: >> >>> +GLIBC_2.32 sysctl F >> >> This looks like a mistake, given that ARC doesn't even have the sysctl >> system call. >> >> I think the current way of su

Re: [PATCH v3 12/17] ARC: ABI lists

2020-03-07 Thread Florian Weimer
* Vineet Gupta: > +GLIBC_2.32 sysctl F This looks like a mistake, given that ARC doesn't even have the sysctl system call. I think the current way of suppressing that involves creating an empty sysctl.mk file, as in sysdeps/unix/sysv/linux/x86_64/x32/sysctl.mk. (Unfortunately, the ports added af

Re: ELF_INITFINI for ARC (was Re: [PATCH] Introduce and ELF_INITFINI for all architectures)

2020-02-26 Thread Florian Weimer
* Vineet Gupta: > It seems that commit also removed init_array from > sysdeps/{riscv,csky}/Implies - so newer arches. I suppose I need to do > that for ARC as well - but could you please explain (or point to > documentation) which explains how this the Implies stuff works. You are very lucky. Th

Re: [PATCH] Force 64-bit time based syscalls for TIMESIZE==64 on 32-bit arches

2020-02-25 Thread Florian Weimer
* Vineet Gupta: > +/* Override syscalls for asm-generic ABIs with 64-bit time. */ > +#if __WORDSIZE == 32 && __TIMESIZE == 64 > + > +# undef __NR_futex > +# define __NR_futex __NR_futex_time64 > + > +# undef __NR_rt_sigtimedwait > +# define __NR_rt_sigtimedwait __NR_rt_sigtimedwait_time64 I'm no

Re: [PATCH] asm-generic ABI: Allow statx syscall despite fstatat64, fstat64

2020-02-24 Thread Florian Weimer
* Vineet Gupta: > On 2/24/20 11:13 AM, Florian Weimer wrote: >> * Vineet Gupta: >> >>> On 2/24/20 10:39 AM, Florian Weimer wrote: >>>>> +# undef STAT64_IS_NOT_KERNEL_STAT64 >>>> Sorry, I think that going forward, we prefer that such ma

Re: [PATCH] asm-generic ABI: Allow statx syscall despite fstatat64, fstat64

2020-02-24 Thread Florian Weimer
* Vineet Gupta: > On 2/24/20 10:39 AM, Florian Weimer wrote: >>> +# undef STAT64_IS_NOT_KERNEL_STAT64 >> >> Sorry, I think that going forward, we prefer that such macros are always >> defined, with values 0 or 1 as appropriate. > > And that means we also need

Re: [PATCH] asm-generic ABI: Allow statx syscall despite fstatat64, fstat64

2020-02-24 Thread Florian Weimer
* Vineet Gupta: > +/* Ports define to 1 when glibc struct stat64 is not compatible with > + kernel stat64. This forces use of statx syscall (and explicit > interworking) > + even when fstat64 syscall is available. For asm-generic ABI this happened > + with switch to 64-bit time_t. */ > + >

Re: [uclibc-ng-devel] stdio fudging errno ?

2019-12-14 Thread Florian Weimer
* Vineet Gupta: > Here's a simple test case which shows the problem: > > #define _GNU_SOURCE > #include > #include > #include > > void main(void) > { > const char *this_func = "finite"; > char *test_name; > > errno =

Re: [PATCH] posix/tst-getaddrinfo4: Consider EAI_NODATA as an expected result

2019-04-24 Thread Florian Weimer
* Alexey Brodkin: > Hi Florian, > >> -Original Message----- >> From: Florian Weimer >> Sent: Thursday, April 18, 2019 3:08 PM >> To: Alexey Brodkin >> Cc: libc-al...@sourceware.org; linux-snps-arc@lists.infradead.org >> Subject: Re: [PATCH] posix/t

Re: [PATCH] posix/tst-getaddrinfo4: Consider EAI_NODATA as an expected result

2019-04-18 Thread Florian Weimer
* Alexey Brodkin: > Some proxy DNS servers might not resolve IPv6 names to addresses. > Instead they reply with NOERROR while passing no real data. > That combination of NOERROR and EAI_NODATA happen because the DNS > server has a recored for requested name (example.net in our case) > but that rec

Re: [PATCH] testsuite fix: timezone: failing due to permissions in cross testing

2019-01-09 Thread Florian Weimer
* Joseph Myers: > On Tue, 18 Dec 2018, Florian Weimer wrote: > >> There are also some xtests that require root privileges, such as >> nptl/tst-setuid1. Building and testing as root is supported (but > > That looks like it ought to become a test using user namespaces

Re: ARC vs. generic sigaction (was Re: [PATCH 08/21] ARC: Linux Syscall Interface)

2019-01-03 Thread Florian Weimer
* Vineet Gupta: > On 12/20/18 4:40 AM, Florian Weimer wrote: >> * Adhemerval Zanella: >> >>> The only advantage of using a larger sigset_t from glibc standpoint is if >>> kernel ever change it maximum number of supported signals it would not be >>> a

Re: ARC vs. generic sigaction (was Re: [PATCH 08/21] ARC: Linux Syscall Interface)

2018-12-20 Thread Florian Weimer
* Adhemerval Zanella: > The only advantage of using a larger sigset_t from glibc standpoint is if > kernel ever change it maximum number of supported signals it would not be > a ABI change (it would be if glibc provided sigset_t need to be extended). It's not just the kernel. We might want to re

Re: [PATCH 12/21] ARC: Update syscall-names.list for ARC specific syscalls

2018-12-19 Thread Florian Weimer
* Vineet Gupta: > On 12/18/18 1:26 PM, Florian Weimer wrote: >> This should come in with a sync with a released upstream kernel. Will >> the port be in Linux 4.20? > > linux port was upstreamed in 2013 in v3.9 Ah, right, we add system calls to the lists only for our po

Re: [PATCH 14/21] ARC: Enable __start as entry point vs. canonical _start

2018-12-18 Thread Florian Weimer
* Vineet Gupta: > ARC linker scripts have defined __start as entry point so to not break > ABI for uClibc et al we allow __start for glibc as well I think this change and the test suite fixes should be folded into the initial addition of these files. Or is there a reason for not doing this? Tha

Re: [PATCH 12/21] ARC: Update syscall-names.list for ARC specific syscalls

2018-12-18 Thread Florian Weimer
* Vineet Gupta: > diff --git a/sysdeps/unix/sysv/linux/syscall-names.list > b/sysdeps/unix/sysv/linux/syscall-names.list > index f88001c9c38d..62862010600f 100644 > --- a/sysdeps/unix/sysv/linux/syscall-names.list > +++ b/sysdeps/unix/sysv/linux/syscall-names.list > @@ -42,6 +42,9 @@ adjtimex >

Re: [PATCH] testsuite fix: timezone: failing due to permissions in cross testing

2018-12-18 Thread Florian Weimer
* Joseph Myers: > On Mon, 17 Dec 2018, Vineet Gupta wrote: > >> timezone test driver "zic" creates testdata directory wuth umask 755, so >> only root owner/group has write permissions. However the buildroot > > root should not be involved in running tests at all; all tests should run > as a norma

Re: [PATCH] tst-tzset: raise timeout to 10 seconds

2018-07-30 Thread Florian Weimer
On 07/30/2018 06:07 PM, Andreas Schwab wrote: On Jul 30 2018, Joseph Myers wrote: On Mon, 30 Jul 2018, Alexey Brodkin wrote: diff --git a/timezone/tst-tzset.c b/timezone/tst-tzset.c index 27f986b56dab..534f7acdf75f 100644 --- a/timezone/tst-tzset.c +++ b/timezone/tst-tzset.c @@ -25,7 +25,7 @

Re: [RFC 4/6] ARC: Initial port to glibc

2017-06-27 Thread Florian Weimer
On 06/27/2017 01:55 PM, Vineet Gupta wrote: > On 06/27/2017 02:29 PM, Florian Weimer wrote: >> On 06/27/2017 10:00 AM, Vineet Gupta wrote: >>> diff --git a/sysdeps/unix/sysv/linux/arc/shlib-versions >>> b/sysdeps/unix/sysv/linux/arc/shlib-versions >>> new fil

Re: [RFC 0/6] glibc port to ARC architecture

2017-06-27 Thread Florian Weimer
On 06/27/2017 10:00 AM, Vineet Gupta wrote: > This is a Request for comments for glibc port to ARC architecture. > http://www.synopsys.com/IP/ProcessorIP/ARCProcessors/Pages/default.aspx > > The Linux kernel, uClibc, buildroot have been upstream for quite some time. Is it possible to build the ne

Re: [RFC 4/6] ARC: Initial port to glibc

2017-06-27 Thread Florian Weimer
On 06/27/2017 10:00 AM, Vineet Gupta wrote: > diff --git a/sysdeps/unix/sysv/linux/arc/shlib-versions > b/sysdeps/unix/sysv/linux/arc/shlib-versions > new file mode 100644 > index ..c4d5d029812d > --- /dev/null > +++ b/sysdeps/unix/sysv/linux/arc/shlib-versions > @@ -0,0 +1,2 @@ > +DEF