Re: [PATCH] elf: _dl_fixup*: make @reloc_arg 64-bit safe

2021-08-02 Thread Vineet Gupta
Hi Joseph, Adhemerval, Florian On 7/22/21 6:58 AM, Vladimir Isaev via Libc-alpha wrote: > On Jul 22 2021, Andreas Schwab wrote: >> >> On Jul 22 2021, Vladimir Isaev via Libc-alpha wrote: >> >>> diff --git a/elf/dl-runtime.c b/elf/dl-runtime.c >>> index 9d0d941000..6099a44ffb 100644 >>> ---

RE: [PATCH] elf: _dl_fixup*: make @reloc_arg 64-bit safe

2021-07-22 Thread Vladimir Isaev
On Jul 22 2021, Andreas Schwab wrote: > > On Jul 22 2021, Vladimir Isaev via Libc-alpha wrote: > > > diff --git a/elf/dl-runtime.c b/elf/dl-runtime.c > > index 9d0d941000..6099a44ffb 100644 > > --- a/elf/dl-runtime.c > > +++ b/elf/dl-runtime.c > > @@ -56,7 +56,7 @@ _dl_fixup ( > > # ifdef

[PATCH] elf: _dl_fixup*: make @reloc_arg 64-bit safe

2021-07-22 Thread Vladimir Isaev
This came up during arc64 glibc bringup on qemu usermode. On ARC, lazy rezolver calls _dl_fixup() with 2nd argument as PC of the PLT entry beiing fixed up. Thus this needs to be full 64-bit value for arc64, however _dl_fixup() defines @reloc_arg as ElfW(Word) which maps to Elf64_Word -> uint32_t

Re: [PATCH] elf: _dl_fixup*: make @reloc_arg 64-bit safe

2021-07-22 Thread Andreas Schwab
On Jul 22 2021, Vladimir Isaev via Libc-alpha wrote: > diff --git a/elf/dl-runtime.c b/elf/dl-runtime.c > index 9d0d941000..6099a44ffb 100644 > --- a/elf/dl-runtime.c > +++ b/elf/dl-runtime.c > @@ -56,7 +56,7 @@ _dl_fixup ( > # ifdef ELF_MACHINE_RUNTIME_FIXUP_ARGS >