Re: [PATCH] ieee754/dbl-64: Reduce the scope of temporary storage variables

2019-11-11 Thread Joseph Myers
On Mon, 11 Nov 2019, Vineet Gupta wrote: > On 11/11/19 2:33 PM, Joseph Myers wrote: > > On Mon, 11 Nov 2019, Vineet Gupta wrote: > > > >> Functionally it should not result in code gen changes and if at all > >> those would be better since the scope of those temporaries is greatly > >> reduced now

Re: [PATCH] ieee754/dbl-64: Reduce the scope of temporary storage variables

2019-11-11 Thread Vineet Gupta
On 11/11/19 2:33 PM, Joseph Myers wrote: > On Mon, 11 Nov 2019, Vineet Gupta wrote: > >> Functionally it should not result in code gen changes and if at all >> those would be better since the scope of those temporaries is greatly >> reduced now > This feels like the sort of thing where "should not

Re: [PATCH] ieee754/dbl-64: Reduce the scope of temporary storage variables

2019-11-11 Thread Joseph Myers
On Mon, 11 Nov 2019, Vineet Gupta wrote: > Functionally it should not result in code gen changes and if at all > those would be better since the scope of those temporaries is greatly > reduced now This feels like the sort of thing where "should not result in code gen changes" should be tested by

[PATCH] ieee754/dbl-64: Reduce the scope of temporary storage variables

2019-11-11 Thread Vineet Gupta
This came to light when adding hard-flaot support to ARC glibc port without hardware sqrt support causing glibc build to fail: | ../sysdeps/ieee754/dbl-64/e_sqrt.c: In function '__ieee754_sqrt': | ../sysdeps/ieee754/dbl-64/e_sqrt.c:58:54: error: unused variable 'ty' [-Werror=unused-variable] |