Re: [PATCH] provide y2038 safe socket constants

2020-03-31 Thread Joseph Myers
On Tue, 31 Mar 2020, Vineet Gupta via Libc-alpha wrote: > On 3/31/20 1:45 PM, Joseph Myers wrote: > > I'm concerned the present patch is wrong for x32, however; that has > > __TIMESIZE == 64 && __WORDSIZE == 32 but should use the old values; the > > patch should be using __SYSCALL_WORDSIZE when

Re: [PATCH] provide y2038 safe socket constants

2020-03-31 Thread Vineet Gupta
On 3/31/20 1:45 PM, Joseph Myers wrote: > I'm concerned the present patch is wrong for x32, however; that has > __TIMESIZE == 64 && __WORDSIZE == 32 but should use the old values; the > patch should be using __SYSCALL_WORDSIZE when available in place of > __WORDSIZE. Something like below ?

Re: [PATCH] provide y2038 safe socket constants

2020-03-31 Thread Joseph Myers
On Tue, 31 Mar 2020, Florian Weimer wrote: > What about the parallel changes to the sysdeps overrides? I would > expect changes for hppa, mips, powerpc. (Not sure about the alpha > situation.) This fix is only about the case where the *default* ABI in glibc requires these different values.

Re: [PATCH] provide y2038 safe socket constants

2020-03-31 Thread Vineet Gupta
+CC libc-alpha which got lost in the thread. On 3/31/20 1:18 PM, Florian Weimer wrote: > * Vineet Gupta: > >> On 3/31/20 12:34 PM, Florian Weimer wrote: >>> What about the parallel changes to the sysdeps overrides? I would> expect >>> changes for hppa, mips, powerpc. (Not sure about the alpha

Re: [PATCH] provide y2038 safe socket constants

2020-03-31 Thread Florian Weimer
* Vineet Gupta: > On 3/31/20 12:34 PM, Florian Weimer wrote: >> What about the parallel changes to the sysdeps overrides? I would> expect >> changes for hppa, mips, powerpc. (Not sure about the alpha >> situation.) > > This patch fixes the existing/future asm-generic ABI enabled arches > and

Re: [PATCH] provide y2038 safe socket constants

2020-03-31 Thread Vineet Gupta
On 3/31/20 12:34 PM, Florian Weimer wrote: > What about the parallel changes to the sysdeps overrides? I would> expect > changes for hppa, mips, powerpc. (Not sure about the alpha > situation.) This patch fixes the existing/future asm-generic ABI enabled arches and the ones you refer to are

Re: [PATCH] provide y2038 safe socket constants

2020-03-31 Thread Florian Weimer
* Vineet Gupta via Libc-alpha: > These will be used by upcoming RV32 and ARC ports and any future ports > > Signed-off-by: Vineet Gupta > --- > sysdeps/unix/sysv/linux/bits/socket-constants.h | 14 -- > 1 file changed, 12 insertions(+), 2 deletions(-) > > diff --git

Re: [PATCH] provide y2038 safe socket constants

2020-03-31 Thread Vineet Gupta
ping ! On 3/28/20 9:16 PM, Vineet Gupta wrote: > These will be used by upcoming RV32 and ARC ports and any future ports > > Signed-off-by: Vineet Gupta > --- > sysdeps/unix/sysv/linux/bits/socket-constants.h | 14 -- > 1 file changed, 12 insertions(+), 2 deletions(-) > > diff