Re: [PATCH 07/21] ARC: math soft float support

2018-12-20 Thread Joseph Myers
On Thu, 20 Dec 2018, Vineet Gupta wrote: > I'm still ramping up on hard-float, so pardon some of my naivety. It seems the > function calling convention is no different for soft-float vs. hard-float. We > have > a single register file (hard FP instructions inherently use an additional >

Re: [PATCH 07/21] ARC: math soft float support

2018-12-20 Thread Vineet Gupta
On 12/18/18 3:23 PM, Joseph Myers wrote: > On Tue, 18 Dec 2018, Vineet Gupta wrote: > >> +#if defined(__ARC_FPU_SP__) || defined(__ARC_FPU_DP__) > > Missing spaces before '(' (should have such spaces in most cases between > an identifier or keyword and '(' - calls to "defined", calls to

Re: [PATCH 07/21] ARC: math soft float support

2018-12-20 Thread Vineet Gupta
On 12/18/18 4:01 PM, Joseph Myers wrote: > On Tue, 18 Dec 2018, Joseph Myers wrote: > >> On Tue, 18 Dec 2018, Vineet Gupta wrote: >> >>> +#if defined(__ARC_FPU_SP__) || defined(__ARC_FPU_DP__) >> Missing spaces before '(' (should have such spaces in most cases between >> an identifier or keyword

Re: [PATCH 07/21] ARC: math soft float support

2018-12-18 Thread Joseph Myers
On Tue, 18 Dec 2018, Joseph Myers wrote: > On Tue, 18 Dec 2018, Vineet Gupta wrote: > > > +#if defined(__ARC_FPU_SP__) || defined(__ARC_FPU_DP__) > > Missing spaces before '(' (should have such spaces in most cases between > an identifier or keyword and '(' - calls to "defined", calls to

Re: [PATCH 07/21] ARC: math soft float support

2018-12-18 Thread Joseph Myers
On Tue, 18 Dec 2018, Vineet Gupta wrote: > +#if defined(__ARC_FPU_SP__) || defined(__ARC_FPU_DP__) Missing spaces before '(' (should have such spaces in most cases between an identifier or keyword and '(' - calls to "defined", calls to functions, calls to macros, __attribute__, etc. - except

[PATCH 07/21] ARC: math soft float support

2018-12-18 Thread Vineet Gupta
Signed-off-by: Vineet Gupta --- ChangeLog| 6 +++ sysdeps/arc/bits/fenv.h | 92 sysdeps/arc/math_private.h | 6 +++ sysdeps/arc/nofpu/Implies| 1 +