Re: [PATCH v3 4/6] fbdev: Include via

2023-05-03 Thread Arnd Bergmann
On Wed, May 3, 2023, at 10:12, Thomas Zimmermann wrote: > Am 03.05.23 um 09:19 schrieb Javier Martinez Canillas: >> Thomas Zimmermann writes: There are countless examples where the above are not followed, but to my best understanding the above it the preferred way to do it. >>> >>>

Re: [PATCH v3 4/6] fbdev: Include via

2023-05-03 Thread Thomas Zimmermann
Hi Am 03.05.23 um 09:19 schrieb Javier Martinez Canillas: Thomas Zimmermann writes: Hello Thomas, Am 02.05.23 um 21:54 schrieb Sam Ravnborg: On Tue, May 02, 2023 at 03:02:21PM +0200, Thomas Zimmermann wrote: [...] #include /* Why should fb driver call console functions? because con

Re: [PATCH v3 4/6] fbdev: Include via

2023-05-03 Thread Geert Uytterhoeven
On Wed, May 3, 2023 at 9:19 AM Javier Martinez Canillas wrote: > Thomas Zimmermann writes: > > Am 02.05.23 um 21:54 schrieb Sam Ravnborg: > >> On Tue, May 02, 2023 at 03:02:21PM +0200, Thomas Zimmermann wrote: > > [...] > > >>> #include /* Why should fb driver call console > >>> functions? be

Re: [PATCH v3 4/6] fbdev: Include via

2023-05-03 Thread Javier Martinez Canillas
Thomas Zimmermann writes: Hello Thomas, > Am 02.05.23 um 21:54 schrieb Sam Ravnborg: >> On Tue, May 02, 2023 at 03:02:21PM +0200, Thomas Zimmermann wrote: [...] >>> #include /* Why should fb driver call console >>> functions? because console_lock() */ >>> #include >>> >>> +#include

Re: [PATCH v3 4/6] fbdev: Include via

2023-05-03 Thread Thomas Zimmermann
Hi Am 02.05.23 um 21:54 schrieb Sam Ravnborg: Hi Thomas, On Tue, May 02, 2023 at 03:02:21PM +0200, Thomas Zimmermann wrote: Fbdev's main header file, , includes to get declarations for I/O helper functions. From these declarations, it later defines framebuffer I/O helpers, such as fb_{read,wr

Re: [PATCH v3 4/6] fbdev: Include via

2023-05-02 Thread Sam Ravnborg
Hi Thomas, On Tue, May 02, 2023 at 03:02:21PM +0200, Thomas Zimmermann wrote: > Fbdev's main header file, , includes to get > declarations for I/O helper functions. From these declarations, it > later defines framebuffer I/O helpers, such as fb_{read,write}[bwlq]() > or fb_memset(). > > The fram

[PATCH v3 4/6] fbdev: Include via

2023-05-02 Thread Thomas Zimmermann
Fbdev's main header file, , includes to get declarations for I/O helper functions. From these declarations, it later defines framebuffer I/O helpers, such as fb_{read,write}[bwlq]() or fb_memset(). The framebuffer I/O helpers depend on the system architecture and will therefore be moved into . Pr