Re: __syscall_error (was Re: [PATCH v4 13/15] ARC: Build Infrastructure)

2020-04-02 Thread Vineet Gupta
On 4/2/20 1:50 AM, Florian Weimer via Libc-alpha wrote: >> What if you move it to GLIBC_PRIVATE? My concern isn't that it's exported >> from the shared library, it's that it's exported at a public version. > > I think it's preferable to duplicate __syscall_error in each shared > object that

Re: __syscall_error (was Re: [PATCH v4 13/15] ARC: Build Infrastructure)

2020-04-02 Thread Florian Weimer
* Joseph Myers: > What if you move it to GLIBC_PRIVATE? My concern isn't that it's exported > from the shared library, it's that it's exported at a public version. I think it's preferable to duplicate __syscall_error in each shared object that needs it. It avoids potential strange loops if

Re: __syscall_error (was Re: [PATCH v4 13/15] ARC: Build Infrastructure)

2020-04-01 Thread Vineet Gupta
On 4/1/20 10:06 AM, Joseph Myers wrote: > >> If public Version is removed, I get errors like below: > > What if you move it to GLIBC_PRIVATE? My concern isn't that it's exported > from the shared library, it's that it's exported at a public version. > > A public version is only needed if

Re: __syscall_error (was Re: [PATCH v4 13/15] ARC: Build Infrastructure)

2020-04-01 Thread Vineet Gupta
On 4/1/20 12:58 AM, Andreas Schwab wrote: > On Apr 01 2020, Vineet Gupta via Libc-alpha wrote: > >> Looking as RISCV code, they opencode __syscall_error for !IS_IN (libc) which >> I was >> hoping to avoid. > > But that is the right way to do it. The syscall error handler must be > local to the

Re: __syscall_error (was Re: [PATCH v4 13/15] ARC: Build Infrastructure)

2020-04-01 Thread Joseph Myers
On Wed, 1 Apr 2020, Vineet Gupta via Libc-alpha wrote: > > If there's an inline function referring to this in an installed header, we > > can consider whether that inline function *should* be referring to it. > > Similarly if there's a reference in crt*.o / lib*_nonshared.a / GCC static > >

Re: __syscall_error (was Re: [PATCH v4 13/15] ARC: Build Infrastructure)

2020-04-01 Thread Andreas Schwab
On Apr 01 2020, Vineet Gupta via Libc-alpha wrote: > Looking as RISCV code, they opencode __syscall_error for !IS_IN (libc) which > I was > hoping to avoid. But that is the right way to do it. The syscall error handler must be local to the library, it cannot afford to go through the PLT to

__syscall_error (was Re: [PATCH v4 13/15] ARC: Build Infrastructure)

2020-03-31 Thread Vineet Gupta
On 3/31/20 3:48 PM, Joseph Myers wrote: > On Tue, 31 Mar 2020, Vineet Gupta via Libc-alpha wrote: > >> On 3/27/20 11:42 PM, Vineet Gupta via Libc-alpha wrote: > +++ b/sysdeps/arc/Versions > @@ -0,0 +1,6 @@ > +libc { > + GLIBC_2.32 { > +__syscall_error; Why does

Re: [PATCH v4 13/15] ARC: Build Infrastructure

2020-03-31 Thread Joseph Myers
On Tue, 31 Mar 2020, Vineet Gupta via Libc-alpha wrote: > On 3/27/20 11:42 PM, Vineet Gupta via Libc-alpha wrote: > >>> +++ b/sysdeps/arc/Versions > >>> @@ -0,0 +1,6 @@ > >>> +libc { > >>> + GLIBC_2.32 { > >>> +__syscall_error; > >> > >> Why does __syscall_error need a public symbol version?

Re: [PATCH v4 13/15] ARC: Build Infrastructure

2020-03-31 Thread Vineet Gupta
On 3/27/20 11:42 PM, Vineet Gupta via Libc-alpha wrote: >>> +++ b/sysdeps/arc/Versions >>> @@ -0,0 +1,6 @@ >>> +libc { >>> + GLIBC_2.32 { >>> +__syscall_error; >> >> Why does __syscall_error need a public symbol version? If it's used by a >> library other than libc, that means it needs to

Re: [PATCH v4 13/15] ARC: Build Infrastructure

2020-03-28 Thread Vineet Gupta
On 3/27/20 3:47 PM, Joseph Myers wrote: > On Thu, 12 Mar 2020, Vineet Gupta via Libc-alpha wrote: > >> +ifeq ($(subdir),debug) >> +CFLAGS-backtrace.c += -funwind-tables >> +endif > > debug/Makefile already has > > CFLAGS-backtrace.c += -fno-omit-frame-pointer -funwind-tables > > so you

Re: [PATCH v4 13/15] ARC: Build Infrastructure

2020-03-27 Thread Joseph Myers
On Thu, 12 Mar 2020, Vineet Gupta via Libc-alpha wrote: > +ifeq ($(subdir),debug) > +CFLAGS-backtrace.c += -funwind-tables > +endif debug/Makefile already has CFLAGS-backtrace.c += -fno-omit-frame-pointer -funwind-tables so you shouldn't need this. > +++ b/sysdeps/arc/Versions > @@ -0,0 +1,6

[PATCH v4 13/15] ARC: Build Infrastructure

2020-03-12 Thread Vineet Gupta
Signed-off-by: Vineet Gupta --- sysdeps/arc/Implies| 3 +++ sysdeps/arc/Makefile | 25 ++ sysdeps/arc/Versions | 6 ++ sysdeps/arc/configure | 14