Re: [RFC v6 07/23] RISC-V: Use 64-bit time_t and off_t for RV32 and RV64

2020-02-19 Thread Andreas Schwab
On Feb 19 2020, Vineet Gupta wrote: > On 2/18/20 5:03 PM, Alistair Francis wrote: +#define STAT_IS_KERNEL_STAT 1 >>> Isn't this irrelevant: seems to be only used for legacy >>> __NR_stat/__NR_stat64 >>> syscalls based__xstat()/__xstat64(). >> Is it? It seems to be used in a few places,

Re: [PATCH] Remove STATFS_IS_STATFS64 conditional as it is zero in all ports

2020-02-19 Thread Andreas Schwab
I think STATFS_IS_STATFS64 should actually be set to 1 on all 64-bit architectures execpt alpha? Andreas. -- Andreas Schwab, SUSE Labs, sch...@suse.de GPG Key fingerprint = 0196 BAD8 1CE9 1970 F4BE 1748 E4D4 88E3 0EEA B9D7 "And now for something completely different."

[RESEND PATCH v2 9/9] ath5k: Constify ioreadX() iomem argument (as in generic implementation)

2020-02-19 Thread Krzysztof Kozlowski
The ioreadX() helpers have inconsistent interface. On some architectures void *__iomem address argument is a pointer to const, on some not. Implementations of ioreadX() do not modify the memory under the address so they can be converted to a "const" version for const-safety and consistency among

Re: [PATCH 08/15] nios2: Use Linux kABI for syscall return

2020-02-19 Thread Vineet Gupta
On 2/10/20 11:20 AM, Adhemerval Zanella wrote: > It changes the nios INTERNAL_SYSCALL_RAW macro to return a negative > value instead of 'r2' register value on 'err' macro argument. > > The macro INTERNAL_SYSCALL_DECL is no longer required, and the > INTERNAL_SYSCALL_ERROR_P follows the other

Re: [RFC v6 07/23] RISC-V: Use 64-bit time_t and off_t for RV32 and RV64

2020-02-19 Thread Vineet Gupta
On 2/19/20 12:30 AM, Andreas Schwab wrote: > On Feb 19 2020, Vineet Gupta wrote: > >> On 2/18/20 5:03 PM, Alistair Francis wrote: > +#define STAT_IS_KERNEL_STAT 1 Isn't this irrelevant: seems to be only used for legacy __NR_stat/__NR_stat64 syscalls based__xstat()/__xstat64().

[RESEND PATCH v2 1/9] iomap: Constify ioreadX() iomem argument (as in generic implementation)

2020-02-19 Thread Krzysztof Kozlowski
The ioreadX() and ioreadX_rep() helpers have inconsistent interface. On some architectures void *__iomem address argument is a pointer to const, on some not. Implementations of ioreadX() do not modify the memory under the address so they can be converted to a "const" version for const-safety and

[RESEND PATCH v2 0/9] iomap: Constify ioreadX() iomem argument

2020-02-19 Thread Krzysztof Kozlowski
Hi, Changes since v1 https://lore.kernel.org/lkml/1578415992-24054-1-git-send-email-k...@kernel.org/ 1. Constify also ioreadX_rep() and mmio_insX(), 2. Squash lib+alpha+powerpc+parisc+sh into one patch for bisectability, 3. Add acks and reviews, 4. Re-order patches so all

Re: [RFC v6 07/23] RISC-V: Use 64-bit time_t and off_t for RV32 and RV64

2020-02-19 Thread Vineet Gupta
Hi Lukasz, On 2/19/20 3:18 PM, Lukasz Majewski wrote: > Please keep in mind that there are some architectures (like 32 bit > ARM), which are NOT using asm-generic API. Right understand that. > Those archs also require support for 64 bit time. That is why Alistair > put the [sg]etitimer

Re: [RFC v6 07/23] RISC-V: Use 64-bit time_t and off_t for RV32 and RV64

2020-02-19 Thread Joseph Myers
On Thu, 20 Feb 2020, Vineet Gupta wrote: > The first 4 will need more work as sym aliasing like > strong_alias (__xstat64, __xstat) > > will be needed in those ARM files (which in turn use i386). The situation for Arm is fundamentally different from that for ARC. For ARC, you only need a

Re: switching ARC to 64-bit time_t (Re: [RFC v6 07/23] RISC-V: Use 64-bit time_t and off_t for RV32 and RV64)

2020-02-19 Thread Lukasz Majewski
Hi Vineet, > Hi Alistair, Arnd > > On 2/14/20 2:39 PM, Alistair Francis wrote: > > On Tue, Feb 11, 2020 at 5:30 PM Joseph Myers > > wrote: > >> On Tue, 11 Feb 2020, Alistair Francis wrote: > >> > > diff --git a/sysdeps/unix/sysv/linux/riscv/bits/typesizes.h > >

Re: switching ARC to 64-bit time_t (Re: [RFC v6 07/23] RISC-V: Use 64-bit time_t and off_t for RV32 and RV64)

2020-02-19 Thread Lukasz Majewski
Hi Joseph, Vineet, > On Tue, 18 Feb 2020, Vineet Gupta wrote: > > > An the reason this all works on RISCV is that your kernel doesn't > > define __ARCH_WANT_STAT64 -> lacks __NR_statat64 and instead uses > > the statx call which does itemized copy and would work fine when > > copying from

Re: [RFC v6 07/23] RISC-V: Use 64-bit time_t and off_t for RV32 and RV64

2020-02-19 Thread Lukasz Majewski
Hi Vineet, > On 2/19/20 12:30 AM, Andreas Schwab wrote: > > On Feb 19 2020, Vineet Gupta wrote: > > > >> On 2/18/20 5:03 PM, Alistair Francis wrote: > > +#define STAT_IS_KERNEL_STAT 1 > Isn't this irrelevant: seems to be only used for legacy > __NR_stat/__NR_stat64 syscalls

[RESEND PATCH v2 3/9] ntb: intel: Constify ioreadX() iomem argument (as in generic implementation)

2020-02-19 Thread Krzysztof Kozlowski
The ioreadX() helpers have inconsistent interface. On some architectures void *__iomem address argument is a pointer to const, on some not. Implementations of ioreadX() do not modify the memory under the address so they can be converted to a "const" version for const-safety and consistency among

[RESEND PATCH v2 5/9] arc: Constify ioreadX() iomem argument (as in generic implementation)

2020-02-19 Thread Krzysztof Kozlowski
The ioreadX() helpers have inconsistent interface. On some architectures void *__iomem address argument is a pointer to const, on some not. Implementations of ioreadX() do not modify the memory under the address so they can be converted to a "const" version for const-safety and consistency among

[RESEND PATCH v2 7/9] drm/nouveau: Constify ioreadX() iomem argument (as in generic implementation)

2020-02-19 Thread Krzysztof Kozlowski
The ioreadX() helpers have inconsistent interface. On some architectures void *__iomem address argument is a pointer to const, on some not. Implementations of ioreadX() do not modify the memory under the address so they can be converted to a "const" version for const-safety and consistency among

[RESEND PATCH v2 2/9] rtl818x: Constify ioreadX() iomem argument (as in generic implementation)

2020-02-19 Thread Krzysztof Kozlowski
The ioreadX() helpers have inconsistent interface. On some architectures void *__iomem address argument is a pointer to const, on some not. Implementations of ioreadX() do not modify the memory under the address so they can be converted to a "const" version for const-safety and consistency among

[RESEND PATCH v2 4/9] virtio: pci: Constify ioreadX() iomem argument (as in generic implementation)

2020-02-19 Thread Krzysztof Kozlowski
The ioreadX() helpers have inconsistent interface. On some architectures void *__iomem address argument is a pointer to const, on some not. Implementations of ioreadX() do not modify the memory under the address so they can be converted to a "const" version for const-safety and consistency among

[RESEND PATCH v2 8/9] media: fsl-viu: Constify ioreadX() iomem argument (as in generic implementation)

2020-02-19 Thread Krzysztof Kozlowski
The ioreadX() helpers have inconsistent interface. On some architectures void *__iomem address argument is a pointer to const, on some not. Implementations of ioreadX() do not modify the memory under the address so they can be converted to a "const" version for const-safety and consistency among