Re: [PATCH] arc: warn only once if DW2_UNWIND is disabled

[Alexey Brodkin]

Hi Vineet,

On Tue, 2016-06-28 at 10:00 +0530, Vineet Gupta wrote:
> On Thursday 23 June 2016 01:30 PM, Alexey Brodkin wrote:
> > 
> > If CONFIG_ARC_DW2_UNWIND is disabled every time arc_unwind_core()
> > gets called following message gets printed in debug console:
> > ->8---
> > CONFIG_ARC_DW2_UNWIND needs to be enabled
> > ->8---
> > 
> > That message makes sense if user indeed wants to see a backtrace or
> > get nice function call-graphs in perf but what if user disabled
> > unwinder for the purpose? Why pollute his debug console?
> > 
> > So instead we'll warn user about possibly missing feature once and
> > let him decide if that was what he or she really wanted.
> > 
> > Signed-off-by: Alexey Brodkin 
> > Cc: sta...@vger.kernel.org  [3.18+]
>
> Does this really need to be stable backport ?

I think it makes perfect sense for any kernel version because
it saves debug console from being polluted with messages which
most probably have no point (Ok I disabled unwinder in kernel config,
why then spam me with proposals to enable it)?

-Alexey
___
linux-snps-arc mailing list
linux-snps-arc@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-snps-arc

kisskb: OK linus/axs103_smp_defconfig/arcv2 Tue Jun 28, 15:31

[noreply]

OK linus/axs103_smp_defconfig/arcv2 Tue Jun 28, 15:31

http://kisskb.ellerman.id.au/kisskb/buildresult/12729513/

Commit:   Merge branch 'rc-fixes' of 
git://git.kernel.org/pub/scm/linux/kernel/git/mmarek/kbuild
  3992a272a72c7a258236cf035f74396ec4f89941
Compiler: arc-buildroot-linux-uclibc-gcc (Buildroot 2015.08.1) 4.8.4

No errors found in log

Possible warnings (17)
--

kernel/sched/core.c:3226:1: warning: control reaches end of non-void function 
[-Wreturn-type]
arch/arc/include/asm/elf.h:58:29: warning: integer overflow in expression 
[-Woverflow]
fs/ext4/ext4_jbd2.h:420:1: warning: control reaches end of non-void function 
[-Wreturn-type]
fs/ext4/ext4_jbd2.h:420:1: warning: control reaches end of non-void function 
[-Wreturn-type]
fs/ext4/ext4_jbd2.h:420:1: warning: control reaches end of non-void function 
[-Wreturn-type]
fs/ext4/ext4_jbd2.h:420:1: warning: control reaches end of non-void function 
[-Wreturn-type]
fs/ext4/ext4_jbd2.h:420:1: warning: control reaches end of non-void function 
[-Wreturn-type]
fs/ext4/ext4_jbd2.h:420:1: warning: control reaches end of non-void function 
[-Wreturn-type]
fs/ext4/ext4_jbd2.h:420:1: warning: control reaches end of non-void function 
[-Wreturn-type]
fs/ext4/ext4_jbd2.h:420:1: warning: control reaches end of non-void function 
[-Wreturn-type]
fs/ext4/ext4_jbd2.h:420:1: warning: control reaches end of non-void function 
[-Wreturn-type]
lib/cpumask.c:179:1: warning: control reaches end of non-void function 
[-Wreturn-type]
net/core/ethtool.c:299:1: warning: control reaches end of non-void function 
[-Wreturn-type]
include/linux/kernel.h:742:17: warning: comparison of distinct pointer types 
lacks a cast [enabled by default]
block/cfq-iosched.c:3793:1: warning: control reaches end of non-void function 
[-Wreturn-type]
include/linux/sunrpc/svc_xprt.h:176:1: warning: control reaches end of non-void 
function [-Wreturn-type]
net/ipv4/tcp_input.c:4273:49: warning: array subscript is above array bounds 
[-Warray-bounds]


___
linux-snps-arc mailing list
linux-snps-arc@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-snps-arc

Re: [PATCH] arc: warn only once if DW2_UNWIND is disabled

[Vineet Gupta]

On Thursday 23 June 2016 01:30 PM, Alexey Brodkin wrote:
> If CONFIG_ARC_DW2_UNWIND is disabled every time arc_unwind_core()
> gets called following message gets printed in debug console:
> ->8---
> CONFIG_ARC_DW2_UNWIND needs to be enabled
> ->8---
> 
> That message makes sense if user indeed wants to see a backtrace or
> get nice function call-graphs in perf but what if user disabled
> unwinder for the purpose? Why pollute his debug console?
> 
> So instead we'll warn user about possibly missing feature once and
> let him decide if that was what he or she really wanted.
> 
> Signed-off-by: Alexey Brodkin 
> Cc: sta...@vger.kernel.org  [3.18+]

Does this really need to be stable backport ?

> ---
>  arch/arc/kernel/stacktrace.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/arch/arc/kernel/stacktrace.c b/arch/arc/kernel/stacktrace.c
> index e0efff1..b9192a6 100644
> --- a/arch/arc/kernel/stacktrace.c
> +++ b/arch/arc/kernel/stacktrace.c
> @@ -142,7 +142,7 @@ arc_unwind_core(struct task_struct *tsk, struct pt_regs 
> *regs,
>* prelogue is setup (callee regs saved and then fp set and not other
>* way around
>*/
> - pr_warn("CONFIG_ARC_DW2_UNWIND needs to be enabled\n");
> + pr_warn_once("CONFIG_ARC_DW2_UNWIND needs to be enabled\n");
>   return 0;
>  
>  #endif
> 


___
linux-snps-arc mailing list
linux-snps-arc@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-snps-arc

kisskb: OK linus/axs101_defconfig/arcompact Tue Jun 28, 08:07

[noreply]

OK linus/axs101_defconfig/arcompact Tue Jun 28, 08:07

http://kisskb.ellerman.id.au/kisskb/buildresult/12729514/

Commit:   Merge branch 'rc-fixes' of 
git://git.kernel.org/pub/scm/linux/kernel/git/mmarek/kbuild
  3992a272a72c7a258236cf035f74396ec4f89941
Compiler: arc-buildroot-linux-uclibc-gcc (Buildroot 2015.08.1) 4.8.4

No errors found in log

Possible warnings (16)
--

kernel/sched/core.c:3226:1: warning: control reaches end of non-void function 
[-Wreturn-type]
include/linux/kernel.h:742:17: warning: comparison of distinct pointer types 
lacks a cast [enabled by default]
block/cfq-iosched.c:3793:1: warning: control reaches end of non-void function 
[-Wreturn-type]
fs/ext4/ext4_jbd2.h:420:1: warning: control reaches end of non-void function 
[-Wreturn-type]
fs/ext4/ext4_jbd2.h:420:1: warning: control reaches end of non-void function 
[-Wreturn-type]
fs/ext4/ext4_jbd2.h:420:1: warning: control reaches end of non-void function 
[-Wreturn-type]
arch/arc/include/asm/elf.h:58:29: warning: integer overflow in expression 
[-Woverflow]
fs/ext4/ext4_jbd2.h:420:1: warning: control reaches end of non-void function 
[-Wreturn-type]
fs/ext4/ext4_jbd2.h:420:1: warning: control reaches end of non-void function 
[-Wreturn-type]
net/core/ethtool.c:299:1: warning: control reaches end of non-void function 
[-Wreturn-type]
net/ipv4/tcp_input.c:4273:49: warning: array subscript is above array bounds 
[-Warray-bounds]
fs/ext4/ext4_jbd2.h:420:1: warning: control reaches end of non-void function 
[-Wreturn-type]
fs/ext4/ext4_jbd2.h:420:1: warning: control reaches end of non-void function 
[-Wreturn-type]
fs/ext4/ext4_jbd2.h:420:1: warning: control reaches end of non-void function 
[-Wreturn-type]
fs/ext4/ext4_jbd2.h:420:1: warning: control reaches end of non-void function 
[-Wreturn-type]
include/linux/sunrpc/svc_xprt.h:176:1: warning: control reaches end of non-void 
function [-Wreturn-type]


___
linux-snps-arc mailing list
linux-snps-arc@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-snps-arc

kisskb: FAILED linus/axs101_defconfig/arcompact Tue Jun 28, 04:48

[noreply]

FAILED linus/axs101_defconfig/arcompact Tue Jun 28, 04:48

http://kisskb.ellerman.id.au/kisskb/buildresult/12729246/

Commit:   Merge branch 'for-next' of git://git.samba.org/sfrench/cifs-2.6
  fbe601f7a34b395deb85a63ae5cddd0c084c8db1
Compiler: arc-buildroot-linux-uclibc-gcc (Buildroot 2015.08.1) 4.8.4

Possible errors
---

make[1]: *** [outputmakefile] Error 1
scripts/basic/fixdep.c:479:1: fatal error: error writing to /tmp/cc69mqgP.s: No 
space left on device
make[2]: *** [scripts/basic/fixdep] Error 1
make[1]: *** [scripts_basic] Error 2
make: *** [sub-make] Error 2

No warnings found in log.


___
linux-snps-arc mailing list
linux-snps-arc@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-snps-arc

Re: Patches for ARC

[Alexey Brodkin]

Hi Waldemar,

On Mon, 2016-06-13 at 22:38 +0200, Waldemar Brodkorb wrote:
> Hi Alexey,
> Alexey Brodkin wrote,
> 
> > 
> > Hi Waldemar,
> > 
> > Just saw that new change for ARC ("arc: use generic lowlevellock",
> > http://cgit.uclibc-ng.org/cgi/cgit/uclibc-ng.git/commit/?id=1b49dc96d103e0151fee290d55cea55aa12c906d).
> > 
> > Even though this is very nice to see fixes and improvements done by people
> > outside Synopsys IMHO it still makes sense to add SNPS people in the loop so
> > we may review submitted patches.
> You are right, I first thought I need to add you, then I thought you
> are reading the low traffic list anyway. 
> Sorry for the trouble.
>  
> > 
> > So could you please first get an Ack from either Vineet (in Cc) or me before
> > committing stuff for ARC? Alternatively just Cc 
> > linux-snps-arc@lists.infradead.org.
> I will do in the future. Do you thing following patch would be okay
> to commit to make changes to architecture specific parts
> more formal?
>  
> > 
> > Again I'm very happy with uClibc-ng and appreciate a lot all your efforts
> > and to make uClibc-ng more robust let's review stuff together.
> > 
> > Also it was hard for me to find a relevant patch on the mailing list
> > because I was expecting patch to be sent via git "send-email" (which I think
> > should be a standard way for patch submissions in uClibc). Only going 
> > through a relevant
> > thread for ARM I found a message with attached files.
> Is the commit okay or do I need to revert it?

Sorry for late reply.

Yep this commit is fine so no need to do anything here.

-Alexey
___
linux-snps-arc mailing list
linux-snps-arc@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-snps-arc

Re: [PATCH V2 63/63] clocksources: Switch back to the clksrc table

[Carlo Caione]

On 16/06/16 23:27, Daniel Lezcano wrote:
> All the clocksource drivers's init function are now converted to return
> an error code. CLOCKSOURCE_OF_DECLARE is no longer used as well as the
> clksrc-of table.
> 
> Let's convert back the names:
>  - CLOCKSOURCE_OF_DECLARE_RET => CLOCKSOURCE_OF_DECLARE
>  - clksrc-of-ret  => clksrc-of
> 
> Signed-off-by: Daniel Lezcano 
> ---
>  drivers/clocksource/meson6_timer.c|  2 +-

Acked-by: Carlo Caione 

___
linux-snps-arc mailing list
linux-snps-arc@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-snps-arc