Re: [PATCH 00/13] replace print_symbol() with printk()-s

2017-12-11 Thread Joe Perches
On Tue, 2017-12-12 at 11:47 +0900, Sergey Senozhatsky wrote: > On (12/11/17 08:26), Joe Perches wrote: > > On Mon, 2017-12-11 at 21:50 +0900, Sergey Senozhatsky wrote: > > > print_symbol > > Yay. > > Just about exactly 5 years earlier... > >

Re: [PATCH 11/13] irq debug: do not use print_symbol()

2017-12-11 Thread Sergey Senozhatsky
On (12/11/17 12:55), David Laight wrote: > > kernel/irq/debug.h | 8 +++- > > 1 file changed, 3 insertions(+), 5 deletions(-) > > > > diff --git a/kernel/irq/debug.h b/kernel/irq/debug.h > > index 17f05ef8f575..5766e15c1160 100644 > > --- a/kernel/irq/debug.h > > +++ b/kernel/irq/debug.h >

Re: [PATCH 00/13] replace print_symbol() with printk()-s

2017-12-11 Thread Sergey Senozhatsky
On (12/11/17 08:26), Joe Perches wrote: > On Mon, 2017-12-11 at 21:50 +0900, Sergey Senozhatsky wrote: > > print_symbol > > Yay. > > Just about exactly 5 years earlier... > http://lists.infradead.org/pipermail/linux-arm-kernel/2012-December/137121.html indeed :) hopefully it won't take us

Re: [PATCH 08/13] x86: do not use print_symbol()

2017-12-11 Thread Sergey Senozhatsky
On (12/11/17 18:45), Borislav Petkov wrote: > For the mce.c bit above: > > Acked-by: Borislav Petkov thanks. -ss ___ linux-snps-arc mailing list linux-snps-arc@lists.infradead.org

Re: [PATCH 13/13] arc: do not use __print_symbol()

2017-12-11 Thread Sergey Senozhatsky
On (12/11/17 08:28), Vineet Gupta wrote: > On 12/11/2017 04:53 AM, Sergey Senozhatsky wrote: > > __print_symbol() uses extra stack space to sprintf() symbol > > information and then to feed that buffer to printk() > > > >char buffer[KSYM_SYMBOL_LEN]; > > > >sprint_symbol(buffer,

Re: [PATCH 08/13] x86: do not use print_symbol()

2017-12-11 Thread Borislav Petkov
On Mon, Dec 11, 2017 at 09:50:20PM +0900, Sergey Senozhatsky wrote: > print_symbol() uses extra stack space to sprintf() symbol > information and then to feed that buffer to printk() > > char buffer[KSYM_SYMBOL_LEN]; > > sprint_symbol(buffer, address); > printk(fmt, buffer); > > Replace

Re: [PATCH 13/13] arc: do not use __print_symbol()

2017-12-11 Thread Vineet Gupta
On 12/11/2017 04:53 AM, Sergey Senozhatsky wrote: __print_symbol() uses extra stack space to sprintf() symbol information and then to feed that buffer to printk() char buffer[KSYM_SYMBOL_LEN]; sprint_symbol(buffer, address); printk(fmt, buffer); Replace __print_symbol() with a direct

Re: [PATCH 00/13] replace print_symbol() with printk()-s

2017-12-11 Thread Joe Perches
On Mon, 2017-12-11 at 21:50 +0900, Sergey Senozhatsky wrote: > print_symbol Yay. Just about exactly 5 years earlier... http://lists.infradead.org/pipermail/linux-arm-kernel/2012-December/137121.html ___ linux-snps-arc mailing list

[PATCH 08/13] x86: do not use print_symbol()

2017-12-11 Thread Sergey Senozhatsky
print_symbol() uses extra stack space to sprintf() symbol information and then to feed that buffer to printk() char buffer[KSYM_SYMBOL_LEN]; sprint_symbol(buffer, address); printk(fmt, buffer); Replace print_symbol() with a direct printk("%pS") call. Signed-off-by: Sergey Senozhatsky

[PATCH 10/13] sysfs: do not use print_symbol()

2017-12-11 Thread Sergey Senozhatsky
print_symbol() uses extra stack space to sprintf() symbol information and then to feed that buffer to printk() char buffer[KSYM_SYMBOL_LEN]; sprint_symbol(buffer, address); printk(fmt, buffer); Replace print_symbol() with a direct printk("%pS") call. Signed-off-by: Sergey Senozhatsky

[PATCH 12/13] lib: do not use print_symbol()

2017-12-11 Thread Sergey Senozhatsky
print_symbol() uses extra stack space to sprintf() symbol information and then to feed that buffer to printk() char buffer[KSYM_SYMBOL_LEN]; sprint_symbol(buffer, address); printk(fmt, buffer); Replace print_symbol() with a direct printk("%pS") call. Signed-off-by: Sergey Senozhatsky

[PATCH 13/13] arc: do not use __print_symbol()

2017-12-11 Thread Sergey Senozhatsky
__print_symbol() uses extra stack space to sprintf() symbol information and then to feed that buffer to printk() char buffer[KSYM_SYMBOL_LEN]; sprint_symbol(buffer, address); printk(fmt, buffer); Replace __print_symbol() with a direct printk("%pS") call. Signed-off-by: Sergey Senozhatsky

RE: [PATCH 11/13] irq debug: do not use print_symbol()

2017-12-11 Thread David Laight
From: Sergey Senozhatsky > Sent: 11 December 2017 12:50 > print_symbol() uses extra stack space to sprintf() symbol > information and then to feed that buffer to printk() > > char buffer[KSYM_SYMBOL_LEN]; > > sprint_symbol(buffer, address); > printk(fmt, buffer); > > Replace

[PATCH 11/13] irq debug: do not use print_symbol()

2017-12-11 Thread Sergey Senozhatsky
print_symbol() uses extra stack space to sprintf() symbol information and then to feed that buffer to printk() char buffer[KSYM_SYMBOL_LEN]; sprint_symbol(buffer, address); printk(fmt, buffer); Replace print_symbol() with a direct printk("%pS") call. Signed-off-by: Sergey Senozhatsky

[PATCH 09/13] drivers: do not use print_symbol()

2017-12-11 Thread Sergey Senozhatsky
print_symbol() uses extra stack space to sprintf() symbol information and then to feed that buffer to printk() char buffer[KSYM_SYMBOL_LEN]; sprint_symbol(buffer, address); printk(fmt, buffer); Replace print_symbol() with a direct printk("%pS") call. Signed-off-by: Sergey Senozhatsky

[PATCH 07/13] unicore32: do not use print_symbol()

2017-12-11 Thread Sergey Senozhatsky
print_symbol() uses extra stack space to sprintf() symbol information and then to feed that buffer to printk() char buffer[KSYM_SYMBOL_LEN]; sprint_symbol(buffer, address); printk(fmt, buffer); Replace print_symbol() with a direct printk("%pS") call. Signed-off-by: Sergey Senozhatsky

[PATCH 06/13] sh: do not use print_symbol()

2017-12-11 Thread Sergey Senozhatsky
print_symbol() uses extra stack space to sprintf() symbol information and then to feed that buffer to printk() char buffer[KSYM_SYMBOL_LEN]; sprint_symbol(buffer, address); printk(fmt, buffer); Replace print_symbol() with a direct printk("%pS") call. Signed-off-by: Sergey Senozhatsky

[PATCH 03/13] c6x: do not use print_symbol()

2017-12-11 Thread Sergey Senozhatsky
print_symbol() uses extra stack space to sprintf() symbol information and then to feed that buffer to printk() char buffer[KSYM_SYMBOL_LEN]; sprint_symbol(buffer, address); printk(fmt, buffer); Replace print_symbol() with a direct printk("%pS") call. Signed-off-by: Sergey Senozhatsky

[PATCH 04/13] ia64: do not use print_symbol()

2017-12-11 Thread Sergey Senozhatsky
print_symbol() uses extra stack space to sprintf() symbol information and then to feed that buffer to printk() char buffer[KSYM_SYMBOL_LEN]; sprint_symbol(buffer, address); printk(fmt, buffer); Replace print_symbol() with a direct printk("%pS") call. Additionally ia64_do_show_stack() had

[PATCH 02/13] arm64: do not use print_symbol()

2017-12-11 Thread Sergey Senozhatsky
print_symbol() uses extra stack space to sprintf() symbol information and then to feed that buffer to printk() char buffer[KSYM_SYMBOL_LEN]; sprint_symbol(buffer, address); printk(fmt, buffer); Replace print_symbol() with a direct printk("%pS") call. Signed-off-by: Sergey Senozhatsky

[PATCH 01/13] arm: do not use print_symbol()

2017-12-11 Thread Sergey Senozhatsky
print_symbol() uses extra stack space to sprintf() symbol information and then to feed that buffer to printk() char buffer[KSYM_SYMBOL_LEN]; sprint_symbol(buffer, address); printk(fmt, buffer); Replace print_symbol() with a direct printk("%pS") call. Signed-off-by: Sergey Senozhatsky

[PATCH 00/13] replace print_symbol() with printk()-s

2017-12-11 Thread Sergey Senozhatsky
Hello, A rather automatic replacement of print_symbol() with direct printk() calls. print_symbol() uses extra stack buffer (KSYM_SYMBOL_LEN 128 bytes) and, basically, should be identical to printk(%pS). I can't test all of the patches, because I don't own any of those