Re: [PATCH V8] mm/debug: Add tests validating architecture page table helpers

2019-11-06 Thread Anshuman Khandual
On 11/06/2019 11:37 PM, Vineet Gupta wrote: > On 11/5/19 7:03 PM, Anshuman Khandual wrote: >> But should not pfn_pmd() be encapsulated inside >> HAVE_ARCH_TRANSPARENT_HUGEPAGE >> at the minimum (but I would say it should be available always, nonetheless) >> when >> the platform subscribes to

Re: [PATCH 00/50] Add log level to show_stack()

2019-11-06 Thread Russell King - ARM Linux admin
On Wed, Nov 06, 2019 at 09:34:40PM +0100, Peter Zijlstra wrote: > I suppose I'm surprised there are backtraces that are not important. > Either badness happened and it needs printing, or the user asked for it > and it needs printing. Or utterly meaningless. > Perhaps we should be removing

Re: [PATCH 00/50] Add log level to show_stack()

2019-11-06 Thread Peter Zijlstra
On Wed, Nov 06, 2019 at 04:27:33PM +, Dmitry Safonov wrote: > Hi Peter, > > On 11/6/19 9:20 AM, Peter Zijlstra wrote: > > On Wed, Nov 06, 2019 at 03:04:51AM +, Dmitry Safonov wrote: > >> Add log level argument to show_stack(). > >> Done in three stages: > >> 1. Introducing

Re: [PATCH 11/21] asm-generic: don't provide ioremap for CONFIG_MMU

2019-11-06 Thread Christoph Hellwig
On Wed, Nov 06, 2019 at 07:16:38PM +0100, Geert Uytterhoeven wrote: > > shouldn't they all just be that first one? In other words, wouldn't it be > > better to always provide the generic ioremap prototype and unify the ports > > instead? > > Agreed. But I'd go for the second one. Eventually we

Re: [PATCH 11/21] asm-generic: don't provide ioremap for CONFIG_MMU

2019-11-06 Thread Geert Uytterhoeven
Hi Palmer, On Wed, Nov 6, 2019 at 7:11 PM Palmer Dabbelt wrote: > It looks like the difference in prototype between the architectures is between > > void __iomem *ioremap(resource_size_t, size_t) > void __iomem *ioremap(phys_addr_t, size_t) > void __iomem *ioremap(phys_addr_t,

Re: [PATCH 11/21] asm-generic: don't provide ioremap for CONFIG_MMU

2019-11-06 Thread Palmer Dabbelt
On Mon, 28 Oct 2019 23:48:24 PDT (-0700), Christoph Hellwig wrote: All MMU-enabled ports have a non-trivial ioremap and should thus provide the prototype for their implementation instead of providing a generic one unless a different symbol is not defined. Note that this only affects sparc32

Re: [PATCH V8] mm/debug: Add tests validating architecture page table helpers

2019-11-06 Thread Vineet Gupta
On 11/5/19 7:03 PM, Anshuman Khandual wrote: > But should not pfn_pmd() be encapsulated inside HAVE_ARCH_TRANSPARENT_HUGEPAGE > at the minimum (but I would say it should be available always, nonetheless) > when > the platform subscribes to THP irrespective of whether THP is enabled or not. For

Re: [PATCH 00/50] Add log level to show_stack()

2019-11-06 Thread Dmitry Safonov
Hi Peter, On 11/6/19 9:20 AM, Peter Zijlstra wrote: > On Wed, Nov 06, 2019 at 03:04:51AM +, Dmitry Safonov wrote: >> Add log level argument to show_stack(). >> Done in three stages: >> 1. Introducing show_stack_loglvl() for every architecture >> 2. Migrating old users with an explicit log

Re: [PATCH 00/50] Add log level to show_stack()

2019-11-06 Thread Dmitry Safonov
On 11/6/19 8:35 AM, Petr Mladek wrote: > On Wed 2019-11-06 03:04:51, Dmitry Safonov wrote: >> Add log level argument to show_stack(). >> Done in three stages: >> 1. Introducing show_stack_loglvl() for every architecture >> 2. Migrating old users with an explicit log level >> 3. Renaming

Re: [PATCH] [ARC] Add builtins for identifying floating point support

2019-11-06 Thread Claudiu Zissulescu
Ok, I'll push it asap. Thank you for your help, Claudiu On Tue, Nov 5, 2019 at 8:19 PM Vineet Gupta wrote: > > Currently for hard float we need to check for > __ARC_FPU_SP__ || __ARC_FPU_DP__ and for soft float inverse of that. > So define single convenience macros for either cases > > gcc/ >

[PATCH] gdb/remote: Remove negative tid/pid handling in wite_ptid

2019-11-06 Thread Evgeniy Didin
Actually thread and process ID's are positive values. Accorting to http://man7.org/linux/man-pages/man7/pthreads.7.html threads are creating using "clone" syscall, so the ID generation mechanism is similar for threads and processes. According to Linux source code there is a function call tree,

Re: [PATCH 00/50] Add log level to show_stack()

2019-11-06 Thread Peter Zijlstra
On Wed, Nov 06, 2019 at 03:04:51AM +, Dmitry Safonov wrote: > Add log level argument to show_stack(). > Done in three stages: > 1. Introducing show_stack_loglvl() for every architecture > 2. Migrating old users with an explicit log level > 3. Renaming show_stack_loglvl() into show_stack() > >

Re: [PATCH 00/50] Add log level to show_stack()

2019-11-06 Thread Petr Mladek
On Wed 2019-11-06 03:04:51, Dmitry Safonov wrote: > Add log level argument to show_stack(). > Done in three stages: > 1. Introducing show_stack_loglvl() for every architecture > 2. Migrating old users with an explicit log level > 3. Renaming show_stack_loglvl() into show_stack() > >