Re: [PATCH v5 12/14] ARC: Build Infrastructure

2020-04-17 Thread Vineet Gupta
On 4/17/20 5:12 PM, Vineet Gupta via Libc-alpha wrote: > On 4/17/20 4:10 PM, Joseph Myers wrote: >> On Wed, 8 Apr 2020, Vineet Gupta via Libc-alpha wrote: >> >>> + GLIBC_PRIVATE { >>> +# A copy of sigaction lives in libpthread, and needs these. >>> +__default_rt_sa_restorer; >>> + } >>

Re: [PATCH v3] Make any 32-bit time based syscalls unavailable for TIMESIZE==64

2020-04-17 Thread Vineet Gupta
On 4/13/20 2:12 PM, Vineet Gupta via Libc-alpha wrote: > On 4/6/20 11:54 AM, Vineet Gupta wrote: >> On 3/31/20 2:47 PM, Vineet Gupta via Libc-alpha wrote: >>> From: Vineet Gupta via Libc-alpha >>> >>> An older asm-generic syscall ABI may have kernel provide 32-bit >>> time syscalls, so undef them

Re: [PATCH v5 12/14] ARC: Build Infrastructure

2020-04-17 Thread Vineet Gupta
On 4/17/20 4:10 PM, Joseph Myers wrote: > On Wed, 8 Apr 2020, Vineet Gupta via Libc-alpha wrote: > >> + GLIBC_PRIVATE { >> +# A copy of sigaction lives in libpthread, and needs these. >> +__default_rt_sa_restorer; >> + } > > Not a requirement for this port, given that this is

Re: [PATCH v2] provide y2038 safe socket constants for default/asm-generic ABI

2020-04-17 Thread Vineet Gupta
On 4/17/20 4:20 PM, Joseph Myers wrote: > This patch is OK. For commit now ? ___ linux-snps-arc mailing list linux-snps-arc@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-snps-arc

Re: [PATCH v5 14/14] Documentation for ARC port

2020-04-17 Thread Vineet Gupta
On 4/17/20 4:13 PM, Joseph Myers wrote: > On Wed, 8 Apr 2020, Vineet Gupta via Libc-alpha wrote: > >> +* Support for Synpsys ARC HS cores (ARCv2 ISA) running Linux. > > I think there's a missing 'o' there in Synopsys. oops, fixed now. > >> + Port requires atleast > > And a missing space in

Re: [PATCH v5 13/14] build-many-glibcs.py: Enable ARC builds

2020-04-17 Thread Vineet Gupta
On 4/17/20 4:12 PM, Joseph Myers wrote: > On Wed, 8 Apr 2020, Vineet Gupta via Libc-alpha wrote: > >> diff --git a/scripts/build-many-glibcs.py b/scripts/build-many-glibcs.py >> index 64a836c52ea9..77b686d34cea 100755 >> --- a/scripts/build-many-glibcs.py >> +++ b/scripts/build-many-glibcs.py >>

Re: [PATCH v5 11/14] ARC: Update syscall-names.list for ARC specific syscalls

2020-04-17 Thread Vineet Gupta
On 4/17/20 4:05 PM, Joseph Myers wrote: > This patch is OK. So when the rest of port is ready, this will be part of main commit ? ___ linux-snps-arc mailing list linux-snps-arc@lists.infradead.org

Re: [PATCH v5 08/14] ARC: Linux ABI

2020-04-17 Thread Vineet Gupta
On 4/17/20 4:02 PM, Joseph Myers wrote: > On Wed, 8 Apr 2020, Vineet Gupta via Libc-alpha wrote: > >> + for (i = 0; i < stack_args; i++) >> +*r++ = va_arg(vl, unsigned long int); > > Missing space before '(' in call to va_arg. > Fixed.

Re: [PATCH v5 06/14] ARC: hardware floating point support

2020-04-17 Thread Vineet Gupta
On 4/17/20 3:59 PM, Joseph Myers wrote: > On Wed, 8 Apr 2020, Vineet Gupta via Libc-alpha wrote: > >> +# define _FPU_SETS(cw) __asm__ volatile ("bset %0, %0, 31 \r\n" \ >> + "sr %0, [0x301] \r\n" \ >> + : : "r"

Re: [PATCH v5 03/14] ARC: Thread Local Storage support

2020-04-17 Thread Vineet Gupta
On 4/17/20 3:44 PM, Joseph Myers wrote: > On Wed, 8 Apr 2020, Vineet Gupta via Libc-alpha wrote: > >> +/* Code to initially initialize the thread pointer. */ >> +# define TLS_INIT_TP(tcbp) \ >> + ({\ >> +

Re: [PATCH v5 02/14] ARC: startup and dynamic linking code

2020-04-17 Thread Vineet Gupta
On 4/17/20 3:42 PM, Joseph Myers wrote: > On Wed, 8 Apr 2020, Vineet Gupta via Libc-alpha wrote: > >> +/* What this code does: >> +-ldso starts execution here when kernel returns from execve() >> +-calls into generic ldso entry point _dl_start( ) > > Avoid use of parentheses to indicate

Re: [PATCH v5 01/14] ARC: ABI Implementation

2020-04-17 Thread Vineet Gupta
On 4/17/20 3:37 PM, Joseph Myers wrote: > On Wed, 8 Apr 2020, Vineet Gupta via Libc-alpha wrote: > >> +#define reloc_index \ >> +({ \ >> + unsigned long int plt0 = D_PTR (l, l_info[DT_PLTGOT]);\

Re: [PATCH v2] provide y2038 safe socket constants for default/asm-generic ABI

2020-04-17 Thread Joseph Myers
This patch is OK. -- Joseph S. Myers jos...@codesourcery.com ___ linux-snps-arc mailing list linux-snps-arc@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-snps-arc

Re: [PATCH v5 14/14] Documentation for ARC port

2020-04-17 Thread Joseph Myers
On Wed, 8 Apr 2020, Vineet Gupta via Libc-alpha wrote: > +* Support for Synpsys ARC HS cores (ARCv2 ISA) running Linux. I think there's a missing 'o' there in Synopsys. > + Port requires atleast And a missing space in 'at least'. -- Joseph S. Myers jos...@codesourcery.com

Re: [PATCH v5 13/14] build-many-glibcs.py: Enable ARC builds

2020-04-17 Thread Joseph Myers
On Wed, 8 Apr 2020, Vineet Gupta via Libc-alpha wrote: > diff --git a/scripts/build-many-glibcs.py b/scripts/build-many-glibcs.py > index 64a836c52ea9..77b686d34cea 100755 > --- a/scripts/build-many-glibcs.py > +++ b/scripts/build-many-glibcs.py > @@ -1248,6 +1248,7 @@ def

Re: [PATCH v5 12/14] ARC: Build Infrastructure

2020-04-17 Thread Joseph Myers
On Wed, 8 Apr 2020, Vineet Gupta via Libc-alpha wrote: > + GLIBC_PRIVATE { > +# A copy of sigaction lives in libpthread, and needs these. > +__default_rt_sa_restorer; > + } Not a requirement for this port, given that this is GLIBC_PRIVATE so can always be changed later, but does

Re: [PATCH v5 11/14] ARC: Update syscall-names.list for ARC specific syscalls

2020-04-17 Thread Joseph Myers
This patch is OK. -- Joseph S. Myers jos...@codesourcery.com ___ linux-snps-arc mailing list linux-snps-arc@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-snps-arc

Re: [PATCH v5 08/14] ARC: Linux ABI

2020-04-17 Thread Joseph Myers
On Wed, 8 Apr 2020, Vineet Gupta via Libc-alpha wrote: > + for (i = 0; i < stack_args; i++) > +*r++ = va_arg(vl, unsigned long int); Missing space before '(' in call to va_arg. -- Joseph S. Myers jos...@codesourcery.com ___

Re: [PATCH v5 06/14] ARC: hardware floating point support

2020-04-17 Thread Joseph Myers
On Wed, 8 Apr 2020, Vineet Gupta via Libc-alpha wrote: > +# define _FPU_SETS(cw) __asm__ volatile ("bset %0, %0, 31 \r\n" \ > + "sr %0, [0x301] \r\n" \ > + : : "r" (cw)) This asm doesn't look safe; it's

Re: [PATCH v5 03/14] ARC: Thread Local Storage support

2020-04-17 Thread Joseph Myers
On Wed, 8 Apr 2020, Vineet Gupta via Libc-alpha wrote: > +/* Code to initially initialize the thread pointer. */ > +# define TLS_INIT_TP(tcbp) \ > + ({ \ > + long result_var;

Re: [PATCH v5 02/14] ARC: startup and dynamic linking code

2020-04-17 Thread Joseph Myers
On Wed, 8 Apr 2020, Vineet Gupta via Libc-alpha wrote: > +/* What this code does: > +-ldso starts execution here when kernel returns from execve() > +-calls into generic ldso entry point _dl_start( ) Avoid use of parentheses to indicate that a name is a function. > +auto inline void >

Re: [PATCH v5 01/14] ARC: ABI Implementation

2020-04-17 Thread Joseph Myers
On Wed, 8 Apr 2020, Vineet Gupta via Libc-alpha wrote: > +#define reloc_index \ > +({ \ > + unsigned long int plt0 = D_PTR (l, l_info[DT_PLTGOT]); \ > + unsigned long int pltn = reloc_arg;