Re: [PATCH] mm: remove kern_addr_valid() completely

2022-10-18 Thread Guo Ren
On Tue, Oct 18, 2022 at 3:21 PM Kefeng Wang wrote: > > Most architectures(except arm64/x86/sparc) simply return 1 for > kern_addr_valid(), which is only used in read_kcore(), and it > calls copy_from_kernel_nofault() which could check whether the > address is a valid kernel address, so no need

Re: [PATCH] ARC: mm: fix leakage of memory allocated for PTE

2022-10-18 Thread Vineet Gupta
On 10/17/22 09:11, pavel.koz...@synopsys.com wrote: From: Pavel Kozlov Since commit d9820ff ("ARC: mm: switch pgtable_t back to struct page *") a memory leakage problem occurs. Memory allocated for page table entries not released during process termination. This issue can be reproduced by a

Re: [PATCH] arc: update config files

2022-10-18 Thread Vineet Gupta
On 9/29/22 03:14, Lukas Bulwahn wrote: Clean up config files by: - removing configs that were deleted in the past - removing configs not in tree and without recently pending patches - adding new configs that are replacements for old configs in the file For some detailed information,

Re: [PATCH] mm: remove kern_addr_valid() completely

2022-10-18 Thread WANG Xuerui
On 2022/10/18 15:40, Kefeng Wang wrote: Most architectures(except arm64/x86/sparc) simply return 1 for one space before the opening parens kern_addr_valid(), which is only used in read_kcore(), and it calls copy_from_kernel_nofault() which could check whether the address is a valid kernel

Re: [PATCH] mm: remove kern_addr_valid() completely

2022-10-18 Thread Helge Deller
On 10/18/22 09:40, Kefeng Wang wrote: Most architectures(except arm64/x86/sparc) simply return 1 for kern_addr_valid(), which is only used in read_kcore(), and it calls copy_from_kernel_nofault() which could check whether the address is a valid kernel address, so no need kern_addr_valid(), let's

Re: [PATCH] mm: remove kern_addr_valid() completely

2022-10-18 Thread Christoph Hellwig
Thanks, this is long overdue! Acked-by: Christoph Hellwig ___ linux-snps-arc mailing list linux-snps-arc@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-snps-arc

Re: [PATCH] mm: remove kern_addr_valid() completely

2022-10-18 Thread Heiko Carstens
On Tue, Oct 18, 2022 at 03:40:14PM +0800, Kefeng Wang wrote: > Most architectures(except arm64/x86/sparc) simply return 1 for > kern_addr_valid(), which is only used in read_kcore(), and it > calls copy_from_kernel_nofault() which could check whether the > address is a valid kernel address, so no

Re: [PATCH] mm: remove kern_addr_valid() completely

2022-10-18 Thread Geert Uytterhoeven
On Tue, Oct 18, 2022 at 9:25 AM Kefeng Wang wrote: > Most architectures(except arm64/x86/sparc) simply return 1 for > kern_addr_valid(), which is only used in read_kcore(), and it > calls copy_from_kernel_nofault() which could check whether the > address is a valid kernel address, so no need

[PATCH] mm: remove kern_addr_valid() completely

2022-10-18 Thread Kefeng Wang
Most architectures(except arm64/x86/sparc) simply return 1 for kern_addr_valid(), which is only used in read_kcore(), and it calls copy_from_kernel_nofault() which could check whether the address is a valid kernel address, so no need kern_addr_valid(), let's remove unneeded kern_addr_valid()