Re: [PATCH 2/2] dmaengine: Add DW AXI DMAC driver

2017-02-09 Thread Eugeniy Paltsev
Thanks for response. My comments are given inline below. On Wed, 2017-01-25 at 19:25 +0200, Andy Shevchenko wrote: > On Wed, 2017-01-25 at 18:34 +0300, Eugeniy Paltsev wrote: > >  > > This patch adds support for the DW AXI DMAC controller. > >  > > DW AXI DMAC is a p

[PATCH 0/2] dmaengine: Add DW AXI DMAC driver

2017-01-25 Thread Eugeniy Paltsev
fixies according to previous RFC * Add DT bindings Eugeniy Paltsev (2): dt-bindings: Document the Synopsys DW AXI DMA bindings dmaengine: Add DW AXI DMAC driver .../devicetree/bindings/dma/snps,axi-dw-dmac.txt | 33 + drivers/dma/Kconfig|8 + drivers/dma

Re: [RFC] dmaengine: Add DW AXI DMAC driver

2017-01-20 Thread Eugeniy Paltsev
Hi Andy, thanks for respond. I'm agree with most of the comments. My comments below. On Fri, 2017-01-20 at 15:38 +0200, Andy Shevchenko wrote: > On Fri, 2017-01-20 at 13:50 +0300, Eugeniy Paltsev wrote: > > > > This patch adds support for the DW AXI DMAC controller. >

[PATCH v6 1/2] DW DMAC: enable memory-to-memory transfers support

2016-11-25 Thread Eugeniy Paltsev
All known devices, which use DT for configuration, support memory-to-memory transfers. So enable it by default, if we read configuration from DT. Acked-by: Andy Shevchenko <andriy.shevche...@linux.intel.com> Signed-off-by: Eugeniy Paltsev <eugeniy.palt...@synopsys.com> --- dr

[PATCH v6 2/2] DW DMAC: add multi-block property to device tree

2016-11-25 Thread Eugeniy Paltsev
multi block transfers (if present) via DT. Switch from per device is_nollp variable to multi_block array to be able enable/disable multi block transfers separately per channel. Acked-by: Andy Shevchenko <andriy.shevche...@linux.intel.com> Signed-off-by: Eugeniy Paltsev <eugeniy.palt...@syn

[PATCH v6 0/2] DW DMAC: update device tree

2016-11-25 Thread Eugeniy Paltsev
Move adding DT property and adding documentation for this property to one patch. Eugeniy Paltsev (2): DW DMAC: enable memory-to-memory transfers support DW DMAC: add multi-block property to device tree Documentation/devicetree/bindings/dma/snps-dma.txt | 2 ++ arch/arc/boot/dts/abilis_tb10x.

[PATCH v5 1/2] DW DMAC: enable memory-to-memory transfers support

2016-11-24 Thread Eugeniy Paltsev
All known devices, which use DT for configuration, support memory-to-memory transfers. So enable it by default, if we read configuration from DT. Acked-by: Andy Shevchenko <andriy.shevche...@linux.intel.com> Signed-off-by: Eugeniy Paltsev <eugeniy.palt...@synopsys.com> --- dr

[PATCH v5 0/2] DW DMAC: update device tree

2016-11-24 Thread Eugeniy Paltsev
it by default, if we read configuration from DT. * Use "multi-block" instead of "hw-llp" name to be more clear. * Move adding DT property and adding documentation for this property to one patch. Eugeniy Paltsev (2): DW DMAC: enable memory-to-memory transfers support D

[PATCH v4 0/2] DW DMAC: update device tree

2016-11-23 Thread Eugeniy Paltsev
ory transfers. So we don't need to read it from DT. So enable it by default, if we read configuration from DT. * Use "multi-block" instead of "hw-llp" name to be more clear. * Move adding DT property and adding documentation for this property to one patch. Eugeniy Pa

[PATCH v4 2/2] DW DMAC: add multi-block property to device tree

2016-11-23 Thread Eugeniy Paltsev
multi block transfers (if present) via DT. Switch from per device is_nollp variable to multi_block array to be able enable/disable multi block transfers separately per channel. Signed-off-by: Eugeniy Paltsev <eugeniy.palt...@synopsys.com> --- Also: Update DT documentation. Update existing pl

[PATCH v4 1/2] DW DMAC: enable memory-to-memory transfers support

2016-11-23 Thread Eugeniy Paltsev
All known devices, which use DT for configuration, support memory-to-memory transfers. So enable it by default, if we read configuration from DT. Acked-by: Andy Shevchenko <andriy.shevche...@linux.intel.com> Signed-off-by: Eugeniy Paltsev <eugeniy.palt...@synopsys.com> --- dr

[PATCH v3 0/2] DW DMAC: update device tree

2016-11-18 Thread Eugeniy Paltsev
e don't need to read it from DT. So enable it by default, if we read configuration from DT. * Use "multi-block" instead of "hw-llp" name to be more clear. * Move adding DT property and adding documentation for this property to one patch. Eugeniy Paltsev (2): DW DMAC: e

[PATCH v3 2/2] DW DMAC: add multi-block property to device tree

2016-11-18 Thread Eugeniy Paltsev
multi block transfers (if present) via DT. Switch from per device is_nollp variable to multi_block array to be able enable/disable multi block transfers separately per channel. Update DT documentation. Update existing platform data. Signed-off-by: Eugeniy Paltsev <eugeniy.palt...@synopsys.

[PATCH v3 1/2] DW DMAC: enable memory-to-memory transfers support

2016-11-18 Thread Eugeniy Paltsev
All known devices, which use DT for configuration, support memory-to-memory transfers. So enable it by default, if we read configuration from DT. Signed-off-by: Eugeniy Paltsev <eugeniy.palt...@synopsys.com> --- drivers/dma/dw/platform.c | 6 ++ 1 file changed, 6 insertions(+) diff

[PATCH v2 2/2] DW DMAC: add multi-block property to device tree

2016-11-18 Thread Eugeniy Paltsev
multi block transfers (if present) via DT. Switch from per device is_nollp variable to multi_block array to be able enable/disable multi block transfers separately per channel. Update DT documentation. Signed-off-by: Eugeniy Paltsev <eugeniy.palt...@synopsys.com> --- Documentation/devi

[PATCH v2 1/2] DW DMAC: enable memory-to-memory transfers support

2016-11-18 Thread Eugeniy Paltsev
All known devices, which use DT for configuration, support memory-to-memory transfers. So enable it by default, if we read configuration from DT. Signed-off-by: Eugeniy Paltsev <eugeniy.palt...@synopsys.com> --- drivers/dma/dw/platform.c | 6 ++ 1 file changed, 6 insertions(+) diff

Re: [PATCH 4/4] Update device tree Synopsys DW DMAC documentation

2016-11-16 Thread Eugeniy Paltsev
Hi Andy, On Wed, 2016-11-16 at 17:10 +0200, Andy Shevchenko wrote: > Overall, since we are going to expose some properties to the Device > Tree > I would really think twice about naming. Better if we reuse something > existing already. > > So, what I can see is > > dmacap,private >

[PATCH 3/4] DW DMAC: add hw-llp property to device tree

2016-11-16 Thread Eugeniy Paltsev
block transfers (if present) via DT. Signed-off-by: Eugeniy Paltsev <eugeniy.palt...@synopsys.com> --- drivers/dma/dw/core.c| 2 +- drivers/dma/dw/platform.c| 5 + include/linux/platform_data/dma-dw.h | 4 ++-- 3 files changed, 8 insertions(+), 3 deletions(-)

[PATCH 4/4] Update device tree Synopsys DW DMAC documentation

2016-11-16 Thread Eugeniy Paltsev
support via DT. Fix white spaces. Signed-off-by: Eugeniy Paltsev <eugeniy.palt...@synopsys.com> --- Documentation/devicetree/bindings/dma/snps-dma.txt | 10 -- 1 file changed, 8 insertions(+), 2 deletions(-) diff --git a/Documentation/devicetree/bindings/dma/snps-dma.txt b/Documen

[PATCH 2/4] DW DMAC: add is-memcpu property to device tree

2016-11-16 Thread Eugeniy Paltsev
Memory-to-memory dma transfers were disabled by default if we used DT to cofigure DMAC. Add is-memcpu property, so it became possible to enable memory-to-memory transfers support via DT. Signed-off-by: Eugeniy Paltsev <eugeniy.palt...@synopsys.com> --- drivers/dma/dw/platform.c | 3 +++

[PATCH 1/4] DW DMAC: rename is_private property as ordered by DT policy

2016-11-16 Thread Eugeniy Paltsev
Rename is_private to is-private as ordered by DT policy. The change leaves the support for the old format. Signed-off-by: Eugeniy Paltsev <eugeniy.palt...@synopsys.com> --- drivers/dma/dw/platform.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/drivers/dma/dw/platform.c b/drivers/

Re: [PATCH v3 0/3] dmaengine: DW DMAC: split pdata to hardware properties

2016-11-10 Thread Eugeniy Paltsev
On Tue, 2016-11-08 at 15:36 +0200, Andy Shevchenko wrote: > On Tue, 2016-11-08 at 12:22 +0000, Eugeniy Paltsev wrote: > > > > On Mon, 2016-11-07 at 15:55 +0200, Andy Shevchenko wrote: >   > > > > > > > > > > > > > + * @only_quirks_used:

Re: [PATCH v3 0/3] dmaengine: DW DMAC: split pdata to hardware properties

2016-11-02 Thread Eugeniy Paltsev
Hi Andy, Could you possibly tell me your ideas about these changes? Thanks. On Fri, 2016-10-28 at 18:59 +0300, Eugeniy Paltsev wrote: > This series is to address a proposal by Andy in these threads: > http://www.spinics.net/lists/dmaengine/msg11506.html > http://www.spinics.net/lists/

[PATCH v3 1/3] dmaengine: DW DMAC: split pdata to hardware properties and platform quirks

2016-10-28 Thread Eugeniy Paltsev
Split platform data to actual hardware properties, and platform quirks. Now we able to use quirks and hardware properties separately from different sources (pdata, device tree or autoconfig registers) Signed-off-by: Eugeniy Paltsev <eugeniy.palt...@synopsys.com> --- drivers/dma/dw/

[PATCH v3 3/3] dmaengine: DW DMAC: move "nollp" to "dwc->flags"

2016-10-28 Thread Eugeniy Paltsev
Add "DW_DMA_IS_LLP_SUPPORTED" flag. Use this flag to get rid of "dwc->nollp" as separate variable. Signed-off-by: Eugeniy Paltsev <eugeniy.palt...@synopsys.com> --- drivers/dma/dw/core.c | 11 ++- drivers/dma/dw/regs.h | 2 +- 2 files changed, 7 insertions(+

[PATCH v3 2/3] dmaengine: DW DMAC: convert to unified device property API

2016-10-28 Thread Eugeniy Paltsev
Convert device tree properties reading to unified device property API, update properties names as ordered by DT policy. Signed-off-by: Eugeniy Paltsev <eugeniy.palt...@synopsys.com> --- drivers/dma/dw/platform.c | 33 ++--- 1 file changed, 14 insertions(

[PATCH v2] dmaengine: DW DMAC: split pdata to hardware properties and platform quirks

2016-10-27 Thread Eugeniy Paltsev
or autoconfig registers) Signed-off-by: Eugeniy Paltsev <eugeniy.palt...@synopsys.com> --- Changes for v2: - use separate bool values for quirks in "dw_dma_platform_data" instead of common bit field. - convert device tree properties reading to unified device property API. I

Re: [PATCH] dmaengine: DW DMAC: split pdata to hardware properties and platform quirks

2016-10-20 Thread Eugeniy Paltsev
On Thu, 2016-10-20 at 13:48 +0300, Andy Shevchenko wrote: > On Thu, 2016-09-15 at 16:14 +0300, Eugeniy Paltsev wrote: > > > > This patch is to address a proposal by Andy in this thread: > > http://www.spinics.net/lists/dmaengine/msg10754.html > > Split platform data to

Re: [PATCH] dmaengine: DW DMAC: split pdata to hardware properties and platform quirks

2016-10-19 Thread Eugeniy Paltsev
Hi Andy, On Fri, 2016-10-07 at 14:05 +0300, Andy Shevchenko wrote: > On Wed, 2016-10-05 at 15:14 +0000, Eugeniy Paltsev wrote: > > > > Hi Andy, > > what do you think about these changes? > I was off for few weeks, will look at this next week. > I was wondering yo

[PATCH v2] drm/arcpgu: Accommodate adv7511 switch to DRM bridge

2016-10-19 Thread Eugeniy Paltsev
C PGU driver to be able work with drm bridge hdmi encoder interface. The hdmi connector code isn't needed anymore as we expect the adv7511 bridge driver to create/manage the connector. Signed-off-by: Eugeniy Paltsev <eugeniy.palt...@synopsys.com> --- Changes for v2: - re

[PATCH] drm/arcpgu: Accommodate adv7511 switch to DRM bridge

2016-10-14 Thread Eugeniy Paltsev
C PGU driver to be able work with drm bridge hdmi encoder interface. The hdmi connector code isn't needed anymore as we expect the adv7511 bridge driver to create/manage the connector. Signed-off-by: Eugeniy Paltsev <eugeniy.palt...@synopsys.com> --- drivers/gpu/drm/arc/arcpgu_hdmi.c | 144

Re: [PATCH] dmaengine: DW DMAC: split pdata to hardware properties and platform quirks

2016-10-05 Thread Eugeniy Paltsev
Hi Andy, what do you think about these changes? On Thu, 2016-09-15 at 16:14 +0300, Eugeniy Paltsev wrote: > This patch is to address a proposal by Andy in this thread: > http://www.spinics.net/lists/dmaengine/msg10754.html > Split platform data to actual hardware properties, and platform

[PATCH] dmaengine: DW DMAC: split pdata to hardware properties and platform quirks

2016-09-15 Thread Eugeniy Paltsev
or autoconfig registers) Signed-off-by: Eugeniy Paltsev <eugeniy.palt...@synopsys.com> --- drivers/dma/dw/core.c| 31 +++--- drivers/dma/dw/platform.c| 42 +--- include/linux/platform_data/dma-dw.h | 20 +++---

[PATCH] dmaengine: dmatest: Restore "memcpy" as default mode

2016-09-14 Thread Eugeniy Paltsev
Commit 0d4cb44da6ca0e8 ("dmaengine: dmatest: Add support for scatter-gather DMA mode") changes default "dmatest" behavior by changing default mode from "memcpy" to "scatter-gather". Now "memcpy" gets back as default mode. Signed-off-by: Eugeniy P

Re: [PATCH] DW: Read "is_memcpy" and "is_nollp" property from device tree.

2016-08-23 Thread Eugeniy Paltsev
On Fri, 2016-08-19 at 17:39 +0300, Andy Shevchenko wrote: > On Tue, 2016-08-16 at 14:31 +0300, Eugeniy Paltsev wrote: > > > > DW DMAC on ARC SDP became broken after df5c7386 ("dmaengine: dw: > > some > > Intel > > devices has no memcpy support") and 3

[PATCH] ARC: Fix max ULP for cosine test

2016-08-23 Thread Eugeniy Paltsev
t;1" for ARM. I am wondering, if it was done for any special reason? Otherwise, set max ULP for "cos (M_PI_6l * 2.0) == 0.5" test to "1" instead of "0" for ARC. Signed-off-by: Eugeniy Paltsev <eugeniy.palt...@synopsys.com> --- test/math/libm-test-ulps-arc |

Re: Wrong "nollp" DW DMAC parameter value on ARC SDP.

2016-08-16 Thread Eugeniy Paltsev
On Mon, 2016-08-15 at 15:41 +0300, Andy Shevchenko wrote: > On Mon, 2016-08-15 at 11:10 +0000, Eugeniy Paltsev wrote: > > > > On Fri, 2016-08-12 at 17:08 +0300, Andy Shevchenko wrote: > > > > > >   > > > > > > > > > > > > >

[PATCH] DW: Read "is_memcpy" and "is_nollp" property from device tree.

2016-08-16 Thread Eugeniy Paltsev
. This leads to inoperability of DW DMAC. This patch adds reading missed parameters from device tree. Note there's a prerequisite http://www.spinics.net/lists/dmaengine/msg10682.html Signed-off-by: Eugeniy Paltsev <eugeniy.palt...@synopsys.com> --- drivers/dma/dw/platform.c | 6 ++ 1 file

Re: Wrong "nollp" DW DMAC parameter value on ARC SDP.

2016-08-12 Thread Eugeniy Paltsev
On Fri, 2016-08-12 at 13:59 +0300, Andy Shevchenko wrote: > On Fri, 2016-08-12 at 08:03 +0000, Eugeniy Paltsev wrote: > > > > Hi, > > > > "nollp" parameter defines if DW DMAC channel supports multi block > > transfer or not. > > > >

Wrong "nollp" DW DMAC parameter value on ARC SDP.

2016-08-12 Thread Eugeniy Paltsev
Hi, "nollp" parameter defines if DW DMAC channel supports multi block transfer or not. It is calculated in runtime, but differently depending on on availability of pdata. If pdata is absent "nollp" is calculated using autoconfig hardware registers. Otherwise "nollp" is calculated using the next

dmatest no longer works on ARC SDP with DW DMAC

2016-08-10 Thread Eugeniy Paltsev
dmatest on ARC SDP with DW DMAC became broken after df5c7386 ("dmaengine: dw: some Intel devices has no memcpy support") and 30cb2639 ("dmaengine: dw: don't override platform data with autocfg") commits. * After df5c7386 commit "DMA_MEMCPY" capability option doesn't get set correctly in platform

Re: [PATCH] ARC: [*defconfigs] Enable hung tasks detection

2016-07-21 Thread Eugeniy Paltsev
Hi, Not every time. For example, last time I debug mmap3 LTP's test, which  stuck in "D" state, I didn't recieve any messages until I enabled this option. This happends on nsim 700. On Thu, 2016-07-21 at 09:17 -0700, Vineet Gupta wrote: > On 07/21/2016 07:52 AM, Eugeniy

<    1   2   3   4   5