Re: [PATCH] profile: setup_profiling_timer() is moslty not implemented

2022-07-25 Thread Ben Dooks
On 25/07/2022 20:39, Andrew Morton wrote: On Thu, 21 Jul 2022 20:55:09 +0100 Ben Dooks wrote: The setup_profiling_timer() is mostly un-implemented by many architectures. In many places it isn't guarded by CONFIG_PROFILE which is needed for it to be used. Make it a weak symbol in k

[PATCH] profile: setup_profiling_timer() is moslty not implemented

2022-07-21 Thread Ben Dooks
3:5: warning: symbol 'setup_profiling_timer' was not declared. Should it be static? Signed-off-by: Ben Dooks --- arch/alpha/kernel/smp.c | 6 -- arch/arc/kernel/smp.c | 8 arch/arm/kernel/smp.c | 8 arch/arm64/kernel/smp.c | 8 a

Re: [PATCH] clocksource: add missing line break to error messages

2017-03-14 Thread Ben Dooks
they fail as all the examples here are of the form of: ptr = of_iomap(reource) if (!ptr) { pr_err("cannot remap resource\n"); ... return ERR; } Maybe we should look into this post this patch series