Re: [PATCH 4/7] arc: replace cc-option-yn uses with cc-option

2021-08-17 Thread Nathan Chancellor 




On 8/17/2021 11:07 AM, 'Nick Desaulniers' via Clang Built Linux wrote:

On Mon, Aug 16, 2021 at 7:05 PM Nathan Chancellor  wrote:


On 8/16/2021 5:21 PM, 'Nick Desaulniers' via Clang Built Linux wrote:

cc-option-yn can be replaced with cc-option. ie.
Checking for support:
ifeq ($(call cc-option-yn,$(FLAG)),y)
becomes:
ifneq ($(call cc-option,$(FLAG)),)

Checking for lack of support:
ifeq ($(call cc-option-yn,$(FLAG)),n)
becomes:
ifeq ($(call cc-option,$(FLAG)),)

This allows us to pursue removing cc-option-yn.

Cc: Vineet Gupta 
Cc: linux-snps-arc@lists.infradead.org
Signed-off-by: Nick Desaulniers 
---
   arch/arc/Makefile | 3 +--
   1 file changed, 1 insertion(+), 2 deletions(-)

diff --git a/arch/arc/Makefile b/arch/arc/Makefile
index c0d87ac2e221..8782a03f24a8 100644
--- a/arch/arc/Makefile
+++ b/arch/arc/Makefile
@@ -18,8 +18,7 @@ ifeq ($(CONFIG_ARC_TUNE_MCPU),"")
   cflags-y+= $(tune-mcpu-def-y)
   else
   tune-mcpu   := $(shell echo $(CONFIG_ARC_TUNE_MCPU))
-tune-mcpu-ok := $(call cc-option-yn, 
$(tune-mcpu))
-ifeq ($(tune-mcpu-ok),y)
+ifneq ($(call cc-option,$(tune-mcpu)),)
   cflags-y+= $(tune-mcpu)


Any reason not to just turn this into

cflags-y += $(call cc-option,$(tune-mcpu))

?


Yes, you'll need to pull up the source; the diff doesn't provide
enough context. tune-mcpu is used in the body of the else branch
hinted at by the diff. PTAL


Ah, fair enough. The warning is a little unconventional but oh well :)

Reviewed-by: Nathan Chancellor 



If $(tune-mcpu) is empty or invalid, nothing will be added to cflags-y.


   else
   # The flag provided by 'CONFIG_ARC_TUNE_MCPU' option isn't known by this 
compiler







___
linux-snps-arc mailing list
linux-snps-arc@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-snps-arc

Re: [PATCH] ARC: [plat-hsdk]: fix USB regression

2020-04-07 Thread Nathan Chancellor 
On Tue, Apr 07, 2020 at 06:20:28PM -0700, Nathan Chancellor wrote:
> On Tue, Apr 07, 2020 at 07:19:33PM +0300, Eugeniy Paltsev wrote:
> > As of today the CONFIG_USB isn't explicitly present in HSDK defconfig
> > as it is implicitly forcibly enabled by UDL driver which selects CONFIG_USB
> > in its kconfig.
> > The commit 5d50bd440bc2 ("drm/udl: Make udl driver depend on CONFIG_USB")
> > reverse the dependencies between UDL and USB so UDL now depends on
> > CONFIG_USB and not selects it. This introduces regression for ARC HSDK
> > board as HSDK defconfig wasn't adjusted and now it misses USB support
> > due to lack of CONFIG_USB enabled.
> > 
> > Fix that.
> > 
> > Fixes: 5d50bd440bc2 ("drm/udl: Make udl driver depend on CONFIG_USB")
> > Signed-off-by: Eugeniy Paltsev 
> > ---
> >  arch/arc/configs/hsdk_defconfig | 1 +
> >  1 file changed, 1 insertion(+)
> > 
> > diff --git a/arch/arc/configs/hsdk_defconfig 
> > b/arch/arc/configs/hsdk_defconfig
> > index 0974226fab55..f79c15892704 100644
> > --- a/arch/arc/configs/hsdk_defconfig
> > +++ b/arch/arc/configs/hsdk_defconfig
> > @@ -65,6 +65,7 @@ CONFIG_DRM_UDL=y
> >  CONFIG_DRM_ETNAVIV=y
> >  CONFIG_FB=y
> >  CONFIG_FRAMEBUFFER_CONSOLE=y
> > +CONFIG_USB
> 
> Shouldn't this be CONFIG_USB=y?
> 
> As it stands, this patch does nothing.
> 
> Cheers,
> Nathan

Nevermind, I came across v2 on the mailing list, sorry for the noise.

Cheers,
Nathan

___
linux-snps-arc mailing list
linux-snps-arc@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-snps-arc

Re: [PATCH] ARC: [plat-hsdk]: fix USB regression

2020-04-07 Thread Nathan Chancellor 
On Tue, Apr 07, 2020 at 07:19:33PM +0300, Eugeniy Paltsev wrote:
> As of today the CONFIG_USB isn't explicitly present in HSDK defconfig
> as it is implicitly forcibly enabled by UDL driver which selects CONFIG_USB
> in its kconfig.
> The commit 5d50bd440bc2 ("drm/udl: Make udl driver depend on CONFIG_USB")
> reverse the dependencies between UDL and USB so UDL now depends on
> CONFIG_USB and not selects it. This introduces regression for ARC HSDK
> board as HSDK defconfig wasn't adjusted and now it misses USB support
> due to lack of CONFIG_USB enabled.
> 
> Fix that.
> 
> Fixes: 5d50bd440bc2 ("drm/udl: Make udl driver depend on CONFIG_USB")
> Signed-off-by: Eugeniy Paltsev 
> ---
>  arch/arc/configs/hsdk_defconfig | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/arch/arc/configs/hsdk_defconfig b/arch/arc/configs/hsdk_defconfig
> index 0974226fab55..f79c15892704 100644
> --- a/arch/arc/configs/hsdk_defconfig
> +++ b/arch/arc/configs/hsdk_defconfig
> @@ -65,6 +65,7 @@ CONFIG_DRM_UDL=y
>  CONFIG_DRM_ETNAVIV=y
>  CONFIG_FB=y
>  CONFIG_FRAMEBUFFER_CONSOLE=y
> +CONFIG_USB

Shouldn't this be CONFIG_USB=y?

As it stands, this patch does nothing.

Cheers,
Nathan

___
linux-snps-arc mailing list
linux-snps-arc@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-snps-arc