Re: [PATCH 03/21] ia64: rename ioremap_nocache to ioremap_uc

[Sergei Shtylyov]

Hello!

On 17.10.2019 20:45, Christoph Hellwig wrote:


On ia64 ioremap_nocache fails if attributs don't match.  Not other


  Attributes?


architectures does this, and we plan to get rid of ioremap_nocache.
So get rid of the special semantics and define ioremap_nocache in
terms of ioremap as no portable driver could rely on the behavior
anyway.

However x86 implements ioremap_uc with a in a similar way as the ia64


   With a what?


version of ioremap_nocache, so implement that instead.

Signed-off-by: Christoph Hellwig 
---
  arch/ia64/include/asm/io.h | 6 +++---
  arch/ia64/mm/ioremap.c | 4 ++--
  2 files changed, 5 insertions(+), 5 deletions(-)

diff --git a/arch/ia64/include/asm/io.h b/arch/ia64/include/asm/io.h
index 54e70c21352a..fec9df9609ed 100644
--- a/arch/ia64/include/asm/io.h
+++ b/arch/ia64/include/asm/io.h

[...]

MBR, Sergei

___
linux-snps-arc mailing list
linux-snps-arc@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-snps-arc

Re: [PATCH 06/26] ia64: rename ioremap_nocache to ioremap_uc

[Sergei Shtylyov]

Hello!

On 17.08.2019 10:32, Christoph Hellwig wrote:


On ia64 ioremap_nocache fails if attributs don't match.  Not other


   Attributes. :-)


architectures does this, and we plan to get rid of ioremap_nocache.
So get rid of the special semantics and define ioremap_nocache in
terms of ioremap as no portable driver could rely on the behavior
anyway.

However x86 implements ioremap_uc with a in a similar way as the ia64


   "With a" not really needed?


version of ioremap_nocache, so implement that instead.

Signed-off-by: Christoph Hellwig 

[...]

MBR, Sergei

Re: [PATCH v2] ARC: axs10x - add Ethernet PHY description in .dts

[Sergei Shtylyov]

Hello.

On 3/17/2016 2:41 PM, Vineet Gupta wrote:


Following commit broke DW GMAC functionality on AXS10x boards:
http://git.kernel.org/cgit/linux/kernel/git/torvalds/linux.git/commit/?id=e34d65696d2ef13dc32f2a162556c86c461ed763

 Note that scripts/checkpatch.pl now enforces certain format for citing
commits: commit <12-digit SHA1> ("").



Frankly I haven't run that patch through checkpatch due to patch
simplicity.

But I'll try to not do any assumptions from now on and will try to
use checkpatch for each and every thing I send :)

Thanks for spotting all his!



   Sorry for not reporting everything on the 1st review.


-Alexey


Sergei, do you mind providing a Ack/Reviewed-by on the patch below

>

Reviewed-by: Sergei Shtylyov <sergei.shtyl...@cogentembedded.com>

   The patch here is white space damaged however: tabs were converted to 
spaces. :-(


MBR, Sergei


___
linux-snps-arc mailing list
linux-snps-arc@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-snps-arc

Re: [PATCH] ARC: axs10x - add Ethernet PHY description in .dts

[Sergei Shtylyov]

Hello.

On 3/15/2016 12:29 PM, Alexey Brodkin wrote:


Following commit broke DW GMAC functionality on AXS10x boards:
http://git.kernel.org/cgit/linux/kernel/git/torvalds/linux.git/commit/?id=e34d65696d2ef13dc32f2a162556c86c461ed763

That's what happens on eth0 up:
--->8
libphy: PHY stmmac-0: not found
eth0: Could not attach to PHY
stmmac_open: Cannot attach to PHY (error: -19)
--->8

Simplest solution is to add PHY description in board's .dts.
And so we do here.

Signed-off-by: Alexey Brodkin 
Cc: Rob Herring 
Cc: Phil Reid 
Cc: David S. Miller 
Cc: linux-ker...@vger.kernel.org
Cc: net...@vger.kernel.org
Cc: sta...@vger.kernel.org # 4.5.x
---
  arch/arc/boot/dts/axs10x_mb.dtsi | 8 
  1 file changed, 8 insertions(+)

diff --git a/arch/arc/boot/dts/axs10x_mb.dtsi b/arch/arc/boot/dts/axs10x_mb.dtsi
index 44a578c..04b999e 100644
--- a/arch/arc/boot/dts/axs10x_mb.dtsi
+++ b/arch/arc/boot/dts/axs10x_mb.dtsi
@@ -47,6 +47,14 @@
clocks = <>;
clock-names = "stmmaceth";
max-speed = <100>;
+   mdio0 {
+   #address-cells = <1>;
+   #size-cells = <0>;
+   compatible = "snps,dwmac-mdio";
+   phy0: ethernet-phy@0 {


   The naming is inconsistent with the "reg" prop specified, should be @1.

MBR, Sergei


___
linux-snps-arc mailing list
linux-snps-arc@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-snps-arc