Re: [GIT PULL] drm/arc: Yet another set of minor fixes
On Fri, Dec 13, 2019 at 10:24:42AM +, Alexey Brodkin wrote: > Hi Daniel, > > > -Original Message- > > From: Daniel Vetter > > Sent: Friday, December 13, 2019 1:22 PM > > To: Alexey Brodkin > > Cc: Daniel Vetter ; David Airlie ; arcml > > > a...@lists.infradead.org>; Eugeniy Paltsev ; > > dri-de...@lists.freedesktop.org > > Subject: Re: [GIT PULL] drm/arc: Yet another set of minor fixes > > > > [snip] > > > > Not sure if you noticed re-spin of my pull-request in the previous > > > message. > > > Do you want me to send it in a separate email? > > > > Yeah I guess this got lost again. > > So should I re-send it in another email or you will pick it up > from existing thread? > > If I'm going to re-send it do I need to re-base it on today's drm/drm-next? I just tried to vacuum it in, but it chokes the scripts since it's multiple pull requests in one mail with quotes. So please redo in a clean mail. Wrt baseline, here's the recommendation in order of my preference: - Just stuff it into drm-misc-next - Base your tree on a tag from Linux - If you need a specific depedency, base your tree on drm-next with that patch included. - If it's even more complicated, do a multi-way topic branch with lots of coordination. Cheers, Daniel -- Daniel Vetter Software Engineer, Intel Corporation http://blog.ffwll.ch ___ linux-snps-arc mailing list linux-snps-arc@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-snps-arc
RE: [GIT PULL] drm/arc: Yet another set of minor fixes
Hi Daniel, > -Original Message- > From: Daniel Vetter > Sent: Friday, December 13, 2019 1:22 PM > To: Alexey Brodkin > Cc: Daniel Vetter ; David Airlie ; arcml > a...@lists.infradead.org>; Eugeniy Paltsev ; > dri-de...@lists.freedesktop.org > Subject: Re: [GIT PULL] drm/arc: Yet another set of minor fixes > [snip] > > Not sure if you noticed re-spin of my pull-request in the previous message. > > Do you want me to send it in a separate email? > > Yeah I guess this got lost again. So should I re-send it in another email or you will pick it up from existing thread? If I'm going to re-send it do I need to re-base it on today's drm/drm-next? -Alexey ___ linux-snps-arc mailing list linux-snps-arc@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-snps-arc
Re: [GIT PULL] drm/arc: Yet another set of minor fixes
On Fri, Dec 13, 2019 at 10:20:39AM +, Alexey Brodkin wrote: > Hi Daniel, > > [snip] > > > > Thanks for the pointers > > > > > > > Or respin this one, but these small pulls have a habit of occasionally > > > > getting lost :-/ > > > > > > Well I'd better re-spin this, see below. > > > > > > The following changes since commit > > > acc61b8929365e63a3e8c8c8913177795aa45594: > > > > > > Merge tag 'drm-next-5.5-2019-11-22' of > > > git://people.freedesktop.org/~agd5f/linux into drm-next > > (2019-11-26 08:40:23 +1000) > > > > > > are available in the Git repository at: > > > > > > g...@github.com:abrodkin/linux.git tags/arcpgu-updates-2019.11.27 > > > > > > for you to fetch changes up to 9c2acc26c899aa12ad009dff10a5573ef769a7fd: > > > > > > DRM: ARC: PGU: add ARGB format to supported format list (2019-11-27 > > > 16:43:39 +0300) > > > > > > > > > Clean-up and fixes for FourCC handling in ARC PGU. > > > > > > > > > Eugeniy Paltsev (4): > > > DRM: ARC: PGU: fix framebuffer format switching > > > DRM: ARC: PGU: cleanup supported format list code > > > DRM: ARC: PGU: replace unsupported by HW RGB888 format by XRGB888 > > > DRM: ARC: PGU: add ARGB format to supported format list > > > > > > drivers/gpu/drm/arc/arcpgu_crtc.c | 36 > > > ++-- > > > drivers/gpu/drm/arc/arcpgu_regs.h | 2 +- > > > 2 files changed, 19 insertions(+), 19 deletions(-) > > Not sure if you noticed re-spin of my pull-request in the previous message. > Do you want me to send it in a separate email? Yeah I guess this got lost again. -Daniel -- Daniel Vetter Software Engineer, Intel Corporation http://blog.ffwll.ch ___ linux-snps-arc mailing list linux-snps-arc@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-snps-arc
RE: [GIT PULL] drm/arc: Yet another set of minor fixes
Hi Daniel, [snip] > > Thanks for the pointers > > > > > Or respin this one, but these small pulls have a habit of occasionally > > > getting lost :-/ > > > > Well I'd better re-spin this, see below. > > > > The following changes since commit acc61b8929365e63a3e8c8c8913177795aa45594: > > > > Merge tag 'drm-next-5.5-2019-11-22' of > > git://people.freedesktop.org/~agd5f/linux into drm-next > (2019-11-26 08:40:23 +1000) > > > > are available in the Git repository at: > > > > g...@github.com:abrodkin/linux.git tags/arcpgu-updates-2019.11.27 > > > > for you to fetch changes up to 9c2acc26c899aa12ad009dff10a5573ef769a7fd: > > > > DRM: ARC: PGU: add ARGB format to supported format list (2019-11-27 > > 16:43:39 +0300) > > > > > > Clean-up and fixes for FourCC handling in ARC PGU. > > > > > > Eugeniy Paltsev (4): > > DRM: ARC: PGU: fix framebuffer format switching > > DRM: ARC: PGU: cleanup supported format list code > > DRM: ARC: PGU: replace unsupported by HW RGB888 format by XRGB888 > > DRM: ARC: PGU: add ARGB format to supported format list > > > > drivers/gpu/drm/arc/arcpgu_crtc.c | 36 ++-- > > drivers/gpu/drm/arc/arcpgu_regs.h | 2 +- > > 2 files changed, 19 insertions(+), 19 deletions(-) Not sure if you noticed re-spin of my pull-request in the previous message. Do you want me to send it in a separate email? -Alexey ___ linux-snps-arc mailing list linux-snps-arc@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-snps-arc
Re: [GIT PULL] drm/arc: Yet another set of minor fixes
On Wed, Nov 27, 2019 at 2:49 PM Alexey Brodkin wrote: > > Hi Daniel, > > > -Original Message- > > From: Daniel Vetter > > Sent: Wednesday, November 27, 2019 1:07 PM > > To: Alexey Brodkin > > Cc: Daniel Vetter ; David Airlie ; arcml > > > a...@lists.infradead.org>; Eugeniy Paltsev ; > > dri-de...@lists.freedesktop.org > > Subject: Re: [GIT PULL] drm/arc: Yet another set of minor fixes > > > > On Wed, Nov 27, 2019 at 07:48:04AM +, Alexey Brodkin wrote: > > > Hi David, Daniel! > > > > > > The following changes since commit > > > 8082731830a0b95f7f7a63b78de67de446013c80: > > > > > > drm/vram: remove unused declaration (2019-11-27 07:51:49 +0100) > > > > > > are available in the Git repository at: > > > > > > g...@github.com:abrodkin/linux.git tags/arcpgu-updates-2019.11.27 > > > > > > for you to fetch changes up to b2c68fb15a4c2e27f80353d3067dce30882a0972: > > > > > > DRM: ARC: PGU: add ARGB format to supported format list (2019-11-27 > > > 10:38:24 +0300) > > > > > > > > > Clean-up and fixes for FourCC handling in ARC PGU. > > > > > > > > > Eugeniy Paltsev (4): > > > DRM: ARC: PGU: fix framebuffer format switching > > > DRM: ARC: PGU: cleanup supported format list code > > > DRM: ARC: PGU: replace unsupported by HW RGB888 format by XRGB888 > > > DRM: ARC: PGU: add ARGB format to supported format list > > > > Uh, this seems to be based on some random snapshot of drm-misc-next, so > > contains a _lot_ more than just these 4 patches (compared to drm-next). > > Indeed it's based off of today's "drm-misc-next". That's because I still get > lost when I have to deal with DRM trees which we have a plenty. > > I guess there should be a clean explanation of which repo and branch should be > used for which purpose, right? May I have a reference to it then? It's the same as for any other subsystem: - don't base your stuff on top of random other trees - except when you have a very specific excuse (i.e. functional conflict with stuff in drm-next or something like that), use a release tag from Linus' tree as your baseline And when generating the pull, actually generate the pull against the target tree/branch (drm-fixes or drm-next), not something else. -Daniel > > > If you want to move arcpgu to drm-misc (which would make tons of sense imo) > > Could you please elaborate a bit on this? Given we have a couple a patches if > at all for each kernel release I'd prefer to escape a need to use yet another > repo, tools etc as this doesn't simplify anything but instead makes simple > things much more complex (if done rarely). > > > then: > > - create a MAINTAINER patch to add drm-misc as the git repo for it > > - request your account for drm-misc, see > > https://www.freedesktop.org/wiki/AccountRequests/ > > - and set up the scripts > > https://drm.pages.freedesktop.org/maintainer-tools/getting-started.html > > Thanks for the pointers > > > Or respin this one, but these small pulls have a habit of occasionally > > getting lost :-/ > > Well I'd better re-spin this, see below. > > The following changes since commit acc61b8929365e63a3e8c8c8913177795aa45594: > > Merge tag 'drm-next-5.5-2019-11-22' of > git://people.freedesktop.org/~agd5f/linux into drm-next (2019-11-26 08:40:23 > +1000) > > are available in the Git repository at: > > g...@github.com:abrodkin/linux.git tags/arcpgu-updates-2019.11.27 > > for you to fetch changes up to 9c2acc26c899aa12ad009dff10a5573ef769a7fd: > > DRM: ARC: PGU: add ARGB format to supported format list (2019-11-27 > 16:43:39 +0300) > > > Clean-up and fixes for FourCC handling in ARC PGU. > > > Eugeniy Paltsev (4): > DRM: ARC: PGU: fix framebuffer format switching > DRM: ARC: PGU: cleanup supported format list code > DRM: ARC: PGU: replace unsupported by HW RGB888 format by XRGB888 > DRM: ARC: PGU: add ARGB format to supported format list > > drivers/gpu/drm/arc/arcpgu_crtc.c | 36 ++-- > drivers/gpu/drm/arc/arcpgu_regs.h | 2 +- > 2 files changed, 19 insertions(+), 19 deletions(-) > > -Alexey > -- Daniel Vetter Software Engineer, Intel Corporation +41 (0) 79 365 57 48 - http://blog.ffwll.ch ___ linux-snps-arc mailing list linux-snps-arc@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-snps-arc
RE: [GIT PULL] drm/arc: Yet another set of minor fixes
Hi Daniel, > -Original Message- > From: Daniel Vetter > Sent: Wednesday, November 27, 2019 1:07 PM > To: Alexey Brodkin > Cc: Daniel Vetter ; David Airlie ; arcml > a...@lists.infradead.org>; Eugeniy Paltsev ; > dri-de...@lists.freedesktop.org > Subject: Re: [GIT PULL] drm/arc: Yet another set of minor fixes > > On Wed, Nov 27, 2019 at 07:48:04AM +, Alexey Brodkin wrote: > > Hi David, Daniel! > > > > The following changes since commit 8082731830a0b95f7f7a63b78de67de446013c80: > > > > drm/vram: remove unused declaration (2019-11-27 07:51:49 +0100) > > > > are available in the Git repository at: > > > > g...@github.com:abrodkin/linux.git tags/arcpgu-updates-2019.11.27 > > > > for you to fetch changes up to b2c68fb15a4c2e27f80353d3067dce30882a0972: > > > > DRM: ARC: PGU: add ARGB format to supported format list (2019-11-27 > > 10:38:24 +0300) > > > > > > Clean-up and fixes for FourCC handling in ARC PGU. > > > > > > Eugeniy Paltsev (4): > > DRM: ARC: PGU: fix framebuffer format switching > > DRM: ARC: PGU: cleanup supported format list code > > DRM: ARC: PGU: replace unsupported by HW RGB888 format by XRGB888 > > DRM: ARC: PGU: add ARGB format to supported format list > > Uh, this seems to be based on some random snapshot of drm-misc-next, so > contains a _lot_ more than just these 4 patches (compared to drm-next). Indeed it's based off of today's "drm-misc-next". That's because I still get lost when I have to deal with DRM trees which we have a plenty. I guess there should be a clean explanation of which repo and branch should be used for which purpose, right? May I have a reference to it then? > If you want to move arcpgu to drm-misc (which would make tons of sense imo) Could you please elaborate a bit on this? Given we have a couple a patches if at all for each kernel release I'd prefer to escape a need to use yet another repo, tools etc as this doesn't simplify anything but instead makes simple things much more complex (if done rarely). > then: > - create a MAINTAINER patch to add drm-misc as the git repo for it > - request your account for drm-misc, see > https://www.freedesktop.org/wiki/AccountRequests/ > - and set up the scripts > https://drm.pages.freedesktop.org/maintainer-tools/getting-started.html Thanks for the pointers > Or respin this one, but these small pulls have a habit of occasionally > getting lost :-/ Well I'd better re-spin this, see below. The following changes since commit acc61b8929365e63a3e8c8c8913177795aa45594: Merge tag 'drm-next-5.5-2019-11-22' of git://people.freedesktop.org/~agd5f/linux into drm-next (2019-11-26 08:40:23 +1000) are available in the Git repository at: g...@github.com:abrodkin/linux.git tags/arcpgu-updates-2019.11.27 for you to fetch changes up to 9c2acc26c899aa12ad009dff10a5573ef769a7fd: DRM: ARC: PGU: add ARGB format to supported format list (2019-11-27 16:43:39 +0300) Clean-up and fixes for FourCC handling in ARC PGU. Eugeniy Paltsev (4): DRM: ARC: PGU: fix framebuffer format switching DRM: ARC: PGU: cleanup supported format list code DRM: ARC: PGU: replace unsupported by HW RGB888 format by XRGB888 DRM: ARC: PGU: add ARGB format to supported format list drivers/gpu/drm/arc/arcpgu_crtc.c | 36 ++-- drivers/gpu/drm/arc/arcpgu_regs.h | 2 +- 2 files changed, 19 insertions(+), 19 deletions(-) -Alexey ___ linux-snps-arc mailing list linux-snps-arc@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-snps-arc
Re: [GIT PULL] drm/arc: Yet another set of minor fixes
On Wed, Nov 27, 2019 at 07:48:04AM +, Alexey Brodkin wrote: > Hi David, Daniel! > > The following changes since commit 8082731830a0b95f7f7a63b78de67de446013c80: > > drm/vram: remove unused declaration (2019-11-27 07:51:49 +0100) > > are available in the Git repository at: > > g...@github.com:abrodkin/linux.git tags/arcpgu-updates-2019.11.27 > > for you to fetch changes up to b2c68fb15a4c2e27f80353d3067dce30882a0972: > > DRM: ARC: PGU: add ARGB format to supported format list (2019-11-27 > 10:38:24 +0300) > > > Clean-up and fixes for FourCC handling in ARC PGU. > > > Eugeniy Paltsev (4): > DRM: ARC: PGU: fix framebuffer format switching > DRM: ARC: PGU: cleanup supported format list code > DRM: ARC: PGU: replace unsupported by HW RGB888 format by XRGB888 > DRM: ARC: PGU: add ARGB format to supported format list Uh, this seems to be based on some random snapshot of drm-misc-next, so contains a _lot_ more than just these 4 patches (compared to drm-next). If you want to move arcpgu to drm-misc (which would make tons of sense imo) then: - create a MAINTAINER patch to add drm-misc as the git repo for it - request your account for drm-misc, see https://www.freedesktop.org/wiki/AccountRequests/ - and set up the scripts https://drm.pages.freedesktop.org/maintainer-tools/getting-started.html Or respin this one, but these small pulls have a habit of occasionally getting lost :-/ Cheers, Daniel > > drivers/gpu/drm/arc/arcpgu_crtc.c | 36 ++-- > drivers/gpu/drm/arc/arcpgu_regs.h | 2 +- > 2 files changed, 19 insertions(+), 19 deletions(-) > > Thanks, > Alexey -- Daniel Vetter Software Engineer, Intel Corporation http://blog.ffwll.ch ___ linux-snps-arc mailing list linux-snps-arc@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-snps-arc
[GIT PULL] drm/arc: Yet another set of minor fixes
Hi David, Daniel! The following changes since commit 8082731830a0b95f7f7a63b78de67de446013c80: drm/vram: remove unused declaration (2019-11-27 07:51:49 +0100) are available in the Git repository at: g...@github.com:abrodkin/linux.git tags/arcpgu-updates-2019.11.27 for you to fetch changes up to b2c68fb15a4c2e27f80353d3067dce30882a0972: DRM: ARC: PGU: add ARGB format to supported format list (2019-11-27 10:38:24 +0300) Clean-up and fixes for FourCC handling in ARC PGU. Eugeniy Paltsev (4): DRM: ARC: PGU: fix framebuffer format switching DRM: ARC: PGU: cleanup supported format list code DRM: ARC: PGU: replace unsupported by HW RGB888 format by XRGB888 DRM: ARC: PGU: add ARGB format to supported format list drivers/gpu/drm/arc/arcpgu_crtc.c | 36 ++-- drivers/gpu/drm/arc/arcpgu_regs.h | 2 +- 2 files changed, 19 insertions(+), 19 deletions(-) Thanks, Alexey ___ linux-snps-arc mailing list linux-snps-arc@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-snps-arc