Re: [PATCH 07/27] arc: TCG instruction definitions

2021-04-12 Thread Cupertino Miranda
Hi Richard, I totally understand your position with a new scripting language and the unclean code produced by the auto generated tools. In order to ease out the review process, I propose to drop the idea of the generated code and cleanup by hand all of the semfunc.c functions. What is you

Re: [PATCH 07/27] arc: TCG instruction definitions

2021-04-07 Thread Richard Henderson
On 4/5/21 7:31 AM, cupertinomira...@gmail.com wrote: +/* + * ADD + *Variables: @b, @c, @a + *Functions: getCCFlag, getFFlag, setZFlag, setNFlag, setCFlag, CarryADD, + * setVFlag, OverflowADD + * --- code --- + * { + * cc_flag = getCCFlag (); + * lb = @b; + * lc = @c;

Re: [PATCH 07/27] arc: TCG instruction definitions

2021-04-07 Thread Richard Henderson
On 4/5/21 7:31 AM, cupertinomira...@gmail.com wrote: +void arc_gen_verifyCCFlag(const DisasCtxt *ctx, TCGv ret) Why "verify"? I don't see anything that verifies here... I'll note that this can be done better, if you expose the actual comparison rather than a simple boolean. This could