Re: [PATCH 1/5] ARC: pt_regs: remove hardcoded registers offset

2019-12-28 Thread Vineet Gupta 
On 12/27/19 10:03 AM, Eugeniy Paltsev wrote:
> Replace hardcoded registers offset numbers by calculated via
> offsetof.
>
> Signed-off-by: Eugeniy Paltsev 

LGTM. This seems like an independent cleanup so added to for-curr

Thx,
-Vineet


___
linux-snps-arc mailing list
linux-snps-arc@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-snps-arc

[PATCH 1/5] ARC: pt_regs: remove hardcoded registers offset

2019-12-27 Thread Eugeniy Paltsev 
Replace hardcoded registers offset numbers by calculated via
offsetof.

Signed-off-by: Eugeniy Paltsev 
---
 arch/arc/include/asm/entry-arcv2.h | 8 
 arch/arc/kernel/asm-offsets.c  | 9 +
 2 files changed, 13 insertions(+), 4 deletions(-)

diff --git a/arch/arc/include/asm/entry-arcv2.h 
b/arch/arc/include/asm/entry-arcv2.h
index 41b16f21beec..0b8b63d0bec1 100644
--- a/arch/arc/include/asm/entry-arcv2.h
+++ b/arch/arc/include/asm/entry-arcv2.h
@@ -162,7 +162,7 @@
 #endif
 
 #ifdef CONFIG_ARC_HAS_ACCL_REGS
-   ST2 r58, r59, PT_sp + 12
+   ST2 r58, r59, PT_r58
 #endif
 
 .endm
@@ -172,8 +172,8 @@
 
LD2 gp, fp, PT_r26  ; gp (r26), fp (r27)
 
-   ld  r12, [sp, PT_sp + 4]
-   ld  r30, [sp, PT_sp + 8]
+   ld  r12, [sp, PT_r12]
+   ld  r30, [sp, PT_r30]
 
; Restore SP (into AUX_USER_SP) only if returning to U mode
;  - for K mode, it will be implicitly restored as stack is unwound
@@ -190,7 +190,7 @@
 #endif
 
 #ifdef CONFIG_ARC_HAS_ACCL_REGS
-   LD2 r58, r59, PT_sp + 12
+   LD2 r58, r59, PT_r58
 #endif
 .endm
 
diff --git a/arch/arc/kernel/asm-offsets.c b/arch/arc/kernel/asm-offsets.c
index 631ebb5d3458..c783bcd35eb8 100644
--- a/arch/arc/kernel/asm-offsets.c
+++ b/arch/arc/kernel/asm-offsets.c
@@ -67,5 +67,14 @@ int main(void)
DEFINE(SZ_CALLEE_REGS, sizeof(struct callee_regs));
DEFINE(SZ_PT_REGS, sizeof(struct pt_regs));
 
+#ifdef CONFIG_ISA_ARCV2
+   OFFSET(PT_r12, pt_regs, r12);
+   OFFSET(PT_r30, pt_regs, r30);
+#endif
+#ifdef CONFIG_ARC_HAS_ACCL_REGS
+   OFFSET(PT_r58, pt_regs, r58);
+   OFFSET(PT_r59, pt_regs, r59);
+#endif
+
return 0;
 }
-- 
2.21.0


___
linux-snps-arc mailing list
linux-snps-arc@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-snps-arc