Re: [PATCH 2/2] dmaengine: Add DW AXI DMAC driver

2017-02-09 Thread Vinod Koul
On Wed, Jan 25, 2017 at 06:34:17PM +0300, Eugeniy Paltsev wrote: > This patch adds support for the DW AXI DMAC controller. > > DW AXI DMAC is a part of upcoming development board from Synopsys. How different is AXI from DW Synopsys? Is the spec publicly available? > +config AXI_DW_DMAC > +

Re: [PATCH 2/2] dmaengine: Add DW AXI DMAC driver

2017-02-09 Thread Andy Shevchenko
On Thu, 2017-02-09 at 13:58 +, Eugeniy Paltsev wrote:    > > > +static void axi_desc_put(struct axi_dma_desc *desc) > > > +{ > > > + struct axi_dma_chan *chan = desc->chan; > > > + struct dw_axi_dma *dw = chan->chip->dw; > > > + struct axi_dma_desc *child, *_next; > > > + unsigned int

Re: [PATCH 2/2] dmaengine: Add DW AXI DMAC driver

2017-02-09 Thread Eugeniy Paltsev
Thanks for response. My comments are given inline below. On Wed, 2017-01-25 at 19:25 +0200, Andy Shevchenko wrote: > On Wed, 2017-01-25 at 18:34 +0300, Eugeniy Paltsev wrote: > >  > > This patch adds support for the DW AXI DMAC controller. > >  > > DW AXI DMAC is a part of upcoming development

Re: [PATCH 2/2] dmaengine: Add DW AXI DMAC driver

2017-01-25 Thread Andy Shevchenko
On Wed, 2017-01-25 at 18:34 +0300, Eugeniy Paltsev wrote: > This patch adds support for the DW AXI DMAC controller. > > DW AXI DMAC is a part of upcoming development board from Synopsys. > > In this driver implementation only DMA_MEMCPY and DMA_SG transfers > are supported. > Few more comments

Re: [PATCH 2/2] dmaengine: Add DW AXI DMAC driver

2017-01-25 Thread kbuild test robot
Hi Eugeniy, [auto build test ERROR on linus/master] [also build test ERROR on v4.10-rc5 next-20170125] [if your patch is applied to the wrong git tree, please drop us a note to help improve the system] url: