Re: [PATCH v3 9/9] asm-generic: reverse GENERIC_{STRNCPY_FROM,STRNLEN}_USER symbols

2021-07-26 Thread Helge Deller
On 7/22/21 2:48 PM, Arnd Bergmann wrote: From: Arnd Bergmann Most architectures do not need a custom implementation, and in most cases the generic implementation is preferred, so change the polariy on these Kconfig symbols to require architectures to select them when they provide their own

Re: [PATCH v3 9/9] asm-generic: reverse GENERIC_{STRNCPY_FROM, STRNLEN}_USER symbols

2021-07-24 Thread Geert Uytterhoeven
On Thu, Jul 22, 2021 at 2:50 PM Arnd Bergmann wrote: > From: Arnd Bergmann > > Most architectures do not need a custom implementation, and in most > cases the generic implementation is preferred, so change the polariy > on these Kconfig symbols to require architectures to select them when > they

Re: [PATCH v3 9/9] asm-generic: reverse GENERIC_{STRNCPY_FROM, STRNLEN}_USER symbols

2021-07-23 Thread Arnd Bergmann
On Thu, Jul 22, 2021 at 10:07 PM Heiko Carstens wrote: > > Feel free to add the s390 patch below on top of your series. Thanks a lot, added now. > However one question: the strncpy_from_user() prototype now comes everywhere > without the __must_check attribute. Is there any reason for that? > >

Re: [PATCH v3 9/9] asm-generic: reverse GENERIC_{STRNCPY_FROM, STRNLEN}_USER symbols

2021-07-22 Thread Heiko Carstens
On Thu, Jul 22, 2021 at 04:01:39PM +0200, Arnd Bergmann wrote: > On Thu, Jul 22, 2021 at 3:57 PM Johannes Berg > wrote: > > > > > > > > The remaining architectures at the moment are: ia64, mips, parisc, > > > s390, um and xtensa. We should probably convert these as well, but > > > > I'm not sure

Re: [PATCH v3 9/9] asm-generic: reverse GENERIC_{STRNCPY_FROM, STRNLEN}_USER symbols

2021-07-22 Thread Arnd Bergmann
On Thu, Jul 22, 2021 at 3:57 PM Johannes Berg wrote: > > > > > The remaining architectures at the moment are: ia64, mips, parisc, > > s390, um and xtensa. We should probably convert these as well, but > > I'm not sure it makes sense to convert um, the implementation uses > strncpy(), and that

Re: [PATCH v3 9/9] asm-generic: reverse GENERIC_{STRNCPY_FROM, STRNLEN}_USER symbols

2021-07-22 Thread Johannes Berg
> > The remaining architectures at the moment are: ia64, mips, parisc, > s390, um and xtensa. We should probably convert these as well, but I'm not sure it makes sense to convert um, the implementation uses strncpy(), and that should use the libc implementation, which is tuned for the actual

Re: [PATCH v3 9/9] asm-generic: reverse GENERIC_{STRNCPY_FROM,STRNLEN}_USER symbols

2021-07-22 Thread Christoph Hellwig
On Thu, Jul 22, 2021 at 02:48:14PM +0200, Arnd Bergmann wrote: > From: Arnd Bergmann > > Most architectures do not need a custom implementation, and in most > cases the generic implementation is preferred, so change the polariy > on these Kconfig symbols to require architectures to select them

[PATCH v3 9/9] asm-generic: reverse GENERIC_{STRNCPY_FROM, STRNLEN}_USER symbols

2021-07-22 Thread Arnd Bergmann
From: Arnd Bergmann Most architectures do not need a custom implementation, and in most cases the generic implementation is preferred, so change the polariy on these Kconfig symbols to require architectures to select them when they provide their own version. The new name is