Re: [PATCH v4] mmc: dw_mmc: Fix the DTO/CTO timeout overflow calculation for 32-bit systems

On 28 February 2018 at 12:53, Evgeniy Didin wrote: > In commit 9d9491a7da2a ("mmc: dw_mmc: Fix the DTO timeout calculation") and > commit 4c2357f57dd5 ("mmc: dw_mmc: Fix the CTO timeout calculation") > have been made changes which cause multiply overflow for 32-bit

Re: mmc: dw_mmc: DRTO interrupt cause driver switch to PIO mode

On 2018/3/1 0:11, Evgeniy Didin wrote: Hello everyone, We have made some research of how driver behaves in case when changes [1] are not applied. Here in [2] was metioned that while transfering data after interrupt has happend driver went to PIO mode, that is not expected. Here is log: |

Re: [PATCH v2 1/2] dmaengine: Introduce DW AXI DMAC driver

On Mon, 2018-02-26 at 18:42 +0200, Andy Shevchenko wrote: > On Mon, Feb 26, 2018 at 4:56 PM, Eugeniy Paltsev > wrote: > > > + chip->core_clk = devm_clk_get(chip->dev, "core-clk"); > > Does the name come from datasheet? > > > + chip->cfgr_clk =

Re: [PATCH v2 1/2] dmaengine: Introduce DW AXI DMAC driver

On Mon, 2018-02-26 at 18:42 +0200, Andy Shevchenko wrote: > On Mon, Feb 26, 2018 at 4:56 PM, Eugeniy Paltsev > wrote: > > +static int parse_device_properties(struct axi_dma_chip *chip) > > +{ > > + ret = device_property_read_u32(dev, "snps,dma-masters", ); > >

Re: [PATCH v2 2/2] dt-bindings: Document the Synopsys DW AXI DMA bindings

Hi Rob, On Mon, 2018-03-05 at 15:07 -0600, Rob Herring wrote: > On Mon, Mar 05, 2018 at 11:02:56AM +0530, Vinod Koul wrote: > > On Fri, Mar 02, 2018 at 08:32:20AM +, Alexey Brodkin wrote: > > > Hi Vinod, > > > > > > On Fri, 2018-03-02 at 13:44 +0530, Vinod Koul wrote: > > > > On Mon, Feb 26,

Re: [PATCH v2 2/2] dt-bindings: Document the Synopsys DW AXI DMA bindings

On Mon, Mar 05, 2018 at 11:02:56AM +0530, Vinod Koul wrote: > On Fri, Mar 02, 2018 at 08:32:20AM +, Alexey Brodkin wrote: > > Hi Vinod, > > > > On Fri, 2018-03-02 at 13:44 +0530, Vinod Koul wrote: > > > On Mon, Feb 26, 2018 at 05:56:28PM +0300, Eugeniy Paltsev wrote: > > > > This patch adds

Re: [PATCH 1/2 v3] mmc: dw_mmc: Fix the DTO timeout overflow calculation for 32-bit systems

Tested-by: Vineet Gupta Fixes: ARC STAR 9001306872 HSDK, sdio: board crashes when copying big files Signed-off-by: Evgeniy Didin CC: Alexey Brodkin CC: Eugeniy Paltsev CC: Douglas Anderson

Re: [PATCH v4] mmc: dw_mmc: Fix the DTO/CTO timeout overflow calculation for 32-bit systems

[+ Jaehoon] On 2018/2/28 19:53, Evgeniy Didin wrote: In commit 9d9491a7da2a ("mmc: dw_mmc: Fix the DTO timeout calculation") and commit 4c2357f57dd5 ("mmc: dw_mmc: Fix the CTO timeout calculation") have been made changes which cause multiply overflow for 32-bit systems. The broken timeout

Re: [PATCH 1/2 v3] mmc: dw_mmc: Fix the DTO timeout overflow calculation for 32-bit systems

#define DIV_ROUND_DOWN_ULL(ll, d) \ ({ unsigned long long _tmp = (ll); do_div(_tmp, d); _tmp; }) #define DIV_ROUND_UP_ULL(ll, d)    DIV_ROUND_DOWN_ULL((ll) + (d) - 1, (d)) It uses intermediate unsigned long long _tmp for your "multiply", namely MSEC_PER_SEC * drto_clks *