Re: [PATCH 0/3] move __HAVE_ARCH_PTE_SPECIAL in Kconfig
On 09/04/2018 18:03, Vineet Gupta wrote: > On 04/09/2018 06:57 AM, Laurent Dufour wrote: >> The per architecture __HAVE_ARCH_PTE_SPECIAL is defined statically in the >> per architecture header files. This doesn't allow to make other >> configuration dependent on it. > > So I understand this series has more "readability" value and I'm fine with > this > change but I wonder if you really would want to make something depend on it or > make this de-configurable. PTE special is really a fundamental construct - > e.g. > it is used for anon mapped pages where zero page has been wired up etc... I don't want it to be de-configurable. This is almost like ARCH_SUPPORTS_MEMORY_FAILURE, ARCH_USES_HIGH_VMA_FLAGS, ARCH_HAS_HMM... These values are selected by per architecture Kconfig files and are not exposed through the configuration menu. Concerning making something depend on it, I will probably make CONFIG_SPECULATIVE_PAGE_FAULT introduced by the SPF series dependent on it. For details, please see https://lkml.org/lkml/2018/3/13/1143 Thanks, Laurent. ___ linux-snps-arc mailing list linux-snps-arc@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-snps-arc
Re: [PATCH 0/3] move __HAVE_ARCH_PTE_SPECIAL in Kconfig
On 04/09/2018 06:57 AM, Laurent Dufour wrote: The per architecture __HAVE_ARCH_PTE_SPECIAL is defined statically in the per architecture header files. This doesn't allow to make other configuration dependent on it. So I understand this series has more "readability" value and I'm fine with this change but I wonder if you really would want to make something depend on it or make this de-configurable. PTE special is really a fundamental construct - e.g. it is used for anon mapped pages where zero page has been wired up etc... -Vineet This series is moving the __HAVE_ARCH_PTE_SPECIAL into the Kconfig files, setting it automatically when architectures was already setting it in header file. There is no functional change introduced by this series. ___ linux-snps-arc mailing list linux-snps-arc@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-snps-arc
Re: [PATCH 0/3] move __HAVE_ARCH_PTE_SPECIAL in Kconfig
On Mon, Apr 09, 2018 at 04:07:21PM +0200, Michal Hocko wrote: > On Mon 09-04-18 15:57:06, Laurent Dufour wrote: > > The per architecture __HAVE_ARCH_PTE_SPECIAL is defined statically in the > > per architecture header files. This doesn't allow to make other > > configuration dependent on it. > > > > This series is moving the __HAVE_ARCH_PTE_SPECIAL into the Kconfig files, > > setting it automatically when architectures was already setting it in > > header file. > > > > There is no functional change introduced by this series. > > I would just fold all three patches into a single one. It is much easier > to review that those selects are done properly when you can see that the > define is set for the same architecture. > > In general, I like the patch. It is always quite painful to track per > arch defines. You can also add Reviewed-by: Jérôme Glisse my grep fu showed no place that was forgotten. Cheers, Jérôme ___ linux-snps-arc mailing list linux-snps-arc@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-snps-arc
Re: [PATCH 0/3] move __HAVE_ARCH_PTE_SPECIAL in Kconfig
On Mon 09-04-18 15:57:06, Laurent Dufour wrote: > The per architecture __HAVE_ARCH_PTE_SPECIAL is defined statically in the > per architecture header files. This doesn't allow to make other > configuration dependent on it. > > This series is moving the __HAVE_ARCH_PTE_SPECIAL into the Kconfig files, > setting it automatically when architectures was already setting it in > header file. > > There is no functional change introduced by this series. I would just fold all three patches into a single one. It is much easier to review that those selects are done properly when you can see that the define is set for the same architecture. In general, I like the patch. It is always quite painful to track per arch defines. > Laurent Dufour (3): > mm: introduce ARCH_HAS_PTE_SPECIAL > mm: replace __HAVE_ARCH_PTE_SPECIAL > mm: remove __HAVE_ARCH_PTE_SPECIAL > > Documentation/features/vm/pte_special/arch-support.txt | 2 +- > arch/arc/Kconfig | 1 + > arch/arc/include/asm/pgtable.h | 2 -- > arch/arm/Kconfig | 1 + > arch/arm/include/asm/pgtable-3level.h | 1 - > arch/arm64/Kconfig | 1 + > arch/arm64/include/asm/pgtable.h | 2 -- > arch/powerpc/Kconfig | 1 + > arch/powerpc/include/asm/book3s/64/pgtable.h | 3 --- > arch/powerpc/include/asm/pte-common.h | 3 --- > arch/riscv/Kconfig | 1 + > arch/s390/Kconfig | 1 + > arch/s390/include/asm/pgtable.h| 1 - > arch/sh/Kconfig| 1 + > arch/sh/include/asm/pgtable.h | 2 -- > arch/sparc/Kconfig | 1 + > arch/sparc/include/asm/pgtable_64.h| 3 --- > arch/x86/Kconfig | 1 + > arch/x86/include/asm/pgtable_types.h | 1 - > include/linux/pfn_t.h | 4 ++-- > mm/Kconfig | 3 +++ > mm/gup.c | 4 ++-- > mm/memory.c| 2 +- > 23 files changed, 18 insertions(+), 24 deletions(-) > > -- > 2.7.4 -- Michal Hocko SUSE Labs ___ linux-snps-arc mailing list linux-snps-arc@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-snps-arc