Re: [PATCH 10/22] microblaze: include linux/cpu.h for trap_init() prototype
Hi Arnd, On Wed, Nov 8, 2023 at 10:07 PM Arnd Bergmann wrote: > On Wed, Nov 8, 2023, at 21:42, Geert Uytterhoeven wrote: > > On Wed, Nov 8, 2023 at 2:01 PM Arnd Bergmann wrote: > >> From: Arnd Bergmann > >> > >> Microblaze runs into a single -Wmissing-prototypes warning when that is > >> enabled: > >> > >> arch/microblaze/kernel/traps.c:21:6: warning: no previous prototype for > >> 'trap_init' [-Wmissing-prototypes] > >> > >> Include the right header to avoid this. > >> > >> Signed-off-by: Arnd Bergmann > > > > Thanks for your patch! > > > >> arch/alpha/kernel/traps.c | 1 + > >> arch/csky/include/asm/traps.h | 2 -- > >> arch/csky/kernel/traps.c | 1 + > >> arch/m68k/coldfire/vectors.c | 3 +-- > >> arch/m68k/coldfire/vectors.h | 3 --- > > > > Ah, so this is where the m68k changes listed in the cover letter are > > hiding ;-) > > > >> arch/microblaze/kernel/traps.c | 1 + > >> arch/sparc/kernel/traps_32.c | 1 + > >> arch/sparc/kernel/traps_64.c | 1 + > >> arch/x86/include/asm/traps.h | 1 - > >> arch/x86/kernel/traps.c| 1 + > >> 10 files changed, 7 insertions(+), 8 deletions(-) > >> delete mode 100644 arch/m68k/coldfire/vectors.h > > > > Obviously the non-microblaze changes should be spun off in separate > > patches. > > I messed up one of my rebases here and accidentally sent > the wrong changelog text. My intention was to have the > combined patch but with this text: > > arch: include linux/cpu.h for trap_init() prototype > > some architectures run into a -Wmissing-prototypes warning > for trap_init() > > arch/microblaze/kernel/traps.c:21:6: warning: no previous prototype for > 'trap_init' [-Wmissing-prototypes] > > Include the right header to avoid this consistently, removing > the extra declarations on m68k and x86 that were added as local > workarounds already. > > Signed-off-by: Arnd Bergmann That makes sense, although it's hard to combine this with "my preference would be for the patches to make it through the respective subsystem maintainer trees"... Gr{oetje,eeting}s, Geert -- Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- ge...@linux-m68k.org In personal conversations with technical people, I call myself a hacker. But when I'm talking to journalists I just say "programmer" or something like that. -- Linus Torvalds ___ linux-snps-arc mailing list linux-snps-arc@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-snps-arc
Re: [PATCH 10/22] microblaze: include linux/cpu.h for trap_init() prototype
On Wed, Nov 8, 2023, at 21:42, Geert Uytterhoeven wrote: > > On Wed, Nov 8, 2023 at 2:01 PM Arnd Bergmann wrote: >> From: Arnd Bergmann >> >> Microblaze runs into a single -Wmissing-prototypes warning when that is >> enabled: >> >> arch/microblaze/kernel/traps.c:21:6: warning: no previous prototype for >> 'trap_init' [-Wmissing-prototypes] >> >> Include the right header to avoid this. >> >> Signed-off-by: Arnd Bergmann > > Thanks for your patch! > >> arch/alpha/kernel/traps.c | 1 + >> arch/csky/include/asm/traps.h | 2 -- >> arch/csky/kernel/traps.c | 1 + >> arch/m68k/coldfire/vectors.c | 3 +-- >> arch/m68k/coldfire/vectors.h | 3 --- > > Ah, so this is where the m68k changes listed in the cover letter are > hiding ;-) > >> arch/microblaze/kernel/traps.c | 1 + >> arch/sparc/kernel/traps_32.c | 1 + >> arch/sparc/kernel/traps_64.c | 1 + >> arch/x86/include/asm/traps.h | 1 - >> arch/x86/kernel/traps.c| 1 + >> 10 files changed, 7 insertions(+), 8 deletions(-) >> delete mode 100644 arch/m68k/coldfire/vectors.h > > Obviously the non-microblaze changes should be spun off in separate > patches. I messed up one of my rebases here and accidentally sent the wrong changelog text. My intention was to have the combined patch but with this text: arch: include linux/cpu.h for trap_init() prototype some architectures run into a -Wmissing-prototypes warning for trap_init() arch/microblaze/kernel/traps.c:21:6: warning: no previous prototype for 'trap_init' [-Wmissing-prototypes] Include the right header to avoid this consistently, removing the extra declarations on m68k and x86 that were added as local workarounds already. Signed-off-by: Arnd Bergmann I made the same mistake with the "arch: add do_page_fault prototypes" patch that was missing an explanation. Arnd ___ linux-snps-arc mailing list linux-snps-arc@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-snps-arc
Re: [PATCH 10/22] microblaze: include linux/cpu.h for trap_init() prototype
Hi Arnd, On Wed, Nov 8, 2023 at 2:01 PM Arnd Bergmann wrote: > From: Arnd Bergmann > > Microblaze runs into a single -Wmissing-prototypes warning when that is > enabled: > > arch/microblaze/kernel/traps.c:21:6: warning: no previous prototype for > 'trap_init' [-Wmissing-prototypes] > > Include the right header to avoid this. > > Signed-off-by: Arnd Bergmann Thanks for your patch! > arch/alpha/kernel/traps.c | 1 + > arch/csky/include/asm/traps.h | 2 -- > arch/csky/kernel/traps.c | 1 + > arch/m68k/coldfire/vectors.c | 3 +-- > arch/m68k/coldfire/vectors.h | 3 --- Ah, so this is where the m68k changes listed in the cover letter are hiding ;-) > arch/microblaze/kernel/traps.c | 1 + > arch/sparc/kernel/traps_32.c | 1 + > arch/sparc/kernel/traps_64.c | 1 + > arch/x86/include/asm/traps.h | 1 - > arch/x86/kernel/traps.c| 1 + > 10 files changed, 7 insertions(+), 8 deletions(-) > delete mode 100644 arch/m68k/coldfire/vectors.h Obviously the non-microblaze changes should be spun off in separate patches. Gr{oetje,eeting}s, Geert -- Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- ge...@linux-m68k.org In personal conversations with technical people, I call myself a hacker. But when I'm talking to journalists I just say "programmer" or something like that. -- Linus Torvalds ___ linux-snps-arc mailing list linux-snps-arc@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-snps-arc