Re: [PATCH 4/5] aarch/fpu: use generic sqrt, fma functions

2020-06-02 Thread Joseph Myers
On Mon, 1 Jun 2020, Vineet Gupta via Libc-alpha wrote: > Also I don't understand one thing. Both the generic and aarch64 code have this > > float > __rintf (float x) > ... > libm_alias_float (__rint, rint) > > The alias arg 1 __rint seems to lack suffix 'f' ? Please see the comments in

Re: [PATCH 4/5] aarch/fpu: use generic sqrt, fma functions

2020-06-01 Thread Ramana Radhakrishnan
On Mon, Jun 1, 2020 at 10:45 PM Vineet Gupta via Libc-alpha wrote: > > On 6/1/20 9:38 AM, Adhemerval Zanella via Libc-alpha wrote: > > > > > > On 29/05/2020 23:00, Vineet Gupta wrote: > >> Signed-off-by: Vineet Gupta > > > > LGTM, some comments below. > > > >> -#include > >> -#include > >> - >

Re: [PATCH 4/5] aarch/fpu: use generic sqrt, fma functions

2020-06-01 Thread Vineet Gupta
On 6/1/20 9:38 AM, Adhemerval Zanella via Libc-alpha wrote: > > > On 29/05/2020 23:00, Vineet Gupta wrote: >> Signed-off-by: Vineet Gupta > > LGTM, some comments below. > >> -#include >> -#include >> - >> -double >> -__ieee754_sqrt (double d) >> -{ >> - return __builtin_sqrt (d); >> -} >>

Re: [PATCH 4/5] aarch/fpu: use generic sqrt, fma functions

2020-06-01 Thread Adhemerval Zanella
On 29/05/2020 23:00, Vineet Gupta wrote: > Signed-off-by: Vineet Gupta LGTM, some comments below. > --- > sysdeps/aarch64/fpu/e_sqrt.c| 27 -- > sysdeps/aarch64/fpu/e_sqrtf.c | 27 -- > sysdeps/aarch64/fpu/math-use-builtins.h | 70