Re: [PATCH v2 1/4] iee754: provide gcc builtins based generic sqrt functions

2020-06-02 Thread Adhemerval Zanella
On 01/06/2020 21:35, Vineet Gupta wrote: > Reviewed-by: Adhemerval Zanella LGTM with the small nit below and the s390 fix pointed by Stefan. Reviewed-by: Adhemerval Zanella > --- > sysdeps/generic/math-use-builtins.h | 3 +++ > sysdeps/ieee754/dbl-64/e_sqrt.c | 6 ++ >

Re: [PATCH v2 1/4] iee754: provide gcc builtins based generic sqrt functions

2020-06-02 Thread Vineet Gupta
On 6/2/20 5:51 AM, Stefan Liebler via Libc-alpha wrote: > On 6/2/20 2:35 AM, Vineet Gupta via Libc-alpha wrote: >> Reviewed-by: Adhemerval Zanella >> --- >> sysdeps/generic/math-use-builtins.h | 3 +++ >> sysdeps/ieee754/dbl-64/e_sqrt.c | 6 ++ >> sysdeps/ieee754/flt-32/e_sqrtf.c|