[linux-sunxi] Re: [PATCH 1/4] power: supply: axp20x_battery: add support for DT battery

2017-05-15 Thread Chen-Yu Tsai
On Thu, May 11, 2017 at 9:42 PM, Quentin Schulz wrote: > This adds support in X-Powers AXP20X and AXP22X battery driver for a > fixed battery in DT. > > It will take the minimum supported voltage by the battery as defined in > the battery DT node and set the

[linux-sunxi] Re: [PATCH 2/4] dt-bindings: power: battery: add constant-charge-current-max-microamp property

2017-05-15 Thread Rob Herring
On Thu, May 11, 2017 at 03:42:18PM +0200, Quentin Schulz wrote: > This adds the constant-charge-current-max-microamp property to the list > of optional properties of the battery. > > The constant charge current is critical for batteries as they can't > handle all charge currents. > >

[linux-sunxi] Re: [PATCH 1/2] devicetree: add Itead vendor prefix

2017-05-15 Thread Rob Herring
On Wed, May 10, 2017 at 12:31:02PM +, codekip...@gmail.com wrote: > From: Marcus Cooper > > Add the "itead" vendor prefix for ITEAD Intelligent Systems Co.Ltd. > > Signed-off-by: Marcus Cooper > --- >

Re: [linux-sunxi] Re: [PATCH 3/3] sunxi: video: Add H3/H5 TV out driver

2017-05-15 Thread Jernej Škrabec
Hi, Dne ponedeljek, 15. maj 2017 ob 08:31:22 CEST je Maxime Ripard napisal(a): > On Sat, May 13, 2017 at 11:14:00PM +0800, Chen-Yu Tsai wrote: > > >>> +static int sunxi_tve_get_plug_in_status(void) > > >>> +{ > > >>> + struct sunxi_tve_reg * const tve = > > >>> + (struct

[linux-sunxi] Re: [PATCH 3/3] sunxi: video: Add H3/H5 TV out driver

2017-05-15 Thread Simon Glass
Hi Maxime, On 15 May 2017 at 00:11, Maxime Ripard wrote: > On Sun, May 14, 2017 at 09:03:19PM -0600, Simon Glass wrote: >> Hi, >> >> On 12 May 2017 at 10:06, Maxime Ripard >> wrote: >> > Hi Jernej, >> > >> > The patch content

[linux-sunxi] Re: [PATCH 3/3] sunxi: video: Add H3/H5 TV out driver

2017-05-15 Thread Jernej Škrabec
Hi, Dne ponedeljek, 15. maj 2017 ob 08:11:55 CEST je Maxime Ripard napisal(a): > On Sun, May 14, 2017 at 09:03:19PM -0600, Simon Glass wrote: > > Hi, > > > > On 12 May 2017 at 10:06, Maxime Ripard wrote: > > > Hi Jernej, > > > > > > The patch content looks

[linux-sunxi] Re: [U-Boot] [PATCHv6 14/28] net: cosmetic: A MAC address is not limited to SROM

2017-05-15 Thread Olliver Schinagl
Hey Tom, On 15-05-17 14:53, Tom Rini wrote: On Mon, May 15, 2017 at 10:02:30AM +0200, Olliver Schinagl wrote: Currently, we print that the MAC from the SROM does not match. It can be many forms of ROM, so lets drop the S. Signed-off-by: Olliver Schinagl ---

[linux-sunxi] Re: [U-Boot] [PATCHv6 11/28] net: core: Add MAC address helper functions

2017-05-15 Thread Tom Rini
On Mon, May 15, 2017 at 10:02:27AM +0200, Olliver Schinagl wrote: > Universally administered and locally administered addresses are > distinguished by setting the second-least-significant bit of the first > octet of the address. Having a function to check and set this U/L bit > from a function

[linux-sunxi] Re: [U-Boot] [PATCHv6 14/28] net: cosmetic: A MAC address is not limited to SROM

2017-05-15 Thread Tom Rini
On Mon, May 15, 2017 at 10:02:30AM +0200, Olliver Schinagl wrote: > Currently, we print that the MAC from the SROM does not match. It can be > many forms of ROM, so lets drop the S. > > Signed-off-by: Olliver Schinagl > --- > net/eth_legacy.c | 2 +- > 1 file changed, 1

[linux-sunxi] Re: [U-Boot] [PATCHv6 09/28] net: core: Sanitize get/set operations for enetaddr

2017-05-15 Thread Tom Rini
On Mon, May 15, 2017 at 10:02:25AM +0200, Olliver Schinagl wrote: > In the current net stack, we have a few functions to get and set > the "ethaddr" and "ethNaddr" environment variables, which use magic > values to get and set these environment variables. Remove the magicness > of the buffer by

[linux-sunxi] Re: [U-Boot] [PATCHv6 15/28] net: core: Check return value of read_rom_hwaddr

2017-05-15 Thread Tom Rini
On Mon, May 15, 2017 at 10:02:31AM +0200, Olliver Schinagl wrote: > Currently, we silently ignore the return value of netops->read_rom_hwaddr(). > This naturally is bad and we should check if the code ran successfully. > > Signed-off-by: Olliver Schinagl Reviewed-by: Tom

[linux-sunxi] Re: [U-Boot] [PATCHv6 08/28] net: cosmetic: Do not use magic values for ARP_HLEN

2017-05-15 Thread Tom Rini
On Mon, May 15, 2017 at 10:02:24AM +0200, Olliver Schinagl wrote: > Previously overlooked magic value in commit a40db6d51171 ("net: cosmetic: Do > not use magic values for ARP_HLEN") > > Signed-off-by: Olliver Schinagl Reviewed-by: Tom Rini -- Tom --

[linux-sunxi] Re: [U-Boot] [PATCHv6 03/28] net: core: Add PHY_GIGE as a Kconfig symbol

2017-05-15 Thread Tom Rini
On Mon, May 15, 2017 at 10:02:19AM +0200, Olliver Schinagl wrote: > Add the CONFIG_PHY_GIGE option as a hidden Kconfig symbol so that we > can select it from the menu as a dependency. > > Signed-off-by: Olliver Schinagl Reviewed-by: Tom Rini -- Tom

[linux-sunxi] Re: [PATCHv6 25/28] net: sun7i_mac: Add read_rom_hwaddr hook

2017-05-15 Thread Olliver Schinagl
Hey Maxime, On 15-05-17 10:22, Maxime Ripard wrote: On Mon, May 15, 2017 at 10:02:41AM +0200, Olliver Schinagl wrote: With this patch sun7i_mac can now get the MAC address from the board in a predetermined board specific manner. Signed-off-by: Olliver Schinagl ---

[linux-sunxi] Re: A20 - Get temperature and Serial

2017-05-15 Thread Milos Ladni
Hi, 1 - As far as i know A20 does not have temperature sensor that is user readable. 2 - I am not sure which PMU you are using but i suppose that it is axp209. It only have over temperature protection. But i am not sure, it has support for battery temperature monitoring but i have not used so

Re: [linux-sunxi] Re: [PATCH v7 05/13] drm/sun4i: abstract a engine type

2017-05-15 Thread Icenowy Zheng
于 2017年5月15日 GMT+08:00 下午5:20:01, Maxime Ripard 写到: >On Mon, May 15, 2017 at 12:30:37AM +0800, Icenowy Zheng wrote: >> As we are going to add support for the Allwinner DE2 engine in >sun4i-drm >> driver, we will finally have two types of display engines -- the

[linux-sunxi] Re: [PATCH v7 05/13] drm/sun4i: abstract a engine type

2017-05-15 Thread Maxime Ripard
On Mon, May 15, 2017 at 12:30:37AM +0800, Icenowy Zheng wrote: > As we are going to add support for the Allwinner DE2 engine in sun4i-drm > driver, we will finally have two types of display engines -- the DE1 > backend and the DE2 mixer. They both do some display blending and feed > graphics data

[linux-sunxi] Re: [PATCH] iio: adc: sun4i-gpadc-iio: fix parent device being used in devm function

2017-05-15 Thread Quentin Schulz
Hi Maxime, On 15/05/2017 11:11, Maxime Ripard wrote: > On Mon, May 15, 2017 at 09:39:02AM +0200, Quentin Schulz wrote: >> For the sake of DT binding stability, this IIO driver is a child of an >> MFD driver for Allwinner A10, A13 and A31 because there already exists a >> DT binding for this IP.

[linux-sunxi] Re: [PATCH 4/4] ARM: sun8i: v3s: add support for Lichee Pi Zero w/ dock board

2017-05-15 Thread Maxime Ripard
On Mon, May 15, 2017 at 04:40:01PM +0800, Icenowy Zheng wrote: > The Lichee Pi Zero board has a "dock board" which needs to be soldered > with the 1.27mm stamp holes on a Lichee Pi Zero board. > > It features: > - Onboard MIC and headphone jack (not supported yet) > - Ethernet port (not supported

[linux-sunxi] Re: [PATCH v7 01/13] dt-bindings: add binding for the Allwinner DE2 CCU

2017-05-15 Thread Maxime Ripard
On Mon, May 15, 2017 at 12:30:33AM +0800, Icenowy Zheng wrote: > Allwinner "Display Engine 2.0" contains some clock controls in it. > > In order to add them as clock drivers, we need a device tree binding. > Add the binding here. > > Also add the device tree binding headers. > > Signed-off-by:

[linux-sunxi] [PATCH 1/4] ARM: sun8i: v3s: restore the usage of CCU definitions

2017-05-15 Thread Icenowy Zheng
All the used CCU definitions are stripped from the V3s DTSI file when it's merged, as the DTSI file and the CCU device tree binding headers went to different trees. As they're all in Linus's tree now, restore the usage of the definitions. Signed-off-by: Icenowy Zheng ---

[linux-sunxi] [PATCH 4/4] ARM: sun8i: v3s: add support for Lichee Pi Zero w/ dock board

2017-05-15 Thread Icenowy Zheng
The Lichee Pi Zero board has a "dock board" which needs to be soldered with the 1.27mm stamp holes on a Lichee Pi Zero board. It features: - Onboard MIC and headphone jack (not supported yet) - Ethernet port (not supported yet) - An extra MicroSD slot connected to MMC1 controller - four keys

[linux-sunxi] [PATCH 2/4] ARM: sun8i: v3s: add LRADC device node

2017-05-15 Thread Icenowy Zheng
Allwinner V3s features a LRADC like the ones in older SoCs. Add a device tree node for it. Signed-off-by: Icenowy Zheng --- arch/arm/boot/dts/sun8i-v3s.dtsi | 7 +++ 1 file changed, 7 insertions(+) diff --git a/arch/arm/boot/dts/sun8i-v3s.dtsi

[linux-sunxi] Re: [PATCH v7 02/13] clk: sunxi-ng: add support for DE2 CCU

2017-05-15 Thread Maxime Ripard
On Mon, May 15, 2017 at 12:30:34AM +0800, Icenowy Zheng wrote: > The "Display Engine 2.0" in Allwinner newer SoCs contains a clock > management unit for its subunits, like the DE CCU in A80. > > Add a sunxi-ng style driver for it. > > Signed-off-by: Icenowy Zheng Applied,

[linux-sunxi] Re: [PATCHv6 23/28] net: sun7i_mac: Make the sun7i a dw driver subclass

2017-05-15 Thread Maxime Ripard
On Mon, May 15, 2017 at 10:02:39AM +0200, Olliver Schinagl wrote: > This patch removes the old sunxi_gmac glue layer and turns it into a > proper sub-class driver. And renames it. Please split that into two patches. > Signed-off-by: Olliver Schinagl > --- >

[linux-sunxi] Re: [PATCHv6 25/28] net: sun7i_mac: Add read_rom_hwaddr hook

2017-05-15 Thread Maxime Ripard
On Mon, May 15, 2017 at 10:02:41AM +0200, Olliver Schinagl wrote: > With this patch sun7i_mac can now get the MAC address from the board in > a predetermined board specific manner. > > Signed-off-by: Olliver Schinagl > --- > drivers/net/Makefile| 2 +- >

[linux-sunxi] Re: [PATCHv6 12/28] net: Add ability to set MAC address via EEPROM

2017-05-15 Thread Maxime Ripard
On Mon, May 15, 2017 at 10:02:28AM +0200, Olliver Schinagl wrote: > This patch allows Kconfig to enable and set parameters to make it > possible to read the MAC address from an EEPROM. The net core layer then > uses this information to read MAC addresses from this EEPROM. > > Besides the various

[linux-sunxi] Re: [PATCHv6 04/28] net: sunxi simplify defconfig

2017-05-15 Thread Maxime Ripard
On Mon, May 15, 2017 at 10:02:20AM +0200, Olliver Schinagl wrote: > We currently have a few dependencies explicitly set in the sunxi > defconfigs. Things such as, RGMII, DESIGNWARE_ETH in combination with > SUN7I_GMAC. When selecting SUN7I_GMAC we already imply DESIGNWARE_ETH > for example. > >

[linux-sunxi] Re: [PATCHv6 00/28] Retrieve MAC address from EEPROM

2017-05-15 Thread Olliver Schinagl
Hey all, On 15-05-17 10:02, Olliver Schinagl wrote: This patch-series introduces methods to retrieve the MAC address from an onboard EEPROM. The series does a few small cleanups at the start, as either I ran into them while doing this series and fixed them along the way or actually depended on

[linux-sunxi] [PATCHv6 17/28] fdt: fixup_eth: improve error catching/reduce identation

2017-05-15 Thread Olliver Schinagl
Currently when checking for an error in ethernet aliases in the fdt, we only check for the error case -1. It is safer to ignore anything < 0. By rearranging logic a bit we can now also reduce identation. Signed-off-by: Olliver Schinagl --- common/fdt_support.c | 20

[linux-sunxi] [PATCHv6 16/28] fdt: fixup_eth: Remove code duplication with a function

2017-05-15 Thread Olliver Schinagl
In fdt_support.c we use a loop to parse the mac address string from the fdt blob, net.h has a function for this however, so lets use it. Also, rename the variable from tmp to something more descriptive. Signed-off-by: Olliver Schinagl --- common/fdt_support.c | 15

[linux-sunxi] [PATCHv6 27/28] net: sun8i: fix whitespace

2017-05-15 Thread Olliver Schinagl
Fix a few whitespaces errors in the sun8i driver. Signed-off-by: Olliver Schinagl --- drivers/net/Kconfig | 8 drivers/net/sun8i_emac.c | 12 ++-- 2 files changed, 10 insertions(+), 10 deletions(-) diff --git a/drivers/net/Kconfig

[linux-sunxi] [PATCHv6 23/28] net: sun7i_mac: Make the sun7i a dw driver subclass

2017-05-15 Thread Olliver Schinagl
This patch removes the old sunxi_gmac glue layer and turns it into a proper sub-class driver. Signed-off-by: Olliver Schinagl --- arch/arm/mach-sunxi/board.c | 1 - board/sunxi/Makefile | 1 - drivers/net/Makefile

[linux-sunxi] [PATCHv6 26/28] net: sun8i_gmac: Add read_rom_hwaddr hook

2017-05-15 Thread Olliver Schinagl
With this patch sun8i_emac can now get the MAC address from the board in a predetermined board specific manner. Signed-off-by: Olliver Schinagl --- drivers/net/Makefile | 2 +- drivers/net/sun8i_emac.c | 3 +++ 2 files changed, 4 insertions(+), 1 deletion(-) diff --git

[linux-sunxi] [PATCHv6 22/28] net: sun4i_mac: Add read_rom_hwaddr hook

2017-05-15 Thread Olliver Schinagl
With this patch sun4i_mac can now get the MAC address from the board in a predetermined board specific manner. Signed-off-by: Olliver Schinagl --- drivers/net/Makefile| 2 +- drivers/net/sun4i_mac.c | 3 +++ 2 files changed, 4 insertions(+), 1 deletion(-) diff --git

[linux-sunxi] [PATCHv6 09/28] net: core: Sanitize get/set operations for enetaddr

2017-05-15 Thread Olliver Schinagl
In the current net stack, we have a few functions to get and set the "ethaddr" and "ethNaddr" environment variables, which use magic values to get and set these environment variables. Remove the magicness of the buffer by defining it proper and also check the input for its length. Additionally

[linux-sunxi] [PATCHv6 04/28] net: sunxi simplify defconfig

2017-05-15 Thread Olliver Schinagl
We currently have a few dependencies explicitly set in the sunxi defconfigs. Things such as, RGMII, DESIGNWARE_ETH in combination with SUN7I_GMAC. When selecting SUN7I_GMAC we already imply DESIGNWARE_ETH for example. This patch puts this logic into the Kconfig thus simplifying the defconfigs.

[linux-sunxi] [PATCHv6 12/28] net: Add ability to set MAC address via EEPROM

2017-05-15 Thread Olliver Schinagl
This patch allows Kconfig to enable and set parameters to make it possible to read the MAC address from an EEPROM. The net core layer then uses this information to read MAC addresses from this EEPROM. Besides the various tuneables as to how to access the eeprom (bus, address, addressing

[linux-sunxi] [PATCHv6 24/28] net: dw: Expose designware_eth_start

2017-05-15 Thread Olliver Schinagl
Commit e72ced234045f ("net: designware: Export the operation functions") started to expose some of the net_ops. The sunxi_gmac glue driver also needs the start function, so let us expose that as well. Signed-off-by: Olliver Schinagl --- drivers/net/designware.c | 2 +-

[linux-sunxi] [PATCHv6 08/28] net: cosmetic: Do not use magic values for ARP_HLEN

2017-05-15 Thread Olliver Schinagl
Previously overlooked magic value in commit a40db6d51171 ("net: cosmetic: Do not use magic values for ARP_HLEN") Signed-off-by: Olliver Schinagl --- include/net.h| 4 ++-- net/eth_common.c | 2 +- 2 files changed, 3 insertions(+), 3 deletions(-) diff --git

[linux-sunxi] [PATCHv6 28/28] net: sunxi: Enable eeprom on OLinuXino Lime boards (again)

2017-05-15 Thread Olliver Schinagl
With commit 2681e78a5ee ("configs: Re-sync") we lost the EEPROM settings from the defconfig files. Let us re-add them. Signed-off-by: Olliver Schinagl --- configs/A10-OLinuXino-Lime_defconfig | 3 +++ configs/A20-OLinuXino-Lime2-eMMC_defconfig | 3 +++

[linux-sunxi] [PATCHv6 11/28] net: core: Add MAC address helper functions

2017-05-15 Thread Olliver Schinagl
Universally administered and locally administered addresses are distinguished by setting the second-least-significant bit of the first octet of the address. Having a function to check and set this U/L bit from a function makes it nice for boards that want to generate their own mac address to

[linux-sunxi] [PATCHv6 14/28] net: cosmetic: A MAC address is not limited to SROM

2017-05-15 Thread Olliver Schinagl
Currently, we print that the MAC from the SROM does not match. It can be many forms of ROM, so lets drop the S. Signed-off-by: Olliver Schinagl --- net/eth_legacy.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/net/eth_legacy.c b/net/eth_legacy.c index

[linux-sunxi] [PATCHv6 20/28] net: sunxi: Rename sunxi_emac to a more specific sun4i_mac

2017-05-15 Thread Olliver Schinagl
The sunxi_emac driver is very specific to the IP used in the sun4i. Thus rename it to what it actually is, the MAC driver for the sun4i MAC. The rename also changes the variable and function names inside the driver. There are no code changes in this patch however. While here, use the BIT() macro

[linux-sunxi] [PATCHv6 07/28] net: sunxi: Move GMAC_TX_DELAY to the driver

2017-05-15 Thread Olliver Schinagl
The GMAC_TX_DELAY symbol sets and is dependent on the SUN7I_GMAC driver. Move it from the generic ARCH section to the driver specific section. Signed-off-by: Olliver Schinagl --- arch/arm/mach-sunxi/Kconfig | 6 -- drivers/net/Kconfig | 7 +++ 2 files

[linux-sunxi] [PATCHv6 19/28] net: sunxi_emac: Write HW address via net_ops hook

2017-05-15 Thread Olliver Schinagl
Expose the write_hwaddr net_ops hook to write the Ethernet address. Signed-off-by: Olliver Schinagl --- drivers/net/sunxi_emac.c | 12 1 file changed, 12 insertions(+) diff --git a/drivers/net/sunxi_emac.c b/drivers/net/sunxi_emac.c index 99339db4bf..0dc37de242

[linux-sunxi] [PATCHv6 02/28] sun7i: Add support for Olimex A20-OLinuXino-LIME2-eMMC

2017-05-15 Thread Olliver Schinagl
This patch adds support for the Olimex OLinuXino Lime2 with eMMC flash storage. https://www.olimex.com/Products/OLinuXino/A20/A20-OLinuXino-LIME2-eMMC/ It is a assembly variant of the regular Lime2 but featuring eMMC for storage. Signed-off-by: Olliver Schinagl ---

[linux-sunxi] [PATCHv6 21/28] net: sunxi: Have sunxi common functions together

2017-05-15 Thread Olliver Schinagl
The sun[8x]i network drivers have some common functions. Let's introduce a common file with the reading of the MAC address as a start. In the future, we can move more sunxi shared/common code into this file. Signed-off-by: Olliver Schinagl --- drivers/net/sunxi_common.c |

[linux-sunxi] [PATCHv6 18/28] arm: sunxi: Expose function to generate sunxi-specific a MAC address

2017-05-15 Thread Olliver Schinagl
Expose the function to generate a MAC adddress based on the serial number. This can then later be moved completly out of the sunxi board specific stuff. The setup_environment quirky function still exists as it is still used to fixup the FDT for drivers that need the MAC address available in the

[linux-sunxi] [PATCHv6 01/28] ARM: dts: sunxi: Change node name for pwrseq pin on Olinuxino-lime2-emmc

2017-05-15 Thread Olliver Schinagl
From: Emmanuel Vadot The node name for the power seq pin is mmc2@0 like the mmc2_pins_a one. This makes the original node (mmc2_pins_a) scrapped out of the dtb and result in a unusable eMMC if U-Boot didn't configured the pins to the correct functions. Signed-off-by:

[linux-sunxi] [PATCHv6 05/28] net: sunxi: Re-add RTL8211X_PHY_FORCE_MASTER

2017-05-15 Thread Olliver Schinagl
Commit 8728c97eff5bd9 (" configs: Re-sync") potentially broke the lime2 as it removed the RTL8211X_PHY_FORCE_MASTER flag. Re-add this flag. Signed-off-by: Olliver Schinagl --- configs/A20-OLinuXino-Lime2_defconfig | 1 + configs/A20-Olimex-SOM-EVB_defconfig | 1 + 2 files

[linux-sunxi] [PATCHv6 15/28] net: core: Check return value of read_rom_hwaddr

2017-05-15 Thread Olliver Schinagl
Currently, we silently ignore the return value of netops->read_rom_hwaddr(). This naturally is bad and we should check if the code ran successfully. Signed-off-by: Olliver Schinagl --- net/eth-uclass.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git

[linux-sunxi] [PATCHv6 00/28] Retrieve MAC address from EEPROM

2017-05-15 Thread Olliver Schinagl
This patch-series introduces methods to retrieve the MAC address from an onboard EEPROM. The series does a few small cleanups at the start, as either I ran into them while doing this series and fixed them along the way or actually depended on them. A manufacturer wants to produce boards and may

[linux-sunxi] [PATCHv6 03/28] net: core: Add PHY_GIGE as a Kconfig symbol

2017-05-15 Thread Olliver Schinagl
Add the CONFIG_PHY_GIGE option as a hidden Kconfig symbol so that we can select it from the menu as a dependency. Signed-off-by: Olliver Schinagl --- drivers/net/Kconfig| 4 include/configs/sunxi-common.h | 1 - 2 files changed, 4 insertions(+), 1

[linux-sunxi] [PATCHv6 13/28] net: core: print the source of the MAC address

2017-05-15 Thread Olliver Schinagl
With many potential places where a MAC address can be read from, the user may not know where the MAC address originated from. Print the MAC source after initializing the Ethernet device. Signed-off-by: Olliver Schinagl --- include/net.h| 14 ++

[linux-sunxi] [PATCH] iio: adc: sun4i-gpadc-iio: fix parent device being used in devm function

2017-05-15 Thread Quentin Schulz
For the sake of DT binding stability, this IIO driver is a child of an MFD driver for Allwinner A10, A13 and A31 because there already exists a DT binding for this IP. The MFD driver has a DT node but the IIO driver does not. The IIO device registers the temperature sensor in the thermal

Re: [linux-sunxi] Re: [PATCH 3/3] sunxi: video: Add H3/H5 TV out driver

2017-05-15 Thread Maxime Ripard
On Sat, May 13, 2017 at 11:14:00PM +0800, Chen-Yu Tsai wrote: > >>> +static int sunxi_tve_get_plug_in_status(void) > >>> +{ > >>> + struct sunxi_tve_reg * const tve = > >>> + (struct sunxi_tve_reg *)SUNXI_TVE0_BASE; > >>> + u32 status; > >>> + > >>> + status =

[linux-sunxi] Re: [PATCH 3/3] sunxi: video: Add H3/H5 TV out driver

2017-05-15 Thread Maxime Ripard
On Sun, May 14, 2017 at 09:03:19PM -0600, Simon Glass wrote: > Hi, > > On 12 May 2017 at 10:06, Maxime Ripard > wrote: > > Hi Jernej, > > > > The patch content looks fine, but there's a few things that would need > > to be addressed. > > > > On Wed, May 10,