[linux-sunxi] Re: [PATCH v6 13/13] arm64: dts: sun50i-a64-pinephone: Add touchscreen support

2020-07-01 Thread Ondřej Jirman
Hi Icenowy, On Wed, Jul 01, 2020 at 08:01:14PM +0800, Icenowy Zheng wrote: > > > 于 2020年7月1日 GMT+08:00 下午6:31:26, Ondrej Jirman 写到: > >Pinephone has a Goodix GT917S capacitive touchscreen controller on > >I2C0 bus. Add support for it. > > > >Signed-off-by: Ondrej Jirman > >Acked-by: Linus

[linux-sunxi] Re: [PATCH v7 00/13] Add support for PinePhone LCD panel

2020-07-01 Thread Ondřej Jirman
Hello Sam, On Wed, Jul 01, 2020 at 07:30:18PM +0200, Sam Ravnborg wrote: > Hi Ondrej. > > On Wed, Jul 01, 2020 at 06:29:15PM +0200, Ondrej Jirman wrote: > > This patchset adds support for the LCD panel of PinePhone. > > > > I've tested this on PinePhone 1.0 and 1.2. > > Thanks for this nive

[linux-sunxi] Re: [PATCH v6 13/13] arm64: dts: sun50i-a64-pinephone: Add touchscreen support

2020-07-01 Thread Icenowy Zheng
于 2020年7月1日 GMT+08:00 下午6:31:26, Ondrej Jirman 写到: >Pinephone has a Goodix GT917S capacitive touchscreen controller on >I2C0 bus. Add support for it. > >Signed-off-by: Ondrej Jirman >Acked-by: Linus Walleij >--- > .../dts/allwinner/sun50i-a64-pinephone.dtsi | 19 +++ > 1

[linux-sunxi] Re: [PATCH v6 00/13] Add support for PinePhone LCD panel

2020-07-01 Thread Ondřej Jirman
Hello, On Wed, Jul 01, 2020 at 05:54:05PM +0200, Guido Günther wrote: > Hi, > On Wed, Jul 01, 2020 at 12:31:13PM +0200, Ondrej Jirman wrote: > > This patchset adds support for the LCD panel of PinePhone. > > I gave this a quick spin on the Librem5 devkit so > > Tested-by: Guido Günther > >

[linux-sunxi] Re: [PATCH v6 00/13] Add support for PinePhone LCD panel

2020-07-01 Thread Linus Walleij
On Wed, Jul 1, 2020 at 6:30 PM Ondřej Jirman wrote: > On Wed, Jul 01, 2020 at 05:25:32PM +0200, Sam Ravnborg wrote: > > Hi Ondrej. > > > > On Wed, Jul 01, 2020 at 12:31:13PM +0200, Ondrej Jirman wrote: > > > This patchset adds support for the LCD panel of PinePhone. > > > > > > I've tested this

[linux-sunxi] Re: [PATCH v6 02/13] dt-bindings: panel: Convert rocktech,jh057n00900 to yaml

2020-07-01 Thread Ondřej Jirman
Hello Guido, On Wed, Jul 01, 2020 at 05:58:57PM +0200, Guido Günther wrote: > Hi Ondrej, > On Wed, Jul 01, 2020 at 12:31:15PM +0200, Ondrej Jirman wrote: > > Convert Rocktech MIPI DSI panel driver from txt to yaml bindings. > > > > Signed-off-by: Ondrej Jirman > > --- > >

[linux-sunxi] Re: [PATCH v6 00/13] Add support for PinePhone LCD panel

2020-07-01 Thread Ondřej Jirman
Hello Sam, On Wed, Jul 01, 2020 at 05:25:32PM +0200, Sam Ravnborg wrote: > Hi Ondrej. > > On Wed, Jul 01, 2020 at 12:31:13PM +0200, Ondrej Jirman wrote: > > This patchset adds support for the LCD panel of PinePhone. > > > > I've tested this on PinePhone 1.0 and 1.2. > > > > Please take a look.

[linux-sunxi] [PATCH v7 13/13] arm64: dts: sun50i-a64-pinephone: Add touchscreen support

2020-07-01 Thread Ondrej Jirman
Pinephone has a Goodix GT917S capacitive touchscreen controller on I2C0 bus. Add support for it. Signed-off-by: Ondrej Jirman Acked-by: Linus Walleij --- .../dts/allwinner/sun50i-a64-pinephone.dtsi | 19 +++ 1 file changed, 19 insertions(+) diff --git

[linux-sunxi] [PATCH v7 09/13] drm/panel: st7703: Add support for Xingbangda XBD599

2020-07-01 Thread Ondrej Jirman
Xingbangda XBD599 is a 5.99" 720x1440 MIPI-DSI LCD panel used in PinePhone. Add support for it. Signed-off-by: Icenowy Zheng Signed-off-by: Ondrej Jirman Reviewed-by: Linus Walleij --- drivers/gpu/drm/panel/panel-sitronix-st7703.c | 199 +- 1 file changed, 197 insertions(+), 2

[linux-sunxi] [PATCH v7 10/13] drm/panel: st7703: Enter sleep after display off

2020-07-01 Thread Ondrej Jirman
The datasheet suggests to issue sleep in after display off as a part of the panel's shutdown sequence. Signed-off-by: Ondrej Jirman Reviewed-by: Linus Walleij --- drivers/gpu/drm/panel/panel-sitronix-st7703.c | 13 - 1 file changed, 12 insertions(+), 1 deletion(-) diff --git

[linux-sunxi] [PATCH v7 06/13] drm/panel: st7703: Prepare for supporting multiple panels

2020-07-01 Thread Ondrej Jirman
Parametrize the driver so that it can support more panels based on st7703 controller. Signed-off-by: Ondrej Jirman Reviewed-by: Linus Walleij --- drivers/gpu/drm/panel/panel-sitronix-st7703.c | 43 +-- 1 file changed, 31 insertions(+), 12 deletions(-) diff --git

[linux-sunxi] [PATCH v7 08/13] drm/panel: st7703: Move generic part of init sequence to enable callback

2020-07-01 Thread Ondrej Jirman
Calling sleep out and display on is a controller specific part of the initialization process. Move it out of the panel specific initialization function to the enable callback. Signed-off-by: Ondrej Jirman Reviewed-by: Linus Walleij --- drivers/gpu/drm/panel/panel-sitronix-st7703.c | 33

[linux-sunxi] [PATCH v7 07/13] drm/panel: st7703: Move code specific to jh057n closer together

2020-07-01 Thread Ondrej Jirman
It's better than having it spread around the driver. Signed-off-by: Ondrej Jirman Reviewed-by: Linus Walleij --- drivers/gpu/drm/panel/panel-sitronix-st7703.c | 48 +-- 1 file changed, 24 insertions(+), 24 deletions(-) diff --git a/drivers/gpu/drm/panel/panel-sitronix-st7703.c

[linux-sunxi] [PATCH v7 05/13] drm/panel: st7703: Rename functions from jh057n prefix to st7703

2020-07-01 Thread Ondrej Jirman
This is done so that code that's not specific to a particular jh057n panel is named after the controller. Functions specific to the panel are kept named after the panel. Signed-off-by: Ondrej Jirman Reviewed-by: Linus Walleij --- drivers/gpu/drm/panel/panel-sitronix-st7703.c | 90

[linux-sunxi] [PATCH v7 04/13] drm/panel: rocktech-jh057n00900: Rename the driver to st7703

2020-07-01 Thread Ondrej Jirman
This rename is done so that the driver matches the name of the display controller and in preparation for adding support for more panels to the driver. This is just a basic file rename, with no code changes. Signed-off-by: Ondrej Jirman Reviewed-by: Linus Walleij ---

[linux-sunxi] [PATCH v7 03/13] dt-bindings: panel: Add compatible for Xingbangda XBD599 panel

2020-07-01 Thread Ondrej Jirman
Xingbangda XBD599 is a 5.99" 720x1440 MIPI-DSI LCD panel. It is based on Sitronix ST7703 LCD controller just like rocktech,jh057n00900. It is used in PinePhone. Add a compatible for it. Signed-off-by: Ondrej Jirman --- .../bindings/display/panel/rocktech,jh057n00900.yaml| 6 +- 1

[linux-sunxi] [PATCH v7 00/13] Add support for PinePhone LCD panel

2020-07-01 Thread Ondrej Jirman
This patchset adds support for the LCD panel of PinePhone. I've tested this on PinePhone 1.0 and 1.2. Please take a look. thank you and regards, Ondrej Jirman Changes in v7: - Removed mode.vrefresh, rebased onto next-20200701 - v6->v7 diff: https://megous.com/dl/tmp/v6-v7.patch Chan

[linux-sunxi] [PATCH v7 11/13] drm/panel: st7703: Assert reset prior to powering down the regulators

2020-07-01 Thread Ondrej Jirman
The reset pin is inverted, so if we don't assert reset, the actual gpio will be high and may keep driving the IO port of the panel. Signed-off-by: Ondrej Jirman Reviewed-by: Linus Walleij --- drivers/gpu/drm/panel/panel-sitronix-st7703.c | 1 + 1 file changed, 1 insertion(+) diff --git

[linux-sunxi] [PATCH v7 01/13] dt-bindings: vendor-prefixes: Add Xingbangda

2020-07-01 Thread Ondrej Jirman
From: Icenowy Zheng Shenzhen Xingbangda Display Technology Co., Ltd is a company which produces LCD modules. It supplies the LCD panels for the PinePhone. Add the vendor prefix of it. Signed-off-by: Icenowy Zheng Signed-off-by: Ondrej Jirman Acked-by: Rob Herring ---

[linux-sunxi] [PATCH v7 02/13] dt-bindings: panel: Convert rocktech,jh057n00900 to yaml

2020-07-01 Thread Ondrej Jirman
Convert Rocktech MIPI DSI panel driver from txt to yaml bindings. Signed-off-by: Ondrej Jirman --- .../display/panel/rocktech,jh057n00900.txt| 23 --- .../display/panel/rocktech,jh057n00900.yaml | 66 +++ 2 files changed, 66 insertions(+), 23 deletions(-) delete mode

[linux-sunxi] [PATCH v7 12/13] arm64: dts: sun50i-a64-pinephone: Enable LCD support on PinePhone

2020-07-01 Thread Ondrej Jirman
From: Icenowy Zheng PinePhone uses PWM backlight and a XBD599 LCD panel over DSI for display. Backlight levels curve was optimized by Martijn Braam using a lux meter. Add its device nodes. Signed-off-by: Icenowy Zheng Signed-off-by: Martijn Braam Signed-off-by: Ondrej Jirman Acked-by:

[linux-sunxi] Re: [PATCH v5 09/13] drm/panel: st7703: Add support for Xingbangda XBD599

2020-07-01 Thread Ondřej Jirman
Hello Linus, On Wed, Jul 01, 2020 at 09:50:40AM +0200, Linus Walleij wrote: > On Fri, Jun 26, 2020 at 2:56 AM Ondrej Jirman wrote: > > > Xingbangda XBD599 is a 5.99" 720x1440 MIPI-DSI LCD panel used in > > PinePhone. Add support for it. > > > > Signed-off-by: Icenowy Zheng > > Signed-off-by:

[linux-sunxi] [PATCH v6 03/13] dt-bindings: panel: Add compatible for Xingbangda XBD599 panel

2020-07-01 Thread Ondrej Jirman
Xingbangda XBD599 is a 5.99" 720x1440 MIPI-DSI LCD panel. It is based on Sitronix ST7703 LCD controller just like rocktech,jh057n00900. It is used in PinePhone. Add a compatible for it. Signed-off-by: Ondrej Jirman --- .../bindings/display/panel/rocktech,jh057n00900.yaml| 6 +- 1

[linux-sunxi] [PATCH v6 01/13] dt-bindings: vendor-prefixes: Add Xingbangda

2020-07-01 Thread Ondrej Jirman
From: Icenowy Zheng Shenzhen Xingbangda Display Technology Co., Ltd is a company which produces LCD modules. It supplies the LCD panels for the PinePhone. Add the vendor prefix of it. Signed-off-by: Icenowy Zheng Signed-off-by: Ondrej Jirman Acked-by: Rob Herring ---

[linux-sunxi] [PATCH v6 13/13] arm64: dts: sun50i-a64-pinephone: Add touchscreen support

2020-07-01 Thread Ondrej Jirman
Pinephone has a Goodix GT917S capacitive touchscreen controller on I2C0 bus. Add support for it. Signed-off-by: Ondrej Jirman Acked-by: Linus Walleij --- .../dts/allwinner/sun50i-a64-pinephone.dtsi | 19 +++ 1 file changed, 19 insertions(+) diff --git

[linux-sunxi] [PATCH v6 11/13] drm/panel: st7703: Assert reset prior to powering down the regulators

2020-07-01 Thread Ondrej Jirman
The reset pin is inverted, so if we don't assert reset, the actual gpio will be high and may keep driving the IO port of the panel. Signed-off-by: Ondrej Jirman Reviewed-by: Linus Walleij --- drivers/gpu/drm/panel/panel-sitronix-st7703.c | 1 + 1 file changed, 1 insertion(+) diff --git

[linux-sunxi] [PATCH v6 04/13] drm/panel: rocktech-jh057n00900: Rename the driver to st7703

2020-07-01 Thread Ondrej Jirman
This rename is done so that the driver matches the name of the display controller and in preparation for adding support for more panels to the driver. This is just a basic file rename, with no code changes. Signed-off-by: Ondrej Jirman Reviewed-by: Linus Walleij ---

[linux-sunxi] [PATCH v6 09/13] drm/panel: st7703: Add support for Xingbangda XBD599

2020-07-01 Thread Ondrej Jirman
Xingbangda XBD599 is a 5.99" 720x1440 MIPI-DSI LCD panel used in PinePhone. Add support for it. Signed-off-by: Icenowy Zheng Signed-off-by: Ondrej Jirman Reviewed-by: Linus Walleij --- drivers/gpu/drm/panel/panel-sitronix-st7703.c | 200 +- 1 file changed, 198 insertions(+), 2

[linux-sunxi] [PATCH v6 08/13] drm/panel: st7703: Move generic part of init sequence to enable callback

2020-07-01 Thread Ondrej Jirman
Calling sleep out and display on is a controller specific part of the initialization process. Move it out of the panel specific initialization function to the enable callback. Signed-off-by: Ondrej Jirman Reviewed-by: Linus Walleij --- drivers/gpu/drm/panel/panel-sitronix-st7703.c | 33

[linux-sunxi] [PATCH v6 12/13] arm64: dts: sun50i-a64-pinephone: Enable LCD support on PinePhone

2020-07-01 Thread Ondrej Jirman
From: Icenowy Zheng PinePhone uses PWM backlight and a XBD599 LCD panel over DSI for display. Backlight levels curve was optimized by Martijn Braam using a lux meter. Add its device nodes. Signed-off-by: Icenowy Zheng Signed-off-by: Martijn Braam Signed-off-by: Ondrej Jirman Acked-by:

[linux-sunxi] [PATCH v6 02/13] dt-bindings: panel: Convert rocktech,jh057n00900 to yaml

2020-07-01 Thread Ondrej Jirman
Convert Rocktech MIPI DSI panel driver from txt to yaml bindings. Signed-off-by: Ondrej Jirman --- .../display/panel/rocktech,jh057n00900.txt| 23 --- .../display/panel/rocktech,jh057n00900.yaml | 66 +++ 2 files changed, 66 insertions(+), 23 deletions(-) delete mode

[linux-sunxi] [PATCH v6 05/13] drm/panel: st7703: Rename functions from jh057n prefix to st7703

2020-07-01 Thread Ondrej Jirman
This is done so that code that's not specific to a particular jh057n panel is named after the controller. Functions specific to the panel are kept named after the panel. Signed-off-by: Ondrej Jirman Reviewed-by: Linus Walleij --- drivers/gpu/drm/panel/panel-sitronix-st7703.c | 90

[linux-sunxi] [PATCH v6 00/13] Add support for PinePhone LCD panel

2020-07-01 Thread Ondrej Jirman
This patchset adds support for the LCD panel of PinePhone. I've tested this on PinePhone 1.0 and 1.2. Please take a look. thank you and regards, Ondrej Jirman Changes in v6: - Fixed spacing in yaml - Fixed wrong vccio->iovcc supply name in the bindings doc - I noticed that the original

[linux-sunxi] [PATCH v6 07/13] drm/panel: st7703: Move code specific to jh057n closer together

2020-07-01 Thread Ondrej Jirman
It's better than having it spread around the driver. Signed-off-by: Ondrej Jirman Reviewed-by: Linus Walleij --- drivers/gpu/drm/panel/panel-sitronix-st7703.c | 50 +-- 1 file changed, 25 insertions(+), 25 deletions(-) diff --git a/drivers/gpu/drm/panel/panel-sitronix-st7703.c

[linux-sunxi] [PATCH v6 10/13] drm/panel: st7703: Enter sleep after display off

2020-07-01 Thread Ondrej Jirman
The datasheet suggests to issue sleep in after display off as a part of the panel's shutdown sequence. Signed-off-by: Ondrej Jirman Reviewed-by: Linus Walleij --- drivers/gpu/drm/panel/panel-sitronix-st7703.c | 13 - 1 file changed, 12 insertions(+), 1 deletion(-) diff --git

[linux-sunxi] [PATCH v6 06/13] drm/panel: st7703: Prepare for supporting multiple panels

2020-07-01 Thread Ondrej Jirman
Parametrize the driver so that it can support more panels based on st7703 controller. Signed-off-by: Ondrej Jirman Reviewed-by: Linus Walleij --- drivers/gpu/drm/panel/panel-sitronix-st7703.c | 43 +-- 1 file changed, 31 insertions(+), 12 deletions(-) diff --git

[linux-sunxi] Re: [PATCH v5 13/13] arm64: dts: sun50i-a64-pinephone: Add touchscreen support

2020-07-01 Thread Linus Walleij
On Fri, Jun 26, 2020 at 2:56 AM Ondrej Jirman wrote: > Pinephone has a Goodix GT917S capacitive touchscreen controller on > I2C0 bus. Add support for it. > > Signed-off-by: Ondrej Jirman Acked-by: Linus Walleij Yours, Linus Walleij -- You received this message because you are subscribed to

[linux-sunxi] Re: [PATCH v5 12/13] arm64: dts: sun50i-a64-pinephone: Enable LCD support on PinePhone

2020-07-01 Thread Linus Walleij
On Fri, Jun 26, 2020 at 2:56 AM Ondrej Jirman wrote: > From: Icenowy Zheng > > PinePhone uses PWM backlight and a XBD599 LCD panel over DSI for > display. > > Backlight levels curve was optimized by Martijn Braam using a > lux meter. > > Add its device nodes. > > Signed-off-by: Icenowy Zheng >

[linux-sunxi] Re: [PATCH v5 11/13] drm/panel: st7703: Assert reset prior to powering down the regulators

2020-07-01 Thread Linus Walleij
On Fri, Jun 26, 2020 at 2:56 AM Ondrej Jirman wrote: > The reset pin is inverted, so if we don't assert reset, the actual gpio > will be high and may keep driving the IO port of the panel. > > Signed-off-by: Ondrej Jirman Reviewed-by: Linus Walleij Yours, Linus Walleij -- You received this

[linux-sunxi] Re: [PATCH v5 10/13] drm/panel: st7703: Enter sleep after display off

2020-07-01 Thread Linus Walleij
On Fri, Jun 26, 2020 at 2:56 AM Ondrej Jirman wrote: > The datasheet suggests to issue sleep in after display off > as a part of the panel's shutdown sequence. > > Signed-off-by: Ondrej Jirman Reviewed-by: Linus Walleij Yours, Linus Walleij -- You received this message because you are

[linux-sunxi] Re: [PATCH v5 09/13] drm/panel: st7703: Add support for Xingbangda XBD599

2020-07-01 Thread Linus Walleij
On Fri, Jun 26, 2020 at 2:56 AM Ondrej Jirman wrote: > Xingbangda XBD599 is a 5.99" 720x1440 MIPI-DSI LCD panel used in > PinePhone. Add support for it. > > Signed-off-by: Icenowy Zheng > Signed-off-by: Ondrej Jirman Reviewed-by: Linus Walleij Yours, Linus Walleij -- You received this

[linux-sunxi] Re: [PATCH v5 08/13] drm/panel: st7703: Move generic part of init sequence to enable callback

2020-07-01 Thread Linus Walleij
On Fri, Jun 26, 2020 at 2:56 AM Ondrej Jirman wrote: > Calling sleep out and display on is a controller specific part > of the initialization process. Move it out of the panel specific > initialization function to the enable callback. > > Signed-off-by: Ondrej Jirman Reviewed-by: Linus Walleij

[linux-sunxi] Re: [PATCH v5 07/13] drm/panel: st7703: Move code specific to jh057n closer together

2020-07-01 Thread Linus Walleij
On Fri, Jun 26, 2020 at 2:56 AM Ondrej Jirman wrote: > It's better than having it spread around the driver. > > Signed-off-by: Ondrej Jirman Reviewed-by: Linus Walleij Yours, Linus Walleij -- You received this message because you are subscribed to the Google Groups "linux-sunxi" group. To

[linux-sunxi] Re: [PATCH v5 06/13] drm/panel: st7703: Prepare for supporting multiple panels

2020-07-01 Thread Linus Walleij
On Fri, Jun 26, 2020 at 2:56 AM Ondrej Jirman wrote: > Parametrize the driver so that it can support more panels based > on st7703 controller. > > Signed-off-by: Ondrej Jirman Reviewed-by: Linus Walleij Yours, Linus Walleij -- You received this message because you are subscribed to the

[linux-sunxi] Re: [PATCH v5 05/13] drm/panel: st7703: Rename functions from jh057n prefix to st7703

2020-07-01 Thread Linus Walleij
On Fri, Jun 26, 2020 at 2:56 AM Ondrej Jirman wrote: > This is done so that code that's not specific to a particular > jh057n panel is named after the controller. Functions specific > to the panel are kept named after the panel. > > Signed-off-by: Ondrej Jirman Reviewed-by: Linus Walleij

[linux-sunxi] Re: [PATCH v5 04/13] drm/panel: rocktech-jh057n00900: Rename the driver to st7703

2020-07-01 Thread Linus Walleij
On Fri, Jun 26, 2020 at 2:56 AM Ondrej Jirman wrote: > This rename is done so that the driver matches the name of the > display controller and in preparation for adding support for more > panels to the driver. > > This is just a basic file rename, with no code changes. > > Signed-off-by: Ondrej