Re: [linux-sunxi] [PATCH] Add support for consumer infrared devices on A20

2014-04-28 Thread Hans de Goede
Hi, On 04/28/2014 07:55 AM, Julian Calaby wrote: Hi Alexander, On Mon, Apr 28, 2014 at 3:35 PM, Александр Берсенев b...@hackerdom.ru wrote: I fixed all known kernel oopses by placing spinlock in interrupt handler and changing driver initialization order. Left to do: 1) deal with timers

Re: [linux-sunxi] [PATCH] Add support for consumer infrared devices on A20

2014-04-28 Thread Code Kipper
I am going away for few days for not being too noisy. There's nothing wrong with being too noisy. Absolutely, thank you for working on this. +1 on that. I was thinking about contacting Wingrime about taking on this driver as I thought it would be quite a nice one to start mainlining

Re: [linux-sunxi] [PATCH] Add support for consumer infrared devices on A20

2014-04-27 Thread Александр Берсенев
Hello, Thank you for your replies. I decided to use Wingrime's patch as a base for my patch to not doing the same work twice. I've changed code a bit, espectially in initialization and finalisation part. Now it not freezes a system after insmod/rmmod/insmod. This patch applies on Hans de

Re: [linux-sunxi] [PATCH] Add support for consumer infrared devices on A20

2014-04-27 Thread Александр Берсенев
I did 300 000 insmod/rmmod cycles and all was ok, but the memory consumption increased from 23MB to 36MB. I think, it is because of timers. As Hans de Goede said, it is better to use devm_clk_get to get the clock. I use this function in my first patch, but I not found a way to get apb0_ir0

Re: [linux-sunxi] [PATCH] Add support for consumer infrared devices on A20

2014-04-27 Thread Julian Calaby
Hi Alexander, On Mon, Apr 28, 2014 at 3:35 PM, Александр Берсенев b...@hackerdom.ru wrote: I fixed all known kernel oopses by placing spinlock in interrupt handler and changing driver initialization order. Left to do: 1) deal with timers 2) support and testing on other platforms I am

Re: [linux-sunxi] [PATCH] Add support for consumer infrared devices on A20

2014-04-26 Thread Julian Calaby
Hi Александр, (Gmail seems to have messed up the indentation, so I apologise for that.) First things first: You should really split this into a few patches: 1. Make any modifications unrelated to the driver itself 2. Add / amend the documentation for the device tree bindings. 3. Add the

Re: [linux-sunxi] [PATCH] Add support for consumer infrared devices on A20

2014-04-26 Thread Rudi
On 25.04.2014 11:38, Александр Берсенев wrote: This patch introduces Consumer IR(CIR) support for cubietruck. It was ported from sunxi linux 3.4 and supports only NEC protocol. What happened to the CIR driver by Alexandr Shutko ? This driver was written for the A10 quite a while ago but wasn't

Re: [linux-sunxi] [PATCH] Add support for consumer infrared devices on A20

2014-04-26 Thread Hans de Goede
Hi, On 04/25/2014 11:38 AM, Александр Берсенев wrote: This patch introduces Consumer IR(CIR) support for cubietruck. It was ported from sunxi linux 3.4 and supports only NEC protocol. Changes from the original driver: - moved kernel's Input Subsystem API - initialization code was

Re: [linux-sunxi] [PATCH] Add support for consumer infrared devices on A20

2014-04-26 Thread Hans de Goede
Hi, On 04/26/2014 05:01 PM, Rudi wrote: On 25.04.2014 11:38, Александр Берсенев wrote: This patch introduces Consumer IR(CIR) support for cubietruck. It was ported from sunxi linux 3.4 and supports only NEC protocol. What happened to the CIR driver by Alexandr Shutko ? This driver was

Re: [linux-sunxi] [PATCH] Add support for consumer infrared devices on A20

2014-04-26 Thread Rudi
Hi, Ah I just send a mail about the need to use the rc-core subsys myself, I did not know we already had a driver using that. Do you have a link to the old posting of that driver ? That would be a great starting point for Alexander to get something ready for the mainline (iirc the cir driver

Re: [linux-sunxi] [PATCH] Add support for consumer infrared devices on A20

2014-04-26 Thread alex allss
I have patch almost ready for mainline, but I still have some bug with module reloading. Also, my old RFC in linux-sunxi mailist. 26 апр. 2014 г. 21:11 пользователь Rudi r.i...@s-t.de написал: Hi, Ah I just send a mail about the need to use the rc-core subsys myself, I did not know we

Re: [linux-sunxi] [PATCH] Add support for consumer infrared devices on A20

2014-04-26 Thread Hans de Goede
Hi, On 04/26/2014 05:19 PM, alex allss wrote: I have patch almost ready for mainline, but I still have some bug with module reloading. Perhaps you can post / or push it somewhere ? Then maybe someone else will be able to figure out what is causing the module reloading problem. I assume the

Re: [linux-sunxi] [PATCH] Add support for consumer infrared devices on A20

2014-04-26 Thread alex allss
Hans: you can take a look recent: http://paste.debian.net/95872/ I need rebase it aganist current mainline drvier are checked with LIRC frontend yes, problem with OPS after serval reloads 2014-04-26 21:21 GMT+06:00 Hans de Goede hdego...@redhat.com: Hi, On 04/26/2014 05:19 PM, alex

Re: [linux-sunxi] [PATCH] Add support for consumer infrared devices on A20

2014-04-26 Thread alex allss
Big thanks Hans, I apply you suggests, and test again 26 апр. 2014 г. 21:44 пользователь Hans de Goede hdego...@redhat.com написал: Hi, On 04/26/2014 05:24 PM, alex allss wrote: Hans: you can take a look recent: http://paste.debian.net/95872/ Cool, very good work, thanks for working

Re: [linux-sunxi] [PATCH] Add support for consumer infrared devices on A20

2014-04-26 Thread Alejandro Mery
On 26/04/14 17:11, Rudi wrote: Hi, Ah I just send a mail about the need to use the rc-core subsys myself, I did not know we already had a driver using that. Do you have a link to the old posting of that driver ? That would be a great starting point for Alexander to get something ready for