Re: [linux-sunxi] Re: [PATCH 1/2] dmaengine: sun6i: make gate bit in sun8i's DMA engines a common quirk

2017-06-20 Thread Maxime Ripard
On Thu, Jun 15, 2017 at 09:24:08AM +0530, Vinod Koul wrote: > On Wed, Jun 14, 2017 at 11:04:39AM +0200, Maxime Ripard wrote: > > On Wed, Jun 14, 2017 at 02:15:29PM +0530, Vinod Koul wrote: > > > > SoC info is in compatible, so there's no reason to make it a property. > > > > > > that's why it

Re: [linux-sunxi] Re: [PATCH 1/2] dmaengine: sun6i: make gate bit in sun8i's DMA engines a common quirk

2017-06-14 Thread Icenowy Zheng
于 2017年6月15日 GMT+08:00 上午11:54:08, Vinod Koul 写到: >On Wed, Jun 14, 2017 at 11:04:39AM +0200, Maxime Ripard wrote: >> On Wed, Jun 14, 2017 at 02:15:29PM +0530, Vinod Koul wrote: >> > > SoC info is in compatible, so there's no reason to make it a >property. >> > >> > that's

Re: [linux-sunxi] Re: [PATCH 1/2] dmaengine: sun6i: make gate bit in sun8i's DMA engines a common quirk

2017-06-14 Thread Maxime Ripard
On Wed, Jun 14, 2017 at 02:15:29PM +0530, Vinod Koul wrote: > > SoC info is in compatible, so there's no reason to make it a property. > > that's why it would need to be optional for the SoC's that needs these.. There's nothing optional about that behaviour, it's mandatory for the SoC that need

Re: [linux-sunxi] Re: [PATCH 1/2] dmaengine: sun6i: make gate bit in sun8i's DMA engines a common quirk

2017-06-14 Thread Icenowy Zheng
于 2017年6月14日 GMT+08:00 下午4:45:29, Vinod Koul 写到: >On Wed, Jun 14, 2017 at 04:32:57PM +0800, Icenowy Zheng wrote: >> >> >> 于 2017年6月14日 GMT+08:00 下午4:32:52, Vinod Koul >写到: >> >On Mon, Jun 05, 2017 at 08:33:47PM +0800, Icenowy Zheng wrote: >> >>

[linux-sunxi] Re: [PATCH 1/2] dmaengine: sun6i: make gate bit in sun8i's DMA engines a common quirk

2017-06-14 Thread Vinod Koul
On Wed, Jun 14, 2017 at 04:32:57PM +0800, Icenowy Zheng wrote: > > > 于 2017年6月14日 GMT+08:00 下午4:32:52, Vinod Koul 写到: > >On Mon, Jun 05, 2017 at 08:33:47PM +0800, Icenowy Zheng wrote: > >> From: Icenowy Zheng > >> > >> Originally we enable a special

[linux-sunxi] Re: [PATCH 1/2] dmaengine: sun6i: make gate bit in sun8i's DMA engines a common quirk

2017-06-14 Thread Icenowy Zheng
于 2017年6月14日 GMT+08:00 下午4:32:52, Vinod Koul 写到: >On Mon, Jun 05, 2017 at 08:33:47PM +0800, Icenowy Zheng wrote: >> From: Icenowy Zheng >> >> Originally we enable a special gate bit when the compatible indicates >> A23/33. >> >> But according to BSP

[linux-sunxi] Re: [PATCH 1/2] dmaengine: sun6i: make gate bit in sun8i's DMA engines a common quirk

2017-06-14 Thread Vinod Koul
On Mon, Jun 05, 2017 at 08:33:47PM +0800, Icenowy Zheng wrote: > From: Icenowy Zheng > > Originally we enable a special gate bit when the compatible indicates > A23/33. > > But according to BSP sources and user manuals, more SoCs will need this > gate bit. > > So make it a