[linux-sunxi] Re: [PATCH 1/2] mmc: sunxi: fix timeout in sunxi_mmc_oclk_onoff

2015-05-25 Thread Maxime Ripard
Hi Michal, The patch itself looks good, but there's a few style issues. On Sun, May 24, 2015 at 08:07:32PM +0200, Michal Suchanek wrote: > The 250ms timeout is too short. > > On my system enabling the oclk takes under 50ms and disabling slightly > over 100ms when idle. Under load disabling the c

[linux-sunxi] Re: [PATCH 1/2] mmc: sunxi: fix timeout in sunxi_mmc_oclk_onoff

2015-05-24 Thread Hans de Goede
Hi, On 24-05-15 20:07, Michal Suchanek wrote: The 250ms timeout is too short. On my system enabling the oclk takes under 50ms and disabling slightly over 100ms when idle. Under load disabling the clock can take over 350ms. This does not make mmc clock gating look like good option to have on su