[linux-sunxi] Re: [PATCH 1/4] input: Add new sun4i-lradc-keys drivers

2014-01-06 Thread Maxime Ripard
On Fri, Jan 03, 2014 at 10:23:50AM -0800, Dmitry Torokhov wrote: > On Fri, Jan 03, 2014 at 06:36:05PM +0100, Maxime Ripard wrote: > > On Thu, Jan 02, 2014 at 11:36:33PM +0100, Hans de Goede wrote: > > > Hi, > > > > > > On 01/02/2014 09:20 PM, Maxime Ripard wrote: > > > >On Thu, Jan 02, 2014 at 02:

[linux-sunxi] Re: [PATCH 1/4] input: Add new sun4i-lradc-keys drivers

2014-01-06 Thread Heiko Stübner
Am Freitag, 3. Januar 2014, 10:23:50 schrieb Dmitry Torokhov: > On Fri, Jan 03, 2014 at 06:36:05PM +0100, Maxime Ripard wrote: > > On Thu, Jan 02, 2014 at 11:36:33PM +0100, Hans de Goede wrote: > > > Hi, > > > > > > On 01/02/2014 09:20 PM, Maxime Ripard wrote: > > > >On Thu, Jan 02, 2014 at 02:45:

[linux-sunxi] Re: [PATCH 1/4] input: Add new sun4i-lradc-keys drivers

2014-01-03 Thread Dmitry Torokhov
On Fri, Jan 03, 2014 at 06:36:05PM +0100, Maxime Ripard wrote: > On Thu, Jan 02, 2014 at 11:36:33PM +0100, Hans de Goede wrote: > > Hi, > > > > On 01/02/2014 09:20 PM, Maxime Ripard wrote: > > >On Thu, Jan 02, 2014 at 02:45:29PM +0100, Hans de Goede wrote: > > >>>Also, instead of inventing yet ano

[linux-sunxi] Re: [PATCH 1/4] input: Add new sun4i-lradc-keys drivers

2014-01-03 Thread Maxime Ripard
On Thu, Jan 02, 2014 at 11:36:33PM +0100, Hans de Goede wrote: > Hi, > > On 01/02/2014 09:20 PM, Maxime Ripard wrote: > >On Thu, Jan 02, 2014 at 02:45:29PM +0100, Hans de Goede wrote: > >>>Also, instead of inventing yet another vendor-specific property, why not > >>>re-use > >>>a button binding s

[linux-sunxi] Re: [PATCH 1/4] input: Add new sun4i-lradc-keys drivers

2014-01-03 Thread Maxime Ripard
On Thu, Jan 02, 2014 at 12:38:31PM -0800, Dmitry Torokhov wrote: > On Thu, Jan 02, 2014 at 09:20:22PM +0100, Maxime Ripard wrote: > > On Thu, Jan 02, 2014 at 02:45:29PM +0100, Hans de Goede wrote: > > > >Also, instead of inventing yet another vendor-specific property, why not > > > >re-use > > > >

[linux-sunxi] Re: [PATCH 1/4] input: Add new sun4i-lradc-keys drivers

2014-01-02 Thread Dmitry Torokhov
On Thu, Jan 02, 2014 at 09:20:22PM +0100, Maxime Ripard wrote: > On Thu, Jan 02, 2014 at 02:45:29PM +0100, Hans de Goede wrote: > > >Also, instead of inventing yet another vendor-specific property, why not > > >re-use > > >a button binding similar to gpio-keys like: > > > > > >lradc: lradc

[linux-sunxi] Re: [PATCH 1/4] input: Add new sun4i-lradc-keys drivers

2014-01-02 Thread Hans de Goede
Hi, On 01/02/2014 09:20 PM, Maxime Ripard wrote: On Thu, Jan 02, 2014 at 02:45:29PM +0100, Hans de Goede wrote: Also, instead of inventing yet another vendor-specific property, why not re-use a button binding similar to gpio-keys like: lradc: lradc@01c22800 { compatible

[linux-sunxi] Re: [PATCH 1/4] input: Add new sun4i-lradc-keys drivers

2014-01-02 Thread Maxime Ripard
On Thu, Jan 02, 2014 at 02:45:29PM +0100, Hans de Goede wrote: > >Also, instead of inventing yet another vendor-specific property, why not > >re-use > >a button binding similar to gpio-keys like: > > > >lradc: lradc@01c22800 { > >compatible = "allwinner,sun4i-lradc-keys"; >

[linux-sunxi] Re: [PATCH 1/4] input: Add new sun4i-lradc-keys drivers

2014-01-02 Thread Heiko Stübner
Hi Hans, Dmitry, Am Donnerstag, 2. Januar 2014, 10:37:47 schrieb Hans de Goede: > Hi, > > On 01/01/2014 09:56 PM, Dmitry Torokhov wrote: > > Hi Hans, > > > > On Wed, Jan 01, 2014 at 08:30:07PM +0100, Hans de Goede wrote: > >> +Required properties: > >> + - compatible: "allwinner,sun4i-lradc-keys

[linux-sunxi] Re: [PATCH 1/4] input: Add new sun4i-lradc-keys drivers

2014-01-02 Thread Hans de Goede
Hi, On 01/02/2014 12:59 PM, Heiko Stübner wrote: Hi Hans, Dmitry, Am Donnerstag, 2. Januar 2014, 10:37:47 schrieb Hans de Goede: Hi, On 01/01/2014 09:56 PM, Dmitry Torokhov wrote: Hi Hans, On Wed, Jan 01, 2014 at 08:30:07PM +0100, Hans de Goede wrote: +Required properties: + - compatible:

[linux-sunxi] Re: [PATCH 1/4] input: Add new sun4i-lradc-keys drivers

2014-01-02 Thread Hans de Goede
Hi, On 01/01/2014 09:56 PM, Dmitry Torokhov wrote: Hi Hans, On Wed, Jan 01, 2014 at 08:30:07PM +0100, Hans de Goede wrote: +Required properties: + - compatible: "allwinner,sun4i-lradc-keys" + - reg: mmio address range of the chip + - interrupts: interrupt to which the chip is connected + - all

[linux-sunxi] Re: [PATCH 1/4] input: Add new sun4i-lradc-keys drivers

2014-01-01 Thread Dmitry Torokhov
Hi Hans, On Wed, Jan 01, 2014 at 08:30:07PM +0100, Hans de Goede wrote: > +Required properties: > + - compatible: "allwinner,sun4i-lradc-keys" > + - reg: mmio address range of the chip > + - interrupts: interrupt to which the chip is connected > + - allwinner,chan0-step: step in mV between keys mu