[linux-sunxi] Re: [PATCH v13 05/14] ASoC: sun4i-codec: Merge sun4i_codec_left_mixer_controls and sun4i_codec_right_mixer_controls into sun4i_codec_mixer_controls.

2017-06-28 Thread Mark Brown
On Mon, Jun 26, 2017 at 09:48:59AM +0800, Chen-Yu Tsai wrote: > On Sat, Jun 24, 2017 at 2:24 PM, Danny Milosavljevic > > +static const struct snd_kcontrol_new sun4i_codec_mixer_controls[] = { > > + SOC_DAPM_DOUBLE("DAC Playback Switch", SUN4I_CODEC_DAC_ACTL, > > +

Re: [linux-sunxi] Re: [PATCH v13 05/14] ASoC: sun4i-codec: Merge sun4i_codec_left_mixer_controls and sun4i_codec_right_mixer_controls into sun4i_codec_mixer_controls.

2017-06-28 Thread Chen-Yu Tsai
On Wed, Jun 28, 2017 at 4:25 PM, Danny Milosavljevic wrote: > Hi, > >> > > -static const struct snd_kcontrol_new sun4i_codec_left_mixer_controls[] >> > > = { >> > > - SOC_DAPM_SINGLE("Left DAC Playback Switch", SUN4I_CODEC_DAC_ACTL, >> > > -

Re: [linux-sunxi] Re: [PATCH v13 05/14] ASoC: sun4i-codec: Merge sun4i_codec_left_mixer_controls and sun4i_codec_right_mixer_controls into sun4i_codec_mixer_controls.

2017-06-28 Thread Danny Milosavljevic
Hi, > > > -static const struct snd_kcontrol_new sun4i_codec_left_mixer_controls[] = > > > { > > > - SOC_DAPM_SINGLE("Left DAC Playback Switch", SUN4I_CODEC_DAC_ACTL, > > > - SUN4I_CODEC_DAC_ACTL_LDACLMIXS, 1, 0), > > > -}; > > > - > > > -static const struct

[linux-sunxi] Re: [PATCH v13 05/14] ASoC: sun4i-codec: Merge sun4i_codec_left_mixer_controls and sun4i_codec_right_mixer_controls into sun4i_codec_mixer_controls.

2017-06-26 Thread Maxime Ripard
On Mon, Jun 26, 2017 at 09:48:59AM +0800, Chen-Yu Tsai wrote: > On Sat, Jun 24, 2017 at 2:24 PM, Danny Milosavljevic > wrote: > > Since it's now possible to have a DAPM mixer control with multiple channels, > > use it to cut down the total number of controls. > > > >

[linux-sunxi] Re: [PATCH v13 05/14] ASoC: sun4i-codec: Merge sun4i_codec_left_mixer_controls and sun4i_codec_right_mixer_controls into sun4i_codec_mixer_controls.

2017-06-25 Thread Chen-Yu Tsai
On Sat, Jun 24, 2017 at 2:24 PM, Danny Milosavljevic wrote: > Since it's now possible to have a DAPM mixer control with multiple channels, > use it to cut down the total number of controls. > > Signed-off-by: Danny Milosavljevic > --- >