[linux-sunxi] Re: [PATCH v2 02/10] pinctrl: axp209: add pinctrl features (fwd)

2017-09-29 Thread Julia Lawall
On Fri, 29 Sep 2017, Quentin Schulz wrote: > Hi Julia, > > On 29/09/2017 14:15, Julia Lawall wrote: > > I'm not sure that it is allowed to do krealloc on devm allocated data. > > See lins 468 and 485. > > > > Indeed, from a glance at the code, it does not look like it is a good idea. > > For

[linux-sunxi] Re: [PATCH v2 02/10] pinctrl: axp209: add pinctrl features (fwd)

2017-09-29 Thread Quentin Schulz
Hi Julia, On 29/09/2017 14:15, Julia Lawall wrote: > I'm not sure that it is allowed to do krealloc on devm allocated data. > See lins 468 and 485. > Indeed, from a glance at the code, it does not look like it is a good idea. For v3, this piece of code will be deleted anyway so it won't be a

[linux-sunxi] Re: [PATCH v2 02/10] pinctrl: axp209: add pinctrl features

2017-09-27 Thread Maxime Ripard
On Tue, Sep 26, 2017 at 01:37:37PM +, Quentin Schulz wrote: > On 26/09/2017 15:27, Maxime Ripard wrote: > > On Tue, Sep 26, 2017 at 01:08:21PM +, Quentin Schulz wrote: > >> Hi Maxime, > >> > >> On 26/09/2017 15:00, Maxime Ripard wrote: > >>> On Tue, Sep 26, 2017 at 12:17:12PM +,

[linux-sunxi] Re: [PATCH v2 02/10] pinctrl: axp209: add pinctrl features

2017-09-26 Thread Quentin Schulz
On 26/09/2017 15:27, Maxime Ripard wrote: > On Tue, Sep 26, 2017 at 01:08:21PM +, Quentin Schulz wrote: >> Hi Maxime, >> >> On 26/09/2017 15:00, Maxime Ripard wrote: >>> On Tue, Sep 26, 2017 at 12:17:12PM +, Quentin Schulz wrote: +static const struct axp20x_desc_pin axp209_pins[] = {

[linux-sunxi] Re: [PATCH v2 02/10] pinctrl: axp209: add pinctrl features

2017-09-26 Thread Maxime Ripard
On Tue, Sep 26, 2017 at 01:08:21PM +, Quentin Schulz wrote: > Hi Maxime, > > On 26/09/2017 15:00, Maxime Ripard wrote: > > On Tue, Sep 26, 2017 at 12:17:12PM +, Quentin Schulz wrote: > >> +static const struct axp20x_desc_pin axp209_pins[] = { > >> + AXP20X_PIN(AXP20X_PINCTRL_PIN(0,

[linux-sunxi] Re: [PATCH v2 02/10] pinctrl: axp209: add pinctrl features

2017-09-26 Thread Quentin Schulz
Hi Maxime, On 26/09/2017 15:00, Maxime Ripard wrote: > On Tue, Sep 26, 2017 at 12:17:12PM +, Quentin Schulz wrote: >> +static const struct axp20x_desc_pin axp209_pins[] = { >> +AXP20X_PIN(AXP20X_PINCTRL_PIN(0, "GPIO0"), >> + AXP20X_FUNCTION(0x0, "gpio_out"), >> +

[linux-sunxi] Re: [PATCH v2 02/10] pinctrl: axp209: add pinctrl features

2017-09-26 Thread Maxime Ripard
On Tue, Sep 26, 2017 at 12:17:12PM +, Quentin Schulz wrote: > +static const struct axp20x_desc_pin axp209_pins[] = { > + AXP20X_PIN(AXP20X_PINCTRL_PIN(0, "GPIO0"), > +AXP20X_FUNCTION(0x0, "gpio_out"), > +AXP20X_FUNCTION(0x2, "gpio_in"), > +