[linux-sunxi] Re: [PATCH v5 05/20] Input: axp20x-pek: Bail out if AXP has no interrupt line connected

2021-01-28 Thread Mark Brown
On Thu, Jan 28, 2021 at 12:31:36PM +, Andre Przywara wrote: > Mark Brown wrote: > > It sounds like you're trying to register an IRQ chip with a somehow > > bogus configuration? > I patched the AXP MFD driver [1] to skip the regmap-irq creation when no > interrupts DT property was found, but

[linux-sunxi] Re: [PATCH v5 05/20] Input: axp20x-pek: Bail out if AXP has no interrupt line connected

2021-01-28 Thread Andre Przywara
On Thu, 28 Jan 2021 11:36:01 + Mark Brown wrote: > On Thu, Jan 28, 2021 at 11:11:28AM +, Andre Przywara wrote: > > Dmitry Torokhov wrote: > > > On Wed, Jan 27, 2021 at 05:24:45PM +, Andre Przywara wrote: > > > > > Check for the regmap_irqc member to be not NULL before proceeding

[linux-sunxi] Re: [PATCH v5 05/20] Input: axp20x-pek: Bail out if AXP has no interrupt line connected

2021-01-28 Thread Mark Brown
On Thu, Jan 28, 2021 at 11:11:28AM +, Andre Przywara wrote: > Dmitry Torokhov wrote: > > On Wed, Jan 27, 2021 at 05:24:45PM +, Andre Przywara wrote: > > > Check for the regmap_irqc member to be not NULL before proceeding with > > > probe. This gets normally filled by the call to regmap_ad

[linux-sunxi] Re: [PATCH v5 05/20] Input: axp20x-pek: Bail out if AXP has no interrupt line connected

2021-01-28 Thread Andre Przywara
On Wed, 27 Jan 2021 11:42:15 -0800 Dmitry Torokhov wrote: Hi Dmitry, thanks for your feedback! > On Wed, Jan 27, 2021 at 05:24:45PM +, Andre Przywara wrote: > > On at least one board (Orangepi Zero2) the AXP305 PMIC does not have its > > interrupt line connected to the CPU (mostly because t

[linux-sunxi] Re: [PATCH v5 05/20] Input: axp20x-pek: Bail out if AXP has no interrupt line connected

2021-01-27 Thread Dmitry Torokhov
Hi Andre, On Wed, Jan 27, 2021 at 05:24:45PM +, Andre Przywara wrote: > On at least one board (Orangepi Zero2) the AXP305 PMIC does not have its > interrupt line connected to the CPU (mostly because the H616 SoC does > not feature an NMI pin anymore). > After allowing the AXP driver to proceed