[linux-sunxi] Re: [PATCH v5 1/7] drm: sunxi: Add a basic DRM driver for Allwinner DE2

2016-11-17 Thread Jean-Francois Moine
On Wed, 16 Nov 2016 22:33:06 +0100 Maxime Ripard wrote: > > > > The Device Engine just handles the planes of the LCDs, but, indeed, > > > > the LCDs must know about the DE and the DE must know about the LCDs. > > > > There are 2 ways to realize this knowledge in

[linux-sunxi] Re: [PATCH v5 1/7] drm: sunxi: Add a basic DRM driver for Allwinner DE2

2016-11-16 Thread Maxime Ripard
On Tue, Nov 08, 2016 at 03:37:52PM +0100, Jean-Francois Moine wrote: > On Mon, 7 Nov 2016 23:37:41 +0100 > Maxime Ripard wrote: > > > Hi, > > > > On Fri, Oct 28, 2016 at 07:34:20PM +0200, Jean-Francois Moine wrote: > > > On Fri, 28 Oct 2016 00:03:16 +0200 > > >

[linux-sunxi] Re: [PATCH v5 1/7] drm: sunxi: Add a basic DRM driver for Allwinner DE2

2016-11-08 Thread Jean-Francois Moine
On Mon, 7 Nov 2016 23:37:41 +0100 Maxime Ripard wrote: > Hi, > > On Fri, Oct 28, 2016 at 07:34:20PM +0200, Jean-Francois Moine wrote: > > On Fri, 28 Oct 2016 00:03:16 +0200 > > Maxime Ripard wrote: [snip] > > > > >

[linux-sunxi] Re: [PATCH v5 1/7] drm: sunxi: Add a basic DRM driver for Allwinner DE2

2016-11-07 Thread Maxime Ripard
Hi, On Fri, Oct 28, 2016 at 07:34:20PM +0200, Jean-Francois Moine wrote: > On Fri, 28 Oct 2016 00:03:16 +0200 > Maxime Ripard wrote: > > > On Tue, Oct 25, 2016 at 04:14:41PM +0200, Jean-Francois Moine wrote: > > > > > +Display controller > > > > >

[linux-sunxi] Re: [PATCH v5 1/7] drm: sunxi: Add a basic DRM driver for Allwinner DE2

2016-10-30 Thread Rob Herring
On Fri, Oct 21, 2016 at 09:26:18AM +0200, Jean-Francois Moine wrote: > Allwinner's recent SoCs, as A64, A83T and H3, contain a new display > engine, DE2. > This patch adds a DRM video driver for this device. > > Signed-off-by: Jean-Francois Moine > --- >

[linux-sunxi] Re: [PATCH v5 1/7] drm: sunxi: Add a basic DRM driver for Allwinner DE2

2016-10-30 Thread Rob Herring
On Tue, Oct 25, 2016 at 04:14:41PM +0200, Jean-Francois Moine wrote: > On Mon, 24 Oct 2016 16:04:19 +0200 > Maxime Ripard wrote: > > > Hi, > > Hi Maxime, > > > On Fri, Oct 21, 2016 at 09:26:18AM +0200, Jean-Francois Moine wrote: > > > Allwinner's recent SoCs,

[linux-sunxi] Re: [PATCH v5 1/7] drm: sunxi: Add a basic DRM driver for Allwinner DE2

2016-10-28 Thread Jean-Francois Moine
On Fri, 28 Oct 2016 00:03:16 +0200 Maxime Ripard wrote: > On Tue, Oct 25, 2016 at 04:14:41PM +0200, Jean-Francois Moine wrote: > > > > +Display controller > > > > +== > > > > + > > > > +Required properties: > > > > + > > > > +- compatible: value

[linux-sunxi] Re: [PATCH v5 1/7] drm: sunxi: Add a basic DRM driver for Allwinner DE2

2016-10-27 Thread Maxime Ripard
On Tue, Oct 25, 2016 at 04:14:41PM +0200, Jean-Francois Moine wrote: > > > +Display controller > > > +== > > > + > > > +Required properties: > > > + > > > +- compatible: value should be one of the following > > > + "allwinner,sun8i-a83t-display-engine" > > > +

Re: [linux-sunxi] Re: [PATCH v5 1/7] drm: sunxi: Add a basic DRM driver for Allwinner DE2

2016-10-25 Thread André Przywara
On 25/10/16 15:14, Jean-Francois Moine wrote: > On Mon, 24 Oct 2016 16:04:19 +0200 > Maxime Ripard wrote: > >> Hi, > > Hi Maxime, > >> On Fri, Oct 21, 2016 at 09:26:18AM +0200, Jean-Francois Moine wrote: >>> Allwinner's recent SoCs, as A64, A83T and H3,

[linux-sunxi] Re: [PATCH v5 1/7] drm: sunxi: Add a basic DRM driver for Allwinner DE2

2016-10-25 Thread Jean-Francois Moine
On Tue, 25 Oct 2016 08:44:22 +0200 Daniel Vetter wrote: > > + /* start the subdevices */ > > + ret = component_bind_all(dev, drm); > > + if (ret < 0) > > + goto out2; > > + > > + ret = drm_dev_register(drm, 0); > > This needs to be the very last step in your

[linux-sunxi] Re: [PATCH v5 1/7] drm: sunxi: Add a basic DRM driver for Allwinner DE2

2016-10-25 Thread Jean-Francois Moine
On Mon, 24 Oct 2016 16:04:19 +0200 Maxime Ripard wrote: > Hi, Hi Maxime, > On Fri, Oct 21, 2016 at 09:26:18AM +0200, Jean-Francois Moine wrote: > > Allwinner's recent SoCs, as A64, A83T and H3, contain a new display > > engine, DE2. > > This patch adds a DRM

[linux-sunxi] Re: [PATCH v5 1/7] drm: sunxi: Add a basic DRM driver for Allwinner DE2

2016-10-25 Thread Daniel Vetter
On Tue, Oct 25, 2016 at 08:44:22AM +0200, Daniel Vetter wrote: > On Fri, Oct 21, 2016 at 09:26:18AM +0200, Jean-Francois Moine wrote: > > +static int de2_drm_bind(struct device *dev) > > +{ > > + struct drm_device *drm; > > + struct priv *priv; > > + int ret; > > + > > + drm =

[linux-sunxi] Re: [PATCH v5 1/7] drm: sunxi: Add a basic DRM driver for Allwinner DE2

2016-10-25 Thread Daniel Vetter
On Fri, Oct 21, 2016 at 09:26:18AM +0200, Jean-Francois Moine wrote: > +static int de2_drm_bind(struct device *dev) > +{ > + struct drm_device *drm; > + struct priv *priv; > + int ret; > + > + drm = drm_dev_alloc(_drm_driver, dev); > + if (!drm) > + return -ENOMEM;

[linux-sunxi] Re: [PATCH v5 1/7] drm: sunxi: Add a basic DRM driver for Allwinner DE2

2016-10-24 Thread Maxime Ripard
Hi, On Fri, Oct 21, 2016 at 09:26:18AM +0200, Jean-Francois Moine wrote: > Allwinner's recent SoCs, as A64, A83T and H3, contain a new display > engine, DE2. > This patch adds a DRM video driver for this device. > > Signed-off-by: Jean-Francois Moine Output from checkpatch: