[linux-sunxi] Re: [PATCH v7 4/8] ARM: sunxi: Add driver for SD/MMC hosts found on Allwinner sunxi SoCs

2014-02-22 Thread Maxime Ripard
Hi Hans, (As a side note, your mailer just did something nasty with the wrapping which made the code snippets totally unreadable. I'm going to drop them.) On Wed, Feb 19, 2014 at 01:14:58PM +0100, Hans de Goede wrote: +wmb(); /* Ensure idma_des hit main mem before we start the idmac

[linux-sunxi] Re: [PATCH v7 4/8] ARM: sunxi: Add driver for SD/MMC hosts found on Allwinner sunxi SoCs

2014-02-19 Thread Maxime Ripard
Hi Hans, On Tue, Feb 18, 2014 at 09:49:21PM +0100, Hans de Goede wrote: Hi, On 02/18/2014 04:37 PM, Maxime Ripard wrote: snip + + for (i = 0; i data-sg_len; i++) { + pdes[i].config = SDXC_IDMAC_DES0_CH | SDXC_IDMAC_DES0_OWN | +

[linux-sunxi] Re: [PATCH v7 4/8] ARM: sunxi: Add driver for SD/MMC hosts found on Allwinner sunxi SoCs

2014-02-19 Thread Hans de Goede
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 Hi, On 02/19/2014 10:46 AM, Maxime Ripard wrote: Hi Hans, On Tue, Feb 18, 2014 at 09:49:21PM +0100, Hans de Goede wrote: Hi, On 02/18/2014 04:37 PM, Maxime Ripard wrote: snip + +for (i = 0; i data-sg_len; i++) { +

[linux-sunxi] Re: [PATCH v7 4/8] ARM: sunxi: Add driver for SD/MMC hosts found on Allwinner sunxi SoCs

2014-02-18 Thread Maxime Ripard
Hi, Sorry for taking a bit of time to review this. On Mon, Feb 17, 2014 at 11:02:34AM +0100, David Lanzendörfer wrote: This is based on the driver Allwinner ships in their Android kernel sources. Initial porting to upstream kernels done by David Lanzendörfer, additional fixes and cleanups

[linux-sunxi] Re: [PATCH v7 4/8] ARM: sunxi: Add driver for SD/MMC hosts found on Allwinner sunxi SoCs

2014-02-18 Thread Hans de Goede
Hi, On 02/18/2014 04:37 PM, Maxime Ripard wrote: snip + + for (i = 0; i data-sg_len; i++) { + pdes[i].config = SDXC_IDMAC_DES0_CH | SDXC_IDMAC_DES0_OWN | +SDXC_IDMAC_DES0_DIC; + + if (data-sg[i].length == max_len) +