[linux-sunxi] Re: [PATCH v11 4/7] drm/sun4i: dsi: Handle bus clock explicitly
Hi,
On Fri, Nov 22, 2019 at 11:48 PM Maxime Ripard wrote:
>
> Hi,
>
> On Thu, Nov 21, 2019 at 05:24:47PM +0530, Jagan Teki wrote:
> > On Sun, Nov 3, 2019 at 11:02 PM Maxime Ripard wrote:
> > >
> > > On Fri, Nov 01, 2019 at 07:42:55PM +0530, Jagan Teki wrote:
> > > > Hi Maxime,
> > > >
> > > > On Tue, Oct 29, 2019 at 2:24 PM Maxime Ripard
> > > > wrote:
> > > > >
> > > > > On Tue, Oct 29, 2019 at 04:03:56AM +0530, Jagan Teki wrote:
> > > > > > > > explicit handling of common clock would require since the A64
> > > > > > > > doesn't need to mention the clock-names explicitly in dts since
> > > > > > > > it
> > > > > > > > support only one bus clock.
> > > > > > > >
> > > > > > > > Also pass clk_id NULL instead "bus" to regmap clock init
> > > > > > > > function
> > > > > > > > since the single clock variants no need to mention clock-names
> > > > > > > > explicitly.
> > > > > > >
> > > > > > > You don't need explicit clock handling. Passing NULL as the
> > > > > > > argument
> > > > > > > in regmap_init_mmio_clk will make it use the first clock, which
> > > > > > > is the
> > > > > > > bus clock.
> > > > > >
> > > > > > Indeed I tried that, since NULL clk_id wouldn't enable the bus clock
> > > > > > during regmap_mmio_gen_context code, passing NULL triggering vblank
> > > > > > timeout.
> > > > >
> > > > > There's a bunch of users of NULL in tree, so finding out why NULL
> > > > > doesn't work is the way forward.
> > > >
> > > > I'd have looked the some of the users before checking the code as
> > > > well. As I said passing NULL clk_id to devm_regmap_init_mmio_clk =>
> > > > __devm_regmap_init_mmio_clk would return before processing the clock.
> > > >
> > > > Here is the code snippet on the tree just to make sure I'm on the same
> > > > page or not.
> > > >
> > > > static struct regmap_mmio_context *regmap_mmio_gen_context(struct
> > > > device *dev,
> > > > const char *clk_id,
> > > > void __iomem *regs,
> > > > const struct regmap_config
> > > > *config)
> > > > {
> > > > ---
> > > > --
> > > > if (clk_id == NULL)
> > > > return ctx;
> > > >
> > > > ctx->clk = clk_get(dev, clk_id);
> > > > if (IS_ERR(ctx->clk)) {
> > > > ret = PTR_ERR(ctx->clk);
> > > > goto err_free;
> > > > }
> > > >
> > > > ret = clk_prepare(ctx->clk);
> > > > if (ret < 0) {
> > > > clk_put(ctx->clk);
> > > > goto err_free;
> > > > }
> > > > -
> > > > ---
> > > > }
> > > >
> > > > Yes, I did check on the driver in the tree before committing explicit
> > > > clock handle, which make similar requirements like us in [1]. this
> > > > imx2 wdt driver is handling the explicit clock as well. I'm sure this
> > > > driver is updated as I have seen few changes related to this driver in
> > > > ML.
> > >
> > > I guess we have two ways to go at this then.
> > >
> > > Either we remove the return, but it might have a few side-effects, or
> > > we call clk_get with NULL or bus depending on the case, and then call
> > > regmap_mmio_attach_clk.
> >
> > Thanks for the inputs.
> >
> > Please have a look at this snippet, I have used your second
> > suggestions. let me know if you have any comments?
> >
> > diff --git a/drivers/gpu/drm/sun4i/sun6i_mipi_dsi.c
> > b/drivers/gpu/drm/sun4i/sun6i_mipi_dsi.c
> > index 8fa90cfc2ac8..91c95e56d870 100644
> > --- a/drivers/gpu/drm/sun4i/sun6i_mipi_dsi.c
> > +++ b/drivers/gpu/drm/sun4i/sun6i_mipi_dsi.c
> > @@ -1109,24 +1109,36 @@ static int sun6i_dsi_probe(struct platform_device
> > *pdev)
> > return PTR_ERR(dsi->regulator);
> > }
> >
> > -dsi->regs = devm_regmap_init_mmio_clk(dev, "bus", base,
> > - _dsi_regmap_config);
> > -if (IS_ERR(dsi->regs)) {
> > -dev_err(dev, "Couldn't create the DSI encoder regmap\n");
> > -return PTR_ERR(dsi->regs);
> > -}
> > -
> > dsi->reset = devm_reset_control_get_shared(dev, NULL);
> > if (IS_ERR(dsi->reset)) {
> > dev_err(dev, "Couldn't get our reset line\n");
> > return PTR_ERR(dsi->reset);
> > }
> >
> > +dsi->regs = regmap_init_mmio(dev, base, _dsi_regmap_config);
>
> You should use the devm variant here
Sure.
>
> > +if (IS_ERR(dsi->regs)) {
> > +dev_err(dev, "Couldn't init regmap\n");
> > +return PTR_ERR(dsi->regs);
> > +}
> > +
> > +dsi->bus_clk = devm_clk_get(dev, NULL);
>
> I guess you still need to pass 'bus' here?
But the idea here is not to specify clock name explicitly to support
A64. otherwise A64 would fail as we are not specifying the clock-names
explicitly on dsi node.
dsi: dsi@1ca {
compatible = "allwinner,sun50i-a64-mipi-dsi";
reg = <0x01ca 0x1000>;
[linux-sunxi] Re: [PATCH] crypto: allwinner: sun8i-ce: enable working on big endian
On Sun, Nov 17, 2019 at 05:07:45PM +0100, Corentin Labbe wrote:
> On big endian kernel, the sun8i-ce crypto driver does not works.
> This patch do the necessary modification to permit it to work on BE
> kernel (setting descriptor entries as __le32 and adding some cpu_to_le32)
>
> Fixes: 06f751b61329 ("crypto: allwinner - Add sun8i-ce Crypto Engine")
> Signed-off-by: Corentin Labbe
> ---
> .../allwinner/sun8i-ce/sun8i-ce-cipher.c | 50 +++
> drivers/crypto/allwinner/sun8i-ce/sun8i-ce.h | 24 -
> 2 files changed, 40 insertions(+), 34 deletions(-)
Patch applied. Thanks.
--
Email: Herbert Xu
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt
--
You received this message because you are subscribed to the Google Groups
"linux-sunxi" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to linux-sunxi+unsubscr...@googlegroups.com.
To view this discussion on the web, visit
https://groups.google.com/d/msgid/linux-sunxi/20191122111018.uss7n573hdtmx6ed%40gondor.apana.org.au.
[linux-sunxi] Re: [PATCH] crypto: sun4i-ss: fix big endian issues
On Thu, Nov 14, 2019 at 01:58:49PM +0100, Corentin Labbe wrote:
> When testing BigEndian kernel, the sun4i-ss was failling all crypto
> tests.
> This patch fix endian issues with it.
>
> Fixes: 6298e948215f ("crypto: sunxi-ss - Add Allwinner Security System crypto
> accelerator")
> Signed-off-by: Corentin Labbe
> ---
> .../crypto/allwinner/sun4i-ss/sun4i-ss-hash.c | 21 ++-
> 1 file changed, 11 insertions(+), 10 deletions(-)
Patch applied. Thanks.
--
Email: Herbert Xu
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt
--
You received this message because you are subscribed to the Google Groups
"linux-sunxi" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to linux-sunxi+unsubscr...@googlegroups.com.
To view this discussion on the web, visit
https://groups.google.com/d/msgid/linux-sunxi/20191122110407.dwccsgxn72dcupa4%40gondor.apana.org.au.
[linux-sunxi] Re: [PATCH] crypto: sun4i-ss: hide the Invalid keylen message
On Thu, Nov 14, 2019 at 11:58:52AM +0100, Corentin Labbe wrote: > Drop the "Invalid keylen" message to debug level, it adds no value, and > when CRYPTO_EXTRA_TEST is enabled, it floods the console. > > Signed-off-by: Corentin Labbe > --- > drivers/crypto/allwinner/sun4i-ss/sun4i-ss-cipher.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) Patch applied. Thanks. -- Email: Herbert Xu Home Page: http://gondor.apana.org.au/~herbert/ PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt -- You received this message because you are subscribed to the Google Groups "linux-sunxi" group. To unsubscribe from this group and stop receiving emails from it, send an email to linux-sunxi+unsubscr...@googlegroups.com. To view this discussion on the web, visit https://groups.google.com/d/msgid/linux-sunxi/20191122110401.2kgx7fenlny5gbgj%40gondor.apana.org.au.
[linux-sunxi] Re: [PATCH] crypto: sun4i-ss: use crypto_ahash_digestsize
On Thu, Nov 14, 2019 at 11:58:13AM +0100, Corentin Labbe wrote: > The size of the digest is different between MD5 and SHA1 so instead of > using the higher value (5 words), let's use crypto_ahash_digestsize(). > > Signed-off-by: Corentin Labbe > --- > drivers/crypto/allwinner/sun4i-ss/sun4i-ss-hash.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) Patch applied. Thanks. -- Email: Herbert Xu Home Page: http://gondor.apana.org.au/~herbert/ PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt -- You received this message because you are subscribed to the Google Groups "linux-sunxi" group. To unsubscribe from this group and stop receiving emails from it, send an email to linux-sunxi+unsubscr...@googlegroups.com. To view this discussion on the web, visit https://groups.google.com/d/msgid/linux-sunxi/20191122110356.5vtsqyy7iddh7oo4%40gondor.apana.org.au.
[linux-sunxi] Re: [PATCH 1/2] crypto: sun4i-ss: Fix 64-bit size_t warnings on sun4i-ss-hash.c
On Thu, Nov 14, 2019 at 11:49:06AM +0100, Corentin Labbe wrote: > If you try to compile this driver on a 64-bit platform then you > will get warnings because it mixes size_t with unsigned int which > only works on 32-bit. > > This patch fixes all of the warnings on sun4i-ss-hash.c. > Signed-off-by: Corentin Labbe > --- > drivers/crypto/allwinner/sun4i-ss/sun4i-ss-hash.c | 12 ++-- > 1 file changed, 6 insertions(+), 6 deletions(-) All applied. Thanks. -- Email: Herbert Xu Home Page: http://gondor.apana.org.au/~herbert/ PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt -- You received this message because you are subscribed to the Google Groups "linux-sunxi" group. To unsubscribe from this group and stop receiving emails from it, send an email to linux-sunxi+unsubscr...@googlegroups.com. To view this discussion on the web, visit https://groups.google.com/d/msgid/linux-sunxi/20191122110344.u6euqg3vecgqyrs4%40gondor.apana.org.au.
