[linux-sunxi] Re: [PATCH 1/3] Input: axp20x-pek - Remove unique wakeup event handling

2020-01-13 Thread Hans de Goede
Hi, On 13-01-2020 04:20, Samuel Holland wrote: This driver attempts to avoid reporting wakeup events to userspace by clearing a possible pending IRQ before IRQs are enabled during resume. The assumption seems to be that userspace cannot cope with a KEY_POWER press during resume. However, no

[linux-sunxi] Re: [PATCH 2/3] Input: axp20x-pek - Respect userspace wakeup configuration

2020-01-13 Thread Hans de Goede
Hi, On 13-01-2020 04:20, Samuel Holland wrote: Unlike most other power button drivers, this driver unconditionally enables its wakeup IRQ. It should be using device_may_wakeup() to respect the userspace configuration of wakeup sources. Because the AXP20x MFD device uses regmap-irq, the AXP20x

[linux-sunxi] Re: [PATCH 1/3] Input: axp20x-pek - Remove unique wakeup event handling

2020-01-13 Thread Hans de Goede
On 13-01-2020 11:41, Hans de Goede wrote: Hi, On 13-01-2020 04:20, Samuel Holland wrote: This driver attempts to avoid reporting wakeup events to userspace by clearing a possible pending IRQ before IRQs are enabled during resume. The assumption seems to be that userspace cannot cope with a

[linux-sunxi] Re: [PATCH v6 2/6] mailbox: sun6i-msgbox: Add a new mailbox driver

2020-01-13 Thread Philipp Zabel
On Sun, 2020-01-12 at 23:18 -0600, Samuel Holland wrote: > Allwinner sun6i, sun8i, sun9i, and sun50i SoCs contain a hardware > message box used for communication between the ARM CPUs and the ARISC > management coprocessor. This mailbox contains 8 unidirectional > 4-message FIFOs. > > Add a driver

[linux-sunxi] Re: [PATCH 3/3] Input: axp20x-pek - Enable wakeup for all AXP variants

2020-01-13 Thread Hans de Goede
Hi, On 13-01-2020 04:20, Samuel Holland wrote: There are many devices, including several mobile battery-powered devices, using other AXP variants as their PMIC. Enable them to use the power key as a wakeup source. Signed-off-by: Samuel Holland Patch looks good to me: Reviewed-by: Hans de

[linux-sunxi] [PATCH] arm64: dts: allwinner: h6: tanix-tx6: Use internal oscillator

2020-01-13 Thread Jernej Skrabec
Tanix TX6 doesn't have external 32 kHz oscillator, so switch RTC clock to internal one. Signed-off-by: Jernej Skrabec --- While this patch gives one possible solution, I mainly want to start discussion why Allwinner SoC dtsi reference external 32 kHz crystal although some boards don't have it.

[linux-sunxi] Re: [PATCH 9/9] arm64: dts: allwinner: Move wakeup-capable IRQs to r_intc

2020-01-13 Thread pune
Hi Samuel I am using Banana bi bsp for android which in turn using lichee kernel 3.10 where i am not able bring up device from deep sleep state by pressing power button, i can see the power button irq is configured for GIC parent. Could you please let me know how to make this irq en-route to

[linux-sunxi] Re: [PATCH 3/3] Input: axp20x-pek - Enable wakeup for all AXP variants

2020-01-13 Thread Dmitry Torokhov
Hi Samuel, On Sun, Jan 12, 2020 at 09:20:32PM -0600, Samuel Holland wrote: > There are many devices, including several mobile battery-powered > devices, using other AXP variants as their PMIC. Enable them to use > the power key as a wakeup source. Are these X86 or ARM devices? If anything, I'd

[linux-sunxi] Re: [PATCH v6 1/6] dt-bindings: mailbox: Add a sun6i message box binding

2020-01-13 Thread Rob Herring
On Sun, 12 Jan 2020 23:18:47 -0600, Samuel Holland wrote: > This mailbox hardware is present in Allwinner sun6i, sun8i, sun9i, and > sun50i SoCs. Add a device tree binding for it. > > Signed-off-by: Samuel Holland > --- > .../mailbox/allwinner,sun6i-a31-msgbox.yaml | 80 +++ >

[linux-sunxi] Re: [PATCH 2/3] Input: axp20x-pek - Respect userspace wakeup configuration

2020-01-13 Thread Dmitry Torokhov
On Mon, Jan 13, 2020 at 11:48:35AM +0100, Hans de Goede wrote: > Hi, > > On 13-01-2020 04:20, Samuel Holland wrote: > > Unlike most other power button drivers, this driver unconditionally > > enables its wakeup IRQ. It should be using device_may_wakeup() to > > respect the userspace configuration

[linux-sunxi] Re: [PATCH v3 0/8] X-Powers Power Supply Improvements

2020-01-13 Thread Sebastian Reichel
Hi, I queued patches 1-4, patch 5 does not apply and seems to be based on an older tree. -- Sebastian On Sun, Jan 12, 2020 at 09:53:02PM -0600, Samuel Holland wrote: > This series adds some improvements to the axp20x* power supply drivers > to better support suspend/resume and use on mobile

Re: [linux-sunxi] Re: [PATCH 9/9] arm64: dts: allwinner: Move wakeup-capable IRQs to r_intc

2020-01-13 Thread Samuel Holland
Hello, On 1/13/20 11:30 AM, pune wrote: > I am using Banana bi bsp for android which in turn using lichee kernel 3.10 Unfortunately, this is the reason you are not getting much help. The BSP kernel works very differently from mainline Linux, especially with regard to power management. Allwinner