[linux-sunxi] Re: [PATCH 2/6] clk: sunxi: Move the 24M oscillator to a file of its own

2014-05-10 Thread Maxime Ripard
On Sat, May 10, 2014 at 01:46:38PM -0300, Emilio López wrote: There was probably something interesting here, but both the messages you sent are full of empty :) -- Maxime Ripard, Free Electrons Embedded Linux, Kernel and Android engineering http://free-electrons.com signature.asc Description

[linux-sunxi] Re: [PATCH v12 0/6] ARM: sunxi: Add driver for SD/MMC hosts found on Allwinner sunxi SoCs

2014-05-11 Thread Maxime Ripard
patches. Thanks! Maxime -- Maxime Ripard, Free Electrons Embedded Linux, Kernel and Android engineering http://free-electrons.com signature.asc Description: Digital signature

[linux-sunxi] Re: [PATCH v4 0/2] input: Add new sun4i-ts driver for Allwinner sunxi SoC's rtp controller

2014-05-11 Thread Maxime Ripard
, and the sun?i*.dts changes to enable this have already been upstreamed. For both patches, Acked-by: Maxime Ripard maxime.rip...@free-electrons.com Thanks! Maxime -- Maxime Ripard, Free Electrons Embedded Linux, Kernel and Android engineering http://free-electrons.com signature.asc Description: Digital

[linux-sunxi] Re: [PATCHv2 4/4] ARM: sun7i: dt: Add MMC support to pcDuino3 DTS

2014-05-11 Thread Maxime Ripard
; + }; + You should set the vmmc-supply property here, like in http://lists.infradead.org/pipermail/linux-arm-kernel/2014-May/255064.html Thanks, Maxime -- Maxime Ripard, Free Electrons Embedded Linux, Kernel and Android engineering http://free-electrons.com signature.asc

Re: [linux-sunxi] [PATCH v2 3/7] phy: usb: sunxi: Introduce Allwinner A31 USB PHY support

2014-05-12 Thread Maxime Ripard
On Mon, May 12, 2014 at 05:14:26PM +0800, Chen-Yu Tsai wrote: Hi, On Sat, May 10, 2014 at 8:56 PM, Maxime Ripard maxime.rip...@free-electrons.com wrote: The USB phy controller in the A31 differs mostly from the older controllers because it has a clock dedicated for each phy, while

[linux-sunxi] Re: [PATCH] ARM: dts: sun5i: Add new A10s r7 hdmi tv dongle board

2014-05-12 Thread Maxime Ripard
and USB OTG. Signed-off-by: Hans de Goede hdego...@redhat.com Applied, thanks. Maxime -- Maxime Ripard, Free Electrons Embedded Linux, Kernel and Android engineering http://free-electrons.com signature.asc Description: Digital signature

[linux-sunxi] [PATCH v3 1/8] clk: sunxi: Implement A31 USB clock

2014-05-12 Thread Maxime Ripard
The A31 USB clock slightly differ from its older counterparts, mostly because it has a different gate for each PHY, while the older one had a single gate for all the phy. Signed-off-by: Maxime Ripard maxime.rip...@free-electrons.com Reviewed-by: Hans de Goede hdego...@redhat.com --- drivers/clk

[linux-sunxi] [PATCH v3 2/8] ARM: sun6i: Add the USB clocks to the DTSI.

2014-05-12 Thread Maxime Ripard
The USB clocks of the A31 seems to be parented to the 24MHz oscillator, and handle the clocks for the USB phys and OHCI devices. Signed-off-by: Maxime Ripard maxime.rip...@free-electrons.com Reviewed-by: Hans de Goede hdego...@redhat.com --- arch/arm/boot/dts/sun6i-a31.dtsi | 11 +++ 1

[linux-sunxi] [PATCH v3 8/8] ARM: sunxi: dt: add APP4-EVB1 board support

2014-05-12 Thread Maxime Ripard
-electrons.com Signed-off-by: Maxime Ripard maxime.rip...@free-electrons.com Reviewed-by: Hans de Goede hdego...@redhat.com --- arch/arm/boot/dts/Makefile| 1 + arch/arm/boot/dts/sun6i-a31-app4-evb1.dts | 57 +++ 2 files changed, 58 insertions(+) create mode

[linux-sunxi] [PATCH v3 7/8] ARM: sun6i: dt: Add support for the USB controllers

2014-05-12 Thread Maxime Ripard
The A31 has two ECHI/OHCI controllers, and one OHCI-only phy-less controller. Signed-off-by: Maxime Ripard maxime.rip...@free-electrons.com Reviewed-by: Hans de Goede hdego...@redhat.com --- arch/arm/boot/dts/sun6i-a31.dtsi | 77 1 file changed, 77

[linux-sunxi] [PATCH v3 4/8] phy: usb: sunxi: Introduce Allwinner A31 USB PHY support

2014-05-12 Thread Maxime Ripard
The USB phy controller in the A31 differs mostly from the older controllers because it has a clock dedicated for each phy, while the older ones were having a single clock for all the phys. Signed-off-by: Maxime Ripard maxime.rip...@free-electrons.com Reviewed-by: Hans de Goede hdego...@redhat.com

[linux-sunxi] [PATCH v3 0/8] Add Allwinner A31 USB support

2014-05-12 Thread Maxime Ripard
retrieval ARM: sunxi: dt: add APP4-EVB1 board support Maxime Ripard (6): clk: sunxi: Implement A31 USB clock ARM: sun6i: Add the USB clocks to the DTSI. phy: sunxi: Rework phy initialization phy: usb: sunxi: Introduce Allwinner A31 USB PHY support usb: ohci-platform: Enable optional use

[linux-sunxi] [PATCH v3 5/8] usb: ehci-platform: add optional reset controller retrieval

2014-05-12 Thread Maxime Ripard
-off-by: Boris BREZILLON boris.brezil...@free-electrons.com Signed-off-by: Maxime Ripard maxime.rip...@free-electrons.com Reviewed-by: Hans de Goede hdego...@redhat.com --- Documentation/devicetree/bindings/usb/usb-ehci.txt | 1 + drivers/usb/host/ehci-platform.c | 17

Re: [linux-sunxi] [PATCH 3/6] clk: sunxi: Move the GMAC clock to a file of its own

2014-05-12 Thread Maxime Ripard
-- Maxime Ripard, Free Electrons Embedded Linux, Kernel and Android engineering http://free-electrons.com signature.asc Description: Digital signature

[linux-sunxi] [PATCH v4 7/8] ARM: sun6i: dt: Add support for the USB controllers

2014-05-13 Thread Maxime Ripard
The A31 has two ECHI/OHCI controllers, and one OHCI-only phy-less controller. Signed-off-by: Maxime Ripard maxime.rip...@free-electrons.com Reviewed-by: Hans de Goede hdego...@redhat.com --- arch/arm/boot/dts/sun6i-a31.dtsi | 77 1 file changed, 77

[linux-sunxi] [PATCH v4 2/8] ARM: sun6i: Add the USB clocks to the DTSI

2014-05-13 Thread Maxime Ripard
The USB clocks of the A31 seems to be parented to the 24MHz oscillator, and handle the clocks for the USB phys and OHCI devices. Signed-off-by: Maxime Ripard maxime.rip...@free-electrons.com Reviewed-by: Hans de Goede hdego...@redhat.com --- arch/arm/boot/dts/sun6i-a31.dtsi | 11 +++ 1

[linux-sunxi] [PATCH v4 1/8] clk: sunxi: Implement A31 USB clock

2014-05-13 Thread Maxime Ripard
The A31 USB clock slightly differ from its older counterparts, mostly because it has a different gate for each PHY, while the older one had a single gate for all the phy. Signed-off-by: Maxime Ripard maxime.rip...@free-electrons.com Reviewed-by: Hans de Goede hdego...@redhat.com Acked-by: Mike

[linux-sunxi] [PATCH v4 0/8] Add Allwinner A31 USB support

2014-05-13 Thread Maxime Ripard
function instead of the private structure since it was the only user Boris BREZILLON (2): usb: ehci-platform: add optional reset controller retrieval ARM: sunxi: dt: add APP4-EVB1 board support Maxime Ripard (6): clk: sunxi: Implement A31 USB clock ARM: sun6i: Add the USB clocks to the DTSI

[linux-sunxi] [PATCH v4 3/8] phy: sunxi: Rework phy initialization

2014-05-13 Thread Maxime Ripard
Move the phy initialization and variables declaration to the loop itself, since it is where it really belongs. Also remove all the temporary variables, we can use the structure members directly. Signed-off-by: Maxime Ripard maxime.rip...@free-electrons.com Reviewed-by: Hans de Goede hdego

[linux-sunxi] [PATCH v4 5/8] usb: ehci-platform: add optional reset controller retrieval

2014-05-13 Thread Maxime Ripard
-off-by: Boris BREZILLON boris.brezil...@free-electrons.com Signed-off-by: Maxime Ripard maxime.rip...@free-electrons.com Reviewed-by: Hans de Goede hdego...@redhat.com --- Documentation/devicetree/bindings/usb/usb-ehci.txt | 1 + drivers/usb/host/ehci-platform.c | 26

[linux-sunxi] [PATCH v4 4/8] phy: usb: sunxi: Introduce Allwinner A31 USB PHY support

2014-05-13 Thread Maxime Ripard
The USB phy controller in the A31 differs mostly from the older controllers because it has a clock dedicated for each phy, while the older ones were having a single clock for all the phys. Signed-off-by: Maxime Ripard maxime.rip...@free-electrons.com Reviewed-by: Hans de Goede hdego...@redhat.com

[linux-sunxi] [PATCH v4 8/8] ARM: sunxi: dt: add APP4-EVB1 board support

2014-05-13 Thread Maxime Ripard
-electrons.com Signed-off-by: Maxime Ripard maxime.rip...@free-electrons.com Reviewed-by: Hans de Goede hdego...@redhat.com --- arch/arm/boot/dts/Makefile| 1 + arch/arm/boot/dts/sun6i-a31-app4-evb1.dts | 57 +++ 2 files changed, 58 insertions(+) create mode

[linux-sunxi] Re: [PATCH v7] DMA: sun6i: Add driver for the Allwinner A31 DMA controller

2014-05-13 Thread Maxime Ripard
); + + vchan_dma_desc_free_list(vchan-vc, head); shouldn't you kill the tasklet as well here? Just to be clear, which tasklet? vchan's or the driver's? Thanks, Maxime -- Maxime Ripard, Free Electrons Embedded Linux, Kernel and Android engineering http://free-electrons.com signature.asc Description

[linux-sunxi] [PATCH RESEND v4 5/8] usb: ehci-platform: add optional reset controller retrieval

2014-05-13 Thread Maxime Ripard
-off-by: Boris BREZILLON boris.brezil...@free-electrons.com Signed-off-by: Maxime Ripard maxime.rip...@free-electrons.com Reviewed-by: Hans de Goede hdego...@redhat.com Acked-by: Alan Stern st...@rowland.harvard.edu --- Documentation/devicetree/bindings/usb/usb-ehci.txt | 1 + drivers/usb/host/ehci

[linux-sunxi] [PATCH RESEND v4 6/8] usb: ohci-platform: Enable optional use of reset controller

2014-05-13 Thread Maxime Ripard
The OHCI controllers used in the Allwinner A31 are asserted in reset using a global reset controller. Add optional support for such a controller in the OHCI platform driver. Signed-off-by: Maxime Ripard maxime.rip...@free-electrons.com Reviewed-by: Hans de Goede hdego...@redhat.com Acked

[linux-sunxi] [PATCH RESEND v4 3/8] phy: sunxi: Rework phy initialization

2014-05-13 Thread Maxime Ripard
Move the phy initialization and variables declaration to the loop itself, since it is where it really belongs. Also remove all the temporary variables, we can use the structure members directly. Signed-off-by: Maxime Ripard maxime.rip...@free-electrons.com Reviewed-by: Hans de Goede hdego

[linux-sunxi] [PATCH RESEND v4 7/8] ARM: sun6i: dt: Add support for the USB controllers

2014-05-13 Thread Maxime Ripard
The A31 has two ECHI/OHCI controllers, and one OHCI-only phy-less controller. Signed-off-by: Maxime Ripard maxime.rip...@free-electrons.com Reviewed-by: Hans de Goede hdego...@redhat.com --- arch/arm/boot/dts/sun6i-a31.dtsi | 77 1 file changed, 77

[linux-sunxi] [PATCH RESEND v4 0/8] Add Allwinner A31 USB support

2014-05-13 Thread Maxime Ripard
assertion/deassertion to probe/remove - Moved the dedicated_clocks to the probe function instead of the private structure since it was the only user Boris BREZILLON (2): usb: ehci-platform: add optional reset controller retrieval ARM: sunxi: dt: add APP4-EVB1 board support Maxime Ripard

[linux-sunxi] [PATCH RESEND v4 8/8] ARM: sunxi: dt: add APP4-EVB1 board support

2014-05-13 Thread Maxime Ripard
-electrons.com Signed-off-by: Maxime Ripard maxime.rip...@free-electrons.com Reviewed-by: Hans de Goede hdego...@redhat.com --- arch/arm/boot/dts/Makefile| 1 + arch/arm/boot/dts/sun6i-a31-app4-evb1.dts | 57 +++ 2 files changed, 58 insertions(+) create mode

[linux-sunxi] [PATCH RESEND v4 2/8] ARM: sun6i: Add the USB clocks to the DTSI

2014-05-13 Thread Maxime Ripard
The USB clocks of the A31 seems to be parented to the 24MHz oscillator, and handle the clocks for the USB phys and OHCI devices. Signed-off-by: Maxime Ripard maxime.rip...@free-electrons.com Reviewed-by: Hans de Goede hdego...@redhat.com --- arch/arm/boot/dts/sun6i-a31.dtsi | 11 +++ 1

[linux-sunxi] [PATCH RESEND v4 1/8] clk: sunxi: Implement A31 USB clock

2014-05-13 Thread Maxime Ripard
The A31 USB clock slightly differ from its older counterparts, mostly because it has a different gate for each PHY, while the older one had a single gate for all the phy. Signed-off-by: Maxime Ripard maxime.rip...@free-electrons.com Reviewed-by: Hans de Goede hdego...@redhat.com Acked-by: Mike

[linux-sunxi] Re: [PATCH RESEND v4 3/8] phy: sunxi: Rework phy initialization

2014-05-14 Thread Maxime Ripard
On Wed, May 14, 2014 at 11:18:51AM +0530, Kishon Vijay Abraham I wrote: Hi, On Tuesday 13 May 2014 09:14 PM, Maxime Ripard wrote: Move the phy initialization and variables declaration to the loop itself, since it is where it really belongs. Also remove all the temporary variables, we

[linux-sunxi] Re: [PATCH v6 3/3] ARM: sunxi: Add IR controller support in DT on A20

2014-05-14 Thread Maxime Ripard
, ir; + interrupts = 0 6 4; + reg = 0x01C21c00 0x40; You're mixing upper and lower case letters here, please make it lower case. Thanks! Maxime -- Maxime Ripard, Free Electrons Embedded Linux, Kernel and Android engineering http://free-electrons.com

[linux-sunxi] [PATCH] clk: sunxi: Remove clkdev registration

2014-05-14 Thread Maxime Ripard
We actually never used clkdev at all in the Allwinner support. Hence, this registration has always been dead code that can be removed. Signed-off-by: Maxime Ripard maxime.rip...@free-electrons.com --- drivers/clk/sunxi/clk-a10-hosc.c | 3 +-- drivers/clk/sunxi/clk-a20-gmac.c | 2 -- drivers

[linux-sunxi] Re: [PATCH RESEND v4 4/8] phy: usb: sunxi: Introduce Allwinner A31 USB PHY support

2014-05-14 Thread Maxime Ripard
}, { .compatible = allwinner,sun5i-a13-usb-phy }, + { .compatible = allwinner,sun6i-a31-usb-phy }, Do you have Documentation for this comptible binding? Would be good to mention that in the commit log. Ah right. I forgot. I'm sending you a followup patch. Thanks! Maxime -- Maxime Ripard, Free

[linux-sunxi] Re: [PATCH RESEND v4 0/8] Add Allwinner A31 USB support

2014-05-14 Thread Maxime Ripard
On Tue, May 13, 2014 at 05:44:14PM +0200, Maxime Ripard wrote: Hi everyone, This patchset adds support for the USB controllers found in the Allwinner A31. While the design is similar to the earlier Allwinner SoCs that are already supported, a few details here and there change, like

[linux-sunxi] [PATCH RESEND v4 1/8] clk: sunxi: Implement A31 USB clock

2014-05-14 Thread Maxime Ripard
The A31 USB clock slightly differ from its older counterparts, mostly because it has a different gate for each PHY, while the older one had a single gate for all the phy. Signed-off-by: Maxime Ripard maxime.rip...@free-electrons.com Reviewed-by: Hans de Goede hdego...@redhat.com Acked-by: Mike

[linux-sunxi] [PATCH] Documentation: dt: Add new compatible for the A31 USB Phy

2014-05-14 Thread Maxime Ripard
Document the freshly introduced compatible for the USB phy in use in the Allwinner A31 SoC. Signed-off-by: Maxime Ripard maxime.rip...@free-electrons.com --- .../devicetree/bindings/phy/sun4i-usb-phy.txt | 23 -- 1 file changed, 17 insertions(+), 6 deletions(-) diff

[linux-sunxi] Re: [PATCH v7 2/3] [media] rc: add sunxi-ir driver

2014-05-15 Thread Maxime Ripard
= rc_allocate_device(); + You can drop the extra line here Maxime -- Maxime Ripard, Free Electrons Embedded Linux, Kernel and Android engineering http://free-electrons.com signature.asc Description: Digital signature

[linux-sunxi] Re: [PATCH RESEND v4 1/8] clk: sunxi: Implement A31 USB clock

2014-05-15 Thread Maxime Ripard
On Wed, May 14, 2014 at 02:56:00PM +0200, Maxime Ripard wrote: The A31 USB clock slightly differ from its older counterparts, mostly because it has a different gate for each PHY, while the older one had a single gate for all the phy. Signed-off-by: Maxime Ripard maxime.rip...@free

[linux-sunxi] Re: [PATCH v4 0/7] mfd: add basic sun6i A31 PRCM support

2014-05-15 Thread Maxime Ripard
-by in sunxi/drivers-for-3.16, and patch 7 in sunxi/dt-for-3.16. Thanks! Maxime -- Maxime Ripard, Free Electrons Embedded Linux, Kernel and Android engineering http://free-electrons.com signature.asc Description: Digital signature

[linux-sunxi] Re: [PATCH v2 1/6] wdt: sunxi: Move restart code to the watchdog driver

2014-05-15 Thread Maxime Ripard
On Wed, May 07, 2014 at 02:33:18PM -0700, Guenter Roeck wrote: On Tue, May 06, 2014 at 09:44:19PM -0500, Maxime Ripard wrote: Most of the watchdog code is duplicated between the machine restart code and the watchdog driver. Add the restart hook to the watchdog driver, to be able

[linux-sunxi] Re: clk: sunxi: Remove clkdev registration breaks sunxi kernels

2014-05-15 Thread Maxime Ripard
. After reverting this patch everything works again. Right, it seems like we're still using clkdev for the clock protection bits. Let's drop this patch. Thanks, Maxime -- Maxime Ripard, Free Electrons Embedded Linux, Kernel and Android engineering http://free-electrons.com signature.asc

[linux-sunxi] Re: [PATCH v3 3/7] mfd: add support for sun6i PRCM (Power/Reset/Clock Management) unit

2014-05-15 Thread Maxime Ripard
. Other subdevices might be added later (if needed). Signed-off-by: Boris BREZILLON boris.brezil...@free-electrons.com Acked-by: Maxime Ripard maxime.rip...@free-electrons.com --- drivers/mfd/Kconfig | 8 +++ drivers/mfd/Makefile | 1 + drivers/mfd/sun6i-prcm.c

[linux-sunxi] Re: [PATCH v5 5/5] ARM: sunxi: select MFD_SUN6I_PRCM when sun6i arch support is enabled

2014-05-15 Thread Maxime Ripard
! Maxime -- Maxime Ripard, Free Electrons Embedded Linux, Kernel and Android engineering http://free-electrons.com signature.asc Description: Digital signature

[linux-sunxi] Re: [PATCH] ARM: sunxi: dt: build DTs according to new MACH_SUNxI Kconfig symbols

2014-05-17 Thread Maxime Ripard
we selected in kernel config. This matches the build behavior of the kernel itself after splitting up sunxi support to various SoCs in Kconfig. Maxime, could you take this? Applied, thanks. Maxime -- Maxime Ripard, Free Electrons Embedded Linux, Kernel and Android engineering http://free

[linux-sunxi] Re: [PATCH v3 3/7] mfd: add support for sun6i PRCM (Power/Reset/Clock Management) unit

2014-05-19 Thread Maxime Ripard
subdevices. Other subdevices might be added later (if needed). Signed-off-by: Boris BREZILLON boris.brezil...@free-electrons.com Acked-by: Maxime Ripard maxime.rip...@free-electrons.com --- drivers/mfd/Kconfig | 8 +++ drivers/mfd/Makefile | 1

[linux-sunxi] Re: [PATCH v3 3/7] mfd: add support for sun6i PRCM (Power/Reset/Clock Management) unit

2014-05-19 Thread Maxime Ripard
) and reset controller subdevices. Other subdevices might be added later (if needed). Signed-off-by: Boris BREZILLON boris.brezil...@free-electrons.com Acked-by: Maxime Ripard maxime.rip...@free-electrons.com --- drivers/mfd/Kconfig | 8

[linux-sunxi] Re: [PATCH v7] DMA: sun6i: Add driver for the Allwinner A31 DMA controller

2014-05-21 Thread Maxime Ripard
On Wed, May 21, 2014 at 11:01:05AM +0530, Vinod Koul wrote: On Tue, May 13, 2014 at 03:42:58PM +0200, Maxime Ripard wrote: Hi Vinod, On Wed, Apr 30, 2014 at 12:34:08PM +0530, Vinod Koul wrote: + +static int sun6i_dma_terminate_all(struct sun6i_vchan *vchan

[linux-sunxi] Re: [PATCH 1/2] ARM: dts: sun7i: cubietruck: set mmc3 bus-width property

2014-05-22 Thread Maxime Ripard
On Wed, May 21, 2014 at 07:43:30PM +0200, Hans de Goede wrote: bus-width defaults to 1, and all 4 lines are hooked up at the cubietruck, properly set bus-width to 4. Signed-off-by: Hans de Goede hdego...@redhat.com Merged the two patches, thanks! Maxime -- Maxime Ripard, Free Electrons

[linux-sunxi] [PATCH v9 0/2] Add support for the Allwinner A31 DMA Controller

2014-05-22 Thread Maxime Ripard
protecting patches - Minor fixes here and there as suggested by Andy Shevchenko: switch to dmam_pool_create, switch to dev_dbg instead of pr_debug, etc. Maxime Ripard (2): Documentation: dt: Add Allwinner A31 DMA controller bindings dmaengine: sun6i: Add driver for the Allwinner A31 DMA controller

[linux-sunxi] Re: [PATCH v2 1/6] wdt: sunxi: Move restart code to the watchdog driver

2014-05-22 Thread Maxime Ripard
On Mon, May 19, 2014 at 05:04:22PM +0200, Maxime Ripard wrote: On Thu, May 15, 2014 at 11:11:23AM +0200, Maxime Ripard wrote: On Wed, May 07, 2014 at 02:33:18PM -0700, Guenter Roeck wrote: On Tue, May 06, 2014 at 09:44:19PM -0500, Maxime Ripard wrote: Most of the watchdog code

[linux-sunxi] Re: [PATCH v2 1/6] wdt: sunxi: Move restart code to the watchdog driver

2014-05-22 Thread Maxime Ripard
On Thu, May 22, 2014 at 09:39:43PM +0100, One Thousand Gnomes wrote: On Thu, 22 May 2014 22:34:44 +0200 Maxime Ripard maxime.rip...@free-electrons.com wrote: On Mon, May 19, 2014 at 05:04:22PM +0200, Maxime Ripard wrote: On Thu, May 15, 2014 at 11:11:23AM +0200, Maxime Ripard wrote

[linux-sunxi] Re: [PATCH] pinctrl: sunxi: fix pin numbers passed to register offset helpers

2014-05-23 Thread Maxime Ripard
, Maxime -- Maxime Ripard, Free Electrons Embedded Linux, Kernel and Android engineering http://free-electrons.com signature.asc Description: Digital signature

[linux-sunxi] Re: [PATCH v2 1/6] wdt: sunxi: Move restart code to the watchdog driver

2014-05-23 Thread Maxime Ripard
On Thu, May 22, 2014 at 02:12:07PM -0700, Guenter Roeck wrote: On Thu, May 22, 2014 at 10:34:44PM +0200, Maxime Ripard wrote: On Mon, May 19, 2014 at 05:04:22PM +0200, Maxime Ripard wrote: On Thu, May 15, 2014 at 11:11:23AM +0200, Maxime Ripard wrote: On Wed, May 07, 2014 at 02:33:18PM

[linux-sunxi] Re: [PATCH RESEND v4 0/8] Add Allwinner A31 USB support

2014-05-23 Thread Maxime Ripard
Hi Greg, On Wed, May 14, 2014 at 06:05:20PM +0200, Greg Kroah-Hartman wrote: On Wed, May 14, 2014 at 02:34:19PM +0200, Maxime Ripard wrote: On Tue, May 13, 2014 at 05:44:14PM +0200, Maxime Ripard wrote: Hi everyone, This patchset adds support for the USB controllers found

[linux-sunxi] Re: [PATCH RESEND v4 0/8] Add Allwinner A31 USB support

2014-05-24 Thread Maxime Ripard
On Sat, May 24, 2014 at 07:19:40AM +0900, Greg Kroah-Hartman wrote: On Fri, May 23, 2014 at 08:33:39PM +0200, Maxime Ripard wrote: Hi Greg, On Wed, May 14, 2014 at 06:05:20PM +0200, Greg Kroah-Hartman wrote: On Wed, May 14, 2014 at 02:34:19PM +0200, Maxime Ripard wrote: On Tue, May

[linux-sunxi] Re: Booting 3.15 kernel on Cubietruck

2014-05-24 Thread Maxime Ripard
/jwrdegoede/u-boot-sunxi/commits/sunxi-test Maxime -- Maxime Ripard, Free Electrons Embedded Linux, Kernel and Android engineering http://free-electrons.com signature.asc Description: Digital signature

[linux-sunxi] Re: [PATCH v5 0/8] sunxi: initial upstreaming effort

2014-05-25 Thread Maxime Ripard
some patches for the A31. Unfortunately, we haven't figured out the DRAM initialization, so it's second-stage-only at the moment. Maxime -- Maxime Ripard, Free Electrons Embedded Linux, Kernel and Android engineering http://free-electrons.com signature.asc Description: Digital signature

[linux-sunxi] Re: [PATCH 01/11] pinctrl: sunxi: create irq/pin mapping during init

2014-05-27 Thread Maxime Ripard
the interrupts directly from the device tree. Can you be a bit more precise on this? What is the issue that this patch fix? Maxime -- Maxime Ripard, Free Electrons Embedded Linux, Kernel and Android engineering http://free-electrons.com signature.asc Description: Digital signature

[linux-sunxi] Re: [PATCH v8 3/3] ARM: sunxi: Add IR controller support in DT on A20

2014-05-27 Thread Maxime Ripard
+ I told you numerous times already that I wanted this patch to be split into at least three of them: - One to add the device to the DTSI. - One to add the pins - and one to enable the devices in the DTS. Please address this comment. Maxime -- Maxime Ripard, Free Electrons Embedded

[linux-sunxi] Re: [PATCH RESEND v4 0/8] Add Allwinner A31 USB support

2014-05-28 Thread Maxime Ripard
On Tue, May 27, 2014 at 03:53:18PM -0700, Greg Kroah-Hartman wrote: On Thu, May 15, 2014 at 11:14:38AM +0200, Maxime Ripard wrote: Hi Greg, On Wed, May 14, 2014 at 06:05:20PM +0200, Greg Kroah-Hartman wrote: On Wed, May 14, 2014 at 02:34:19PM +0200, Maxime Ripard wrote: On Tue, May

[linux-sunxi] Re: [PATCH 03/11] pinctrl: sunxi: Move setting of mux to irq type from unmask to set_type

2014-05-28 Thread Maxime Ripard
On Tue, May 27, 2014 at 11:01:03AM +0200, Hans de Goede wrote: Hi, On 05/27/2014 10:09 AM, Maxime Ripard wrote: On Mon, May 26, 2014 at 09:47:58AM +0200, Hans de Goede wrote: With level triggered interrupt mask / unmask will get called for each interrupt, doing the somewhat expensive mux

[linux-sunxi] Re: [PATCH 02/11] pinctrl: sunxi: add IRQCHIP_SKIP_SET_WAKE flag for pinctrl irq chip

2014-05-28 Thread Maxime Ripard
On Tue, May 27, 2014 at 06:14:31PM +0200, Tomasz Figa wrote: On 27.05.2014 10:07, Maxime Ripard wrote: On Mon, May 26, 2014 at 09:47:57AM +0200, Hans de Goede wrote: From: Chen-Yu Tsai w...@csie.org The sunxi pinctrl irq chip driver does not support wakeup at the moment. Adding

[linux-sunxi] Re: [PATCH 03/11] pinctrl: sunxi: Move setting of mux to irq type from unmask to set_type

2014-05-28 Thread Maxime Ripard
On Wed, May 28, 2014 at 11:51:52AM +0200, Hans de Goede wrote: Hi, On 05/28/2014 11:36 AM, Maxime Ripard wrote: On Tue, May 27, 2014 at 04:18:29PM +0200, Linus Walleij wrote: On Mon, May 26, 2014 at 9:47 AM, Hans de Goede hdego...@redhat.com wrote: With level triggered interrupt mask

[linux-sunxi] Re: Booting 3.15 kernel on Cubietruck

2014-05-29 Thread Maxime Ripard
On Tue, May 27, 2014 at 08:17:43PM -0400, jonsm...@gmail.com wrote: On Sun, May 25, 2014 at 2:34 PM, Maxime Ripard maxime.rip...@free-electrons.com wrote: On Sat, May 24, 2014 at 11:50:20AM -0400, jonsm...@gmail.com wrote: I seem to have fried TX on my TTL serial converter. I can't get a new

[linux-sunxi] Re: [PATCH v2 1/5] pinctrl: sunxi: Fix sunxi_irq_cfg_reg not working for irqs = 8

2014-06-02 Thread Maxime Ripard
serie with minor modifications (remove the cfg_reg_from_bank that doesn't make any sense). Thanks, Maxime -- Maxime Ripard, Free Electrons Embedded Linux, Kernel and Android engineering http://free-electrons.com signature.asc Description: Digital signature

[linux-sunxi] Re: [PATCH v2 2/5] pinctrl: sunxi: Add IRQCHIP_SKIP_SET_WAKE flag for pinctrl irq chip

2014-06-02 Thread Maxime Ripard
Signed-off-by: Hans de Goede hdego...@redhat.com Acked-by: Maxime Ripard maxime.rip...@free-electrons.com Thanks! Maxime -- Maxime Ripard, Free Electrons Embedded Linux, Kernel and Android engineering http://free-electrons.com signature.asc Description: Digital signature

[linux-sunxi] Re: [PATCH 03/11] pinctrl: sunxi: Move setting of mux to irq type from unmask to set_type

2014-06-02 Thread Maxime Ripard
On Sat, May 31, 2014 at 11:13:05AM +0200, Hans de Goede wrote: Hi, On 05/28/2014 12:33 PM, Maxime Ripard wrote: On Wed, May 28, 2014 at 11:51:52AM +0200, Hans de Goede wrote: Hi, On 05/28/2014 11:36 AM, Maxime Ripard wrote: On Tue, May 27, 2014 at 04:18:29PM +0200, Linus Walleij wrote

[linux-sunxi] Re: [PATCH v2 3/5] pinctrl: sunxi: Move setting of mux to irq type from unmask to request_resources

2014-06-02 Thread Maxime Ripard
, but we should add a check for func being !NULL here, otherwise, the kernel is going to blow up at the next line. And since gpio_to_irq might not be called before the request_irq, you might be in such a case. Maxime -- Maxime Ripard, Free Electrons Embedded Linux, Kernel and Android engineering

[linux-sunxi] Re: [PATCH v2 4/5] pinctrl: sunxi: Properly handle level triggered gpio interrupts

2014-06-03 Thread Maxime Ripard
, thanks. Maxime -- Maxime Ripard, Free Electrons Embedded Linux, Kernel and Android engineering http://free-electrons.com signature.asc Description: Digital signature

[linux-sunxi] Re: [PATCH v2 5/5] pinctrl: sunxi: Define enable / disable irq callbacks for level triggered irqs

2014-06-03 Thread Maxime Ripard
); + + spin_unlock_irqrestore(pctl-lock, flags); +} Please at least call sunxi_pinctrl_irq_ack and sunxi_pinctrl_irq_unmask if you're doing this. Maxime -- Maxime Ripard, Free Electrons Embedded Linux, Kernel and Android engineering http://free-electrons.com signature.asc Description: Digital signature

[linux-sunxi] Re: Booting 3.15 kernel on Cubietruck

2014-06-10 Thread Maxime Ripard
: No PMIC hook to init smartreflex [0.782419] sr_init: platform driver register failed for SR Could you remove the loglevel parameter, and repost what you have? Maxime -- Maxime Ripard, Free Electrons Embedded Linux, Kernel and Android engineering http://free-electrons.com signature.asc

Re: [linux-sunxi] Detecting CPU type on 3.15 kernel

2014-06-13 Thread Maxime Ripard
to it eventually, but I don't get what it would bring here. Have different compatible strings for the various revisions of the IP is much simpler and adds no code at all. Maxime -- Maxime Ripard, Free Electrons Embedded Linux, Kernel and Android engineering http://free-electrons.com

Re: [linux-sunxi] Detecting CPU type on 3.15 kernel

2014-06-13 Thread Maxime Ripard
On Fri, Jun 13, 2014 at 08:09:36AM -0400, jonsm...@gmail.com wrote: On Fri, Jun 13, 2014 at 6:15 AM, Maxime Ripard maxime.rip...@free-electrons.com wrote: On Fri, Jun 13, 2014 at 11:54:06AM +0200, Hans de Goede wrote: Hi, On 06/13/2014 10:40 AM, Maxime Ripard wrote: On Fri, Jun 13

[linux-sunxi] Re: [PATCH v9 4/5] ARM: sunxi: Add IR controllers on A20 to dtsi

2014-06-16 Thread Maxime Ripard
, but it doesn't apply, since the above node doesn't exist. Please rebase on top of v3.16-rc1 and resend the patch. Maxime -- Maxime Ripard, Free Electrons Embedded Linux, Kernel and Android engineering http://free-electrons.com signature.asc Description: Digital signature

[linux-sunxi] Re: [PATCH v9 3/5] ARM: sunxi: Add pins for IR controller on A20 to dtsi

2014-06-16 Thread Maxime Ripard
Hi, On Mon, Jun 09, 2014 at 12:08:11AM +0600, Alexander Bersenev wrote: This patch adds pins for two IR controllers on A20 Signed-off-by: Alexander Bersenev b...@hackerdom.ru Signed-off-by: Alexsey Shestacov wingr...@linux-sunxi.org Applied, thanks. Maxime -- Maxime Ripard, Free

[linux-sunxi] Re: [PATCH v9 5/5] ARM: sunxi: Enable IR controller on cubieboard 2 and cubietruck in dts

2014-06-16 Thread Maxime Ripard
wingr...@linux-sunxi.org Applied, thanks. Maxime -- Maxime Ripard, Free Electrons Embedded Linux, Kernel and Android engineering http://free-electrons.com signature.asc Description: Digital signature

[linux-sunxi] Re: [PATCH v2 4/5] pinctrl: sunxi: Properly handle level triggered gpio interrupts

2014-06-17 Thread Maxime Ripard
On Tue, Jun 03, 2014 at 05:13:17PM +0200, Hans de Goede wrote: Hi, On 06/03/2014 03:30 PM, Maxime Ripard wrote: On Sat, May 31, 2014 at 04:01:38PM +0200, Hans de Goede wrote: For level triggered gpio interrupts we need to use handle_fasteoi_irq, like we do with the irq-sunxi-nmi driver

[linux-sunxi] Re: [PATCH v4 4/7] regulator: axp20x: reset probe data before each probe

2014-06-17 Thread Maxime Ripard
].init_data = NULL; + matches[i].of_node = NULL; + } + That looks rather hackish, especially since we've never been in such a case yet, since we have a single PMIC in our system. Can't you just use memzero here? Maxime -- Maxime Ripard, Free Electrons Embedded Linux, Kernel

[linux-sunxi] Re: [PATCH v2 04/20] clk: sunxi: Fix gate indexing for sun6i-a31-apb0-gates

2014-06-18 Thread Maxime Ripard
. Signed-off-by: Chen-Yu Tsai w...@csie.org Acked-by: Maxime Ripard maxime.rip...@free-electrons.com Maxime -- Maxime Ripard, Free Electrons Embedded Linux, Kernel and Android engineering http://free-electrons.com signature.asc Description: Digital signature

[linux-sunxi] Re: [PATCH v2 09/20] clk: sunxi: Add sun6i MBUS clock support

2014-06-18 Thread Maxime Ripard
sun4i_mod0_config = { .pwidth = 2, }; +static struct clk_factors_config sun6i_a31_mbus_config = { + .mshift = 0, + .mwidth = 3, Actually, the A31 has an extra N factor. So this mbus clock looks like it's only about the A23, and not the A31 at all. Maxime -- Maxime Ripard

[linux-sunxi] Re: [PATCH v2 10/20] clk: sunxi: Add support for table-based divider clocks

2014-06-18 Thread Maxime Ripard
will know about the odd values. Signed-off-by: Chen-Yu Tsai w...@csie.org Acked-by: Maxime Ripard maxime.rip...@free-electrons.com Maxime -- Maxime Ripard, Free Electrons Embedded Linux, Kernel and Android engineering http://free-electrons.com signature.asc Description: Digital signature

[linux-sunxi] Re: [PATCH v2 13/20] clk: sunxi: Add A23 specific compatible to sun6i-a31-apb0-gates-clk

2014-06-18 Thread Maxime Ripard
is the same as the A31. To make it clear, we add a new compatible for the A23, allwinner,sun8i-a23-apb0-gates-clk. Signed-off-by: Chen-Yu Tsai w...@csie.org Acked-by: Maxime Ripard maxime.rip...@free-electrons.com Maxime -- Maxime Ripard, Free Electrons Embedded Linux, Kernel and Android engineering

[linux-sunxi] Re: [PATCH v2 11/20] clk: sunxi: Add A23 clocks support

2014-06-18 Thread Maxime Ripard
that on older Allwinner SoCs, such as the A10 or A20, but the N factor starts from 1 instead of 0. This patch adds support for PLL1 and all the basic clock gates. Signed-off-by: Chen-Yu Tsai w...@csie.org Except for the minor comment below, you have my Acked-by: Maxime Ripard maxime.rip

[linux-sunxi] Re: [PATCH v2 12/20] clk: sunxi: Add A23 APB0 support to sun6i-a31-apb0-clk

2014-06-18 Thread Maxime Ripard
that it will actually work for the A31, since it does define some dividers anyway, and the divider table is !NULL, even though there's actually no dividers defined. Maxime -- Maxime Ripard, Free Electrons Embedded Linux, Kernel and Android engineering http://free-electrons.com signature.asc Description

[linux-sunxi] Re: [PATCH v2 16/20] mfd: sun6i-prcm: Add support for Allwinner A23 PRCM

2014-06-18 Thread Maxime Ripard
on the previous patches, so I'm not even sure this patch can go as is. It would be much easier if you (ChenYu) could introduce first a very basic with just the UART support, and then, as separate series, clocks, PRCM, MMC, and so on. Maxime -- Maxime Ripard, Free Electrons Embedded Linux, Kernel and Android

[linux-sunxi] Re: [PATCH v2 18/20] ARM: sunxi: Add earlyprintk support using R_UART (sun6i/sun8i)

2014-06-18 Thread Maxime Ripard
Acked-by: Maxime Ripard maxime.rip...@free-electrons.com Maxime -- Maxime Ripard, Free Electrons Embedded Linux, Kernel and Android engineering http://free-electrons.com signature.asc Description: Digital signature

[linux-sunxi] Re: [PATCH v2 12/20] clk: sunxi: Add A23 APB0 support to sun6i-a31-apb0-clk

2014-06-19 Thread Maxime Ripard
On Thu, Jun 19, 2014 at 12:33:41PM +0800, Chen-Yu Tsai wrote: On Wed, Jun 18, 2014 at 6:26 PM, Maxime Ripard maxime.rip...@free-electrons.com wrote: On Tue, Jun 17, 2014 at 10:52:49PM +0800, Chen-Yu Tsai wrote: The A23 has an almost identical PRCM clock tree. The difference in the APB0

[linux-sunxi] Re: [PATCH v2 1/6] wdt: sunxi: Move restart code to the watchdog driver

2014-06-23 Thread Maxime Ripard
On Thu, May 22, 2014 at 02:12:07PM -0700, Guenter Roeck wrote: On Thu, May 22, 2014 at 10:34:44PM +0200, Maxime Ripard wrote: On Mon, May 19, 2014 at 05:04:22PM +0200, Maxime Ripard wrote: On Thu, May 15, 2014 at 11:11:23AM +0200, Maxime Ripard wrote: On Wed, May 07, 2014 at 02:33:18PM

[linux-sunxi] Re: [PATCH v10 4/5] ARM: sunxi: Add IR controllers on A20 to dtsi

2014-06-23 Thread Maxime Ripard
On Sat, Jun 21, 2014 at 05:04:05PM +0600, Alexander Bersenev wrote: This patch adds records for two IR controllers on A20 Signed-off-by: Alexander Bersenev b...@hackerdom.ru Signed-off-by: Alexsey Shestacov wingr...@linux-sunxi.org Applied, thanks. Maxime -- Maxime Ripard, Free Electrons

[linux-sunxi] Re: [PATCH v2 1/6] wdt: sunxi: Move restart code to the watchdog driver

2014-06-23 Thread Maxime Ripard
tree some patches that were depending on this one based on that assumption. And now, we have a regression. Anyway... I guess I should just revert some commits now. Maxime -- Maxime Ripard, Free Electrons Embedded Linux, Kernel and Android engineering http://free-electrons.com signature.asc

[linux-sunxi] Re: [PATCH v3 2/4] ARM: sunxi: Add earlyprintk support using R_UART (sun6i/sun8i)

2014-06-23 Thread Maxime Ripard
Acked-by: Maxime Ripard maxime.rip...@free-electrons.com Applied, thanks Maxime -- Maxime Ripard, Free Electrons Embedded Linux, Kernel and Android engineering http://free-electrons.com signature.asc Description: Digital signature

[linux-sunxi] Re: [PATCH v3 1/4] ARM: sunxi: Introduce Allwinner A23 support

2014-06-23 Thread Maxime Ripard
On Fri, Jun 20, 2014 at 10:52:50PM +0800, Chen-Yu Tsai wrote: The Allwinner A23 is a dual-core Cortex-A7-based SoC. It re-uses most of the IPs found in previous SoCs, notably the A31. Signed-off-by: Chen-Yu Tsai w...@csie.org Applied, thanks Maxime -- Maxime Ripard, Free Electrons

[linux-sunxi] Re: [PATCH v3 3/4] ARM: sunxi: Add Allwinner A23 dtsi

2014-06-23 Thread Maxime Ripard
On Fri, Jun 20, 2014 at 10:52:52PM +0800, Chen-Yu Tsai wrote: The Allwinner A23 is a tablet oriented SoC with 2 Cortex-A7 cores and a Mali-400MP2 GPU. Signed-off-by: Chen-Yu Tsai w...@csie.org Applied, thanks Maxime -- Maxime Ripard, Free Electrons Embedded Linux, Kernel and Android

[linux-sunxi] Re: [PATCH v3 4/4] ARM: sun8i: dt: Add Ippo-q8h v5 support

2014-06-23 Thread Maxime Ripard
Fixed the whitespace warning and applied. Thanks! Maxime -- Maxime Ripard, Free Electrons Embedded Linux, Kernel and Android engineering http://free-electrons.com signature.asc Description: Digital signature

Re: [linux-sunxi] Re: [PATCH v10 4/5] ARM: sunxi: Add IR controllers on A20 to dtsi

2014-06-23 Thread Maxime Ripard
On Mon, Jun 23, 2014 at 01:08:24PM -0700, Александр Берсенев wrote: Thanks, Should I send applied patches in the further versions of this patch set? No, you don't have to. Maxime -- Maxime Ripard, Free Electrons Embedded Linux, Kernel and Android engineering http://free-electrons.com

[linux-sunxi] Re: [PATCH v2 1/6] wdt: sunxi: Move restart code to the watchdog driver

2014-06-24 Thread Maxime Ripard
-- Maxime Ripard, Free Electrons Embedded Linux, Kernel and Android engineering http://free-electrons.com signature.asc Description: Digital signature

[linux-sunxi] Re: [PATCH v3 0/6] clk: sunxi: fixes, cleanups and A23 basic clocks

2014-06-25 Thread Maxime Ripard
for the basic clocks in the A23, just PLL1 for cpus, and the system bus clocks and gates. The last patch adds the DT nodes for the newly added clocks. Patch 1 should be merged for 3.16, while the rest should go in 3.17. Why should it go in for 3.16? Is there any user for it yet? Maxime -- Maxime

[linux-sunxi] Re: [PATCH v3 3/6] clk: sunxi: Support factor clocks with N factor starting not from 0

2014-06-25 Thread Maxime Ripard
. Signed-off-by: Chen-Yu Tsai w...@csie.org Acked-by: Maxime Ripard maxime.rip...@free-electrons.com Maxime -- Maxime Ripard, Free Electrons Embedded Linux, Kernel and Android engineering http://free-electrons.com signature.asc Description: Digital signature

<    1   2   3   4   5   6   7   8   9   10   >