Re: [linux-sunxi] [PATCH v2 1/2] sunxi: Rename bananapi board as bananapi m1

[Maxime Ripard]

On Tue, May 30, 2017 at 09:31:13AM +0800, Chen-Yu Tsai wrote:
> Hi,
> 
> On Tue, May 30, 2017 at 5:58 AM, Karsten Merker  wrote:
> > On Tue, May 30, 2017 at 01:06:54AM +0530, Jagan Teki wrote:
> >> From: Jagan Teki 
> >>
> >> from BPI(BIPAI KEJI LIMITED) products the Bananapi board
> >> is named as 'Bananapi M1' and this is the starting
> >> bananapi board from M1 series.
> >>
> >> So rename the board defconfig, dts and suffix 'M1' on
> >> model for the same  so-that next sequence on bananapi starts
> >> like M1 Plus, M2 and so.on
> >
> > Hello,
> >
> > the equivalent change in the kernel has been NACKed by me as with
> > the proposed change the installation of a newer kernel would
> > break a large number of existing end user systems (which rely on
> > the old dts file name and on the old model string).
> >
> > U-Boot should keep the same dts as the kernel, so this
> > effectively means a NACK to this change for u-boot as well.
> 
> Do the distros also keep a list of defconfig targets to build
> for U-boot?  It seems that way for Debian. I imagine just
> changing the defconfig names would be troublesome for the
> maintainers.

Not only the distros, but all the buildsystems too. This is really
something we shouldn't change, ever.

Maxime

-- 
Maxime Ripard, Free Electrons
Embedded Linux and Kernel engineering
http://free-electrons.com

-- 
You received this message because you are subscribed to the Google Groups 
"linux-sunxi" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to linux-sunxi+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/d/optout.


signature.asc
Description: PGP signature

Re: [linux-sunxi] [PATCH v2 1/2] sunxi: Rename bananapi board as bananapi m1

[Chen-Yu Tsai]

Hi,

On Tue, May 30, 2017 at 5:58 AM, Karsten Merker  wrote:
> On Tue, May 30, 2017 at 01:06:54AM +0530, Jagan Teki wrote:
>> From: Jagan Teki 
>>
>> from BPI(BIPAI KEJI LIMITED) products the Bananapi board
>> is named as 'Bananapi M1' and this is the starting
>> bananapi board from M1 series.
>>
>> So rename the board defconfig, dts and suffix 'M1' on
>> model for the same  so-that next sequence on bananapi starts
>> like M1 Plus, M2 and so.on
>
> Hello,
>
> the equivalent change in the kernel has been NACKed by me as with
> the proposed change the installation of a newer kernel would
> break a large number of existing end user systems (which rely on
> the old dts file name and on the old model string).
>
> U-Boot should keep the same dts as the kernel, so this
> effectively means a NACK to this change for u-boot as well.

Do the distros also keep a list of defconfig targets to build
for U-boot?  It seems that way for Debian. I imagine just
changing the defconfig names would be troublesome for the
maintainers.

ChenYu

-- 
You received this message because you are subscribed to the Google Groups 
"linux-sunxi" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to linux-sunxi+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/d/optout.

[linux-sunxi] [PATCH v2 1/2] sunxi: Rename bananapi board as bananapi m1

[Jagan Teki]

From: Jagan Teki 

from BPI(BIPAI KEJI LIMITED) products the Bananapi board
is named as 'Bananapi M1' and this is the starting
bananapi board from M1 series.

So rename the board defconfig, dts and suffix 'M1' on
model for the same  so-that next sequence on bananapi starts
like M1 Plus, M2 and so.on

Cc: Icenowy Zheng 
Signed-off-by: Jagan Teki 
---
Changes for v2:
- Newly added patch

 arch/arm/dts/sun7i-a20-bananapi-m1.dts | 293 +
 arch/arm/dts/sun7i-a20-bananapi.dts| 293 -
 board/sunxi/MAINTAINERS|   2 +-
 configs/Bananapi_M1_defconfig  |  23 +++
 configs/Bananapi_defconfig |  23 ---
 5 files changed, 317 insertions(+), 317 deletions(-)
 create mode 100644 arch/arm/dts/sun7i-a20-bananapi-m1.dts
 delete mode 100644 arch/arm/dts/sun7i-a20-bananapi.dts
 create mode 100644 configs/Bananapi_M1_defconfig
 delete mode 100644 configs/Bananapi_defconfig

diff --git a/arch/arm/dts/sun7i-a20-bananapi-m1.dts 
b/arch/arm/dts/sun7i-a20-bananapi-m1.dts
new file mode 100644
index 000..4a1d7d7
--- /dev/null
+++ b/arch/arm/dts/sun7i-a20-bananapi-m1.dts
@@ -0,0 +1,293 @@
+/*
+ * Copyright 2014 Hans de Goede 
+ *
+ * Hans de Goede 
+ *
+ * This file is dual-licensed: you can use it either under the terms
+ * of the GPL or the X11 license, at your option. Note that this dual
+ * licensing only applies to this file, and not this project as a
+ * whole.
+ *
+ *  a) This file is free software; you can redistribute it and/or
+ * modify it under the terms of the GNU General Public License as
+ * published by the Free Software Foundation; either version 2 of the
+ * License, or (at your option) any later version.
+ *
+ * This file is distributed in the hope that it will be useful,
+ * but WITHOUT ANY WARRANTY; without even the implied warranty of
+ * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
+ * GNU General Public License for more details.
+ *
+ * Or, alternatively,
+ *
+ *  b) Permission is hereby granted, free of charge, to any person
+ * obtaining a copy of this software and associated documentation
+ * files (the "Software"), to deal in the Software without
+ * restriction, including without limitation the rights to use,
+ * copy, modify, merge, publish, distribute, sublicense, and/or
+ * sell copies of the Software, and to permit persons to whom the
+ * Software is furnished to do so, subject to the following
+ * conditions:
+ *
+ * The above copyright notice and this permission notice shall be
+ * included in all copies or substantial portions of the Software.
+ *
+ * THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND,
+ * EXPRESS OR IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES
+ * OF MERCHANTABILITY, FITNESS FOR A PARTICULAR PURPOSE AND
+ * NONINFRINGEMENT. IN NO EVENT SHALL THE AUTHORS OR COPYRIGHT
+ * HOLDERS BE LIABLE FOR ANY CLAIM, DAMAGES OR OTHER LIABILITY,
+ * WHETHER IN AN ACTION OF CONTRACT, TORT OR OTHERWISE, ARISING
+ * FROM, OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR
+ * OTHER DEALINGS IN THE SOFTWARE.
+ */
+
+/dts-v1/;
+#include "sun7i-a20.dtsi"
+#include "sunxi-common-regulators.dtsi"
+
+#include 
+#include 
+#include 
+
+/ {
+   model = "LeMaker Banana Pi M1";
+   compatible = "lemaker,bananapi", "allwinner,sun7i-a20";
+
+   aliases {
+   serial0 = 
+   serial1 = 
+   serial2 = 
+   };
+
+   chosen {
+   stdout-path = "serial0:115200n8";
+   };
+
+   leds {
+   compatible = "gpio-leds";
+   pinctrl-names = "default";
+   pinctrl-0 = <_pins_bananapi>;
+
+   green {
+   label = "bananapi:green:usr";
+   gpios = < 7 24 GPIO_ACTIVE_HIGH>;
+   };
+   };
+
+   reg_gmac_3v3: gmac-3v3 {
+   compatible = "regulator-fixed";
+   pinctrl-names = "default";
+   pinctrl-0 = <_power_pin_bananapi>;
+   regulator-name = "gmac-3v3";
+   regulator-min-microvolt = <330>;
+   regulator-max-microvolt = <330>;
+   startup-delay-us = <10>;
+   enable-active-high;
+   gpio = < 7 23 GPIO_ACTIVE_HIGH>;
+   };
+};
+
+ {
+   status = "okay";
+};
+
+ {
+   status = "okay";
+};
+
+ {
+   cpu-supply = <_dcdc2>;
+   operating-points = <
+   /* kHzuV */
+   96  140
+   912000  140
+   864000  135
+   72  125
+   528000  115
+   312000  110
+   144000  105
+   >;
+};
+
+ {
+   status = "okay";
+};
+
+ {
+