[linux-sunxi] Re: [PATCH] input: sun4i-lradc-keys - Add wakup support

2021-01-03 Thread Dmitry Torokhov
Hi Samuel, On Sun, Jan 03, 2021 at 04:54:46AM -0600, Samuel Holland wrote: > From: Ondrej Jirman > > Allow the driver to wake up the system on key press. Since using the > LRADC as a wakeup source requires keeping on an additional power domain, > disable the wakeup source by default. Why isn't

Re: [linux-sunxi] Re: [PATCH] input: sun4i-lradc-keys: Add wakup support

2019-10-29 Thread Ondřej Jirman
On Mon, Oct 28, 2019 at 09:18:04PM -0700, Dmitry Torokhov wrote: > On Tue, Oct 29, 2019 at 02:45:59AM +0100, Ondřej Jirman wrote: > > On Mon, Oct 28, 2019 at 05:12:50PM -0700, Dmitry Torokhov wrote: > > > On Tue, Oct 29, 2019 at 12:56:26AM +0100, Ondřej Jirman wrote: > > > > On Mon, Oct 28, 2019

Re: [linux-sunxi] Re: [PATCH] input: sun4i-lradc-keys: Add wakup support

2019-10-28 Thread Dmitry Torokhov
On Tue, Oct 29, 2019 at 02:45:59AM +0100, Ondřej Jirman wrote: > On Mon, Oct 28, 2019 at 05:12:50PM -0700, Dmitry Torokhov wrote: > > On Tue, Oct 29, 2019 at 12:56:26AM +0100, Ondřej Jirman wrote: > > > On Mon, Oct 28, 2019 at 04:38:28PM -0700, Dmitry Torokhov wrote: > > > > > + > > > > > +

Re: [linux-sunxi] Re: [PATCH] input: sun4i-lradc-keys: Add wakup support

2019-10-28 Thread Ondřej Jirman
On Mon, Oct 28, 2019 at 05:12:50PM -0700, Dmitry Torokhov wrote: > On Tue, Oct 29, 2019 at 12:56:26AM +0100, Ondřej Jirman wrote: > > On Mon, Oct 28, 2019 at 04:38:28PM -0700, Dmitry Torokhov wrote: > > > > + > > > > + error = dev_pm_set_wake_irq(dev, irq); > > > > + if (error) { > > >

[linux-sunxi] Re: [PATCH] input: sun4i-lradc-keys: Add wakup support

2019-10-28 Thread Dmitry Torokhov
On Tue, Oct 29, 2019 at 12:56:26AM +0100, Ondřej Jirman wrote: > Hello Dmitry, > > On Mon, Oct 28, 2019 at 04:38:28PM -0700, Dmitry Torokhov wrote: > > Hi Ondrej, > > > > On Mon, Oct 28, 2019 at 11:15:02PM +0100, Ondrej Jirman wrote: > > > Allow the driver to wakeup the system on key press. > >

[linux-sunxi] Re: [PATCH] input: sun4i-lradc-keys: Add wakup support

2019-10-28 Thread Ondřej Jirman
Hello Dmitry, On Mon, Oct 28, 2019 at 04:38:28PM -0700, Dmitry Torokhov wrote: > Hi Ondrej, > > On Mon, Oct 28, 2019 at 11:15:02PM +0100, Ondrej Jirman wrote: > > Allow the driver to wakeup the system on key press. > > > > Signed-off-by: Ondrej Jirman > > --- > >

[linux-sunxi] Re: [PATCH] input: sun4i-lradc-keys: Add wakup support

2019-10-28 Thread Dmitry Torokhov
Hi Ondrej, On Mon, Oct 28, 2019 at 11:15:02PM +0100, Ondrej Jirman wrote: > Allow the driver to wakeup the system on key press. > > Signed-off-by: Ondrej Jirman > --- > drivers/input/keyboard/sun4i-lradc-keys.c | 22 ++ > 1 file changed, 18 insertions(+), 4 deletions(-) >