[linux-sunxi] Re: [PATCH 03/11] pinctrl: sunxi: Move setting of mux to irq type from unmask to set_type

2014-06-02 Thread Maxime Ripard
On Sat, May 31, 2014 at 11:13:05AM +0200, Hans de Goede wrote: Hi, On 05/28/2014 12:33 PM, Maxime Ripard wrote: On Wed, May 28, 2014 at 11:51:52AM +0200, Hans de Goede wrote: Hi, On 05/28/2014 11:36 AM, Maxime Ripard wrote: On Tue, May 27, 2014 at 04:18:29PM +0200, Linus Walleij wrote:

[linux-sunxi] Re: [PATCH 03/11] pinctrl: sunxi: Move setting of mux to irq type from unmask to set_type

2014-05-31 Thread Hans de Goede
Hi, On 05/28/2014 12:33 PM, Maxime Ripard wrote: On Wed, May 28, 2014 at 11:51:52AM +0200, Hans de Goede wrote: Hi, On 05/28/2014 11:36 AM, Maxime Ripard wrote: On Tue, May 27, 2014 at 04:18:29PM +0200, Linus Walleij wrote: On Mon, May 26, 2014 at 9:47 AM, Hans de Goede hdego...@redhat.com

[linux-sunxi] Re: [PATCH 03/11] pinctrl: sunxi: Move setting of mux to irq type from unmask to set_type

2014-05-28 Thread Maxime Ripard
On Tue, May 27, 2014 at 11:01:03AM +0200, Hans de Goede wrote: Hi, On 05/27/2014 10:09 AM, Maxime Ripard wrote: On Mon, May 26, 2014 at 09:47:58AM +0200, Hans de Goede wrote: With level triggered interrupt mask / unmask will get called for each interrupt, doing the somewhat expensive mux

[linux-sunxi] Re: [PATCH 03/11] pinctrl: sunxi: Move setting of mux to irq type from unmask to set_type

2014-05-28 Thread Hans de Goede
Hi, On 05/28/2014 11:36 AM, Maxime Ripard wrote: On Tue, May 27, 2014 at 04:18:29PM +0200, Linus Walleij wrote: On Mon, May 26, 2014 at 9:47 AM, Hans de Goede hdego...@redhat.com wrote: With level triggered interrupt mask / unmask will get called for each interrupt, doing the somewhat

[linux-sunxi] Re: [PATCH 03/11] pinctrl: sunxi: Move setting of mux to irq type from unmask to set_type

2014-05-28 Thread Maxime Ripard
On Wed, May 28, 2014 at 11:51:52AM +0200, Hans de Goede wrote: Hi, On 05/28/2014 11:36 AM, Maxime Ripard wrote: On Tue, May 27, 2014 at 04:18:29PM +0200, Linus Walleij wrote: On Mon, May 26, 2014 at 9:47 AM, Hans de Goede hdego...@redhat.com wrote: With level triggered interrupt mask /

[linux-sunxi] Re: [PATCH 03/11] pinctrl: sunxi: Move setting of mux to irq type from unmask to set_type

2014-05-27 Thread Hans de Goede
Hi, On 05/27/2014 10:09 AM, Maxime Ripard wrote: On Mon, May 26, 2014 at 09:47:58AM +0200, Hans de Goede wrote: With level triggered interrupt mask / unmask will get called for each interrupt, doing the somewhat expensive mux setting on each unmask thus is not a good idea. Instead move it to

[linux-sunxi] Re: [PATCH 03/11] pinctrl: sunxi: Move setting of mux to irq type from unmask to set_type

2014-05-27 Thread Linus Walleij
On Mon, May 26, 2014 at 9:47 AM, Hans de Goede hdego...@redhat.com wrote: With level triggered interrupt mask / unmask will get called for each interrupt, doing the somewhat expensive mux setting on each unmask thus is not a good idea. Instead move it to the set_type callback, which is